On Fri, 16 Feb 2018 10:54:40 -0600 Derek Foreman <[email protected]> wrote:
> commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe > warned this was coming, back in 2013. > > I've seen libraries that have wayland client and server using functions > in the same file. Since struct wl_buffer still exists as an opaque > entity in client code, the vestigial deprecated wl_buffer from the > server include will generate warnings when not building with > WL_HIDE_DEPRECATED. > > Signed-off-by: Derek Foreman <[email protected]> > --- > > Is there anyone out there this will hurt? > > I'd like to at least see WL_DEPRECATED dropped from wl_buffer, > since it causes annoying build warnings when mixing client/server > code in the same files - even when not using the non-opaque > struct wl_buffer. > > > src/wayland-server.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/src/wayland-server.h b/src/wayland-server.h > index ccf9783..1be565f 100644 > --- a/src/wayland-server.h > +++ b/src/wayland-server.h > @@ -70,12 +70,6 @@ struct wl_resource { > void *data; > }; > > -struct wl_buffer { > - struct wl_resource resource; > - int32_t width, height; > - uint32_t busy_count; > -} WL_DEPRECATED; > - > uint32_t > wl_client_add_resource(struct wl_client *client, > struct wl_resource *resource) WL_DEPRECATED; Hi Derek, while I would argue that no-one should be building without WL_HIDE_DEPRECATED, that's somewhat orthogonal to this, so I have nothing against this change. Therefore: Reviewed-by: Pekka Paalanen <[email protected]> Thanks, pq
pgpH3QIOCeC5U.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
