On Tue, 17 Mar 2026 10:06:43 GMT, Paul Hübner <[email protected]> wrote:
> Hi, > > SA does not support value objects. The tests should be disabled when running > with `--enable-preview`. Currently, all SA tests use `@requires vm.hasSA`. > > Extending `vm.hasSA` to require non-preview automagically skips all of the > relevant tests. > > Testing on Linux (x64, AArch64), macOS (x64, AArch64), Windows x64: > * tier 1 sanity test > * `:hotspot_serviceability` (most of the SA tests), with and without preview > * `:hotspot_resourcehogs` (some SA tests), with and without preview > * `:svc_tools` (some `jhsdb` tests), with and without preview It is best to detect new failures as they happen, not months down the road when someone decides to disable this change and retest, and then has to figure out what changes caused the new failures. It looks like only 8 tests out of about 90 tests are failing. Most of the failures I skimmed over already have bugs filed for them. We should get them all problem listed so we have clean results and can then readily detect new failures. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2236#issuecomment-4085281721
