On Tue, 17 Mar 2026 10:06:43 GMT, Paul Hübner <[email protected]> wrote:
> Hi, > > SA does not support value objects. The tests should be disabled when running > with `--enable-preview`. Currently, all SA tests use `@requires vm.hasSA`. > > Extending `vm.hasSA` to require non-preview automagically skips all of the > relevant tests. > > Testing on Linux (x64, AArch64), macOS (x64, AArch64), Windows x64: > * tier 1 sanity test > * `:hotspot_serviceability` (most of the SA tests), with and without preview > * `:hotspot_resourcehogs` (some SA tests), with and without preview > * `:svc_tools` (some `jhsdb` tests), with and without preview I agree with Chris. Although currently SA does not support value objects, the support have to be implemented before value classes out of preview (I believe it happen earlier than we deprecate SA). As most of the SA test pass, it would be better to keep them running to catch new issues. To me ProblemList-enable-preview is a good place to see what needs to be done. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2236#issuecomment-4085195022
