On Tue, 17 Mar 2026 10:06:43 GMT, Paul Hübner <[email protected]> wrote:
> Hi,
>
> SA does not support value objects. The tests should be disabled when running
> with `--enable-preview`. Currently, all SA tests use `@requires vm.hasSA`.
>
> Extending `vm.hasSA` to require non-preview automagically skips all of the
> relevant tests.
>
> Testing on Linux (x64, AArch64), macOS (x64, AArch64), Windows x64:
> * tier 1 sanity test
> * `:hotspot_serviceability` (most of the SA tests), with and without preview
> * `:hotspot_resourcehogs` (some SA tests), with and without preview
> * `:svc_tools` (some `jhsdb` tests), with and without preview
I would 100% much rather we programmatically disable them than problem list a
list of tests. The ProblemList list is noise that I thought I cleaned out once
but it keeps changing. This is a lot better. Also if this fixes this test to
not run, it should be removed from the problem list.
ProblemList-enable-preview.txt:serviceability/sa/TestHeapDumpForInvokeDynamic.java
8377387 generic-all
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/2236#issuecomment-4082385572
