On Thu, 12 Mar 2026 16:01:39 GMT, Chen Liang <[email protected]> wrote:
>> David Beaumont has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - Merge branch 'lworld' into jdk_8377101_gensrc/squashed >> - Finally working >> - Latest changes (inc. feecback). >> >> * feedback updates and tidying >> * better compile macro call - still not working >> - [[UNDO FORMATTING IN SQUASH BRANCH]] >> - [[AUTOMATIC FORMATTING]] >> - better but still not working >> - Simpler temp directory >> - better error handling >> - better error handling >> - remove old version >> - ... and 6 more: >> https://git.openjdk.org/valhalla/compare/d91e357a...800d6ff3 > > make/CompileJavaModules.gmk line 76: > >> 74: # The output directory must be present in GENERATED_PREVIEW_SUBDIRS in >> Modules.gmk. >> 75: # Temporarily restrict this to java.base, but it can be expanded later. >> 76: # TODO: Remove Xlint directives below once the fix in JDK-8378740 is >> merged into lworld. > > Let's integrate this after you remove the directives and this comment. I can remove the "removal" directive, but not the "processor" one, since that's "correctly" reporting unused annotations. I'm in discussion with Jan to see if we can do better. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2925831591
