On Mon, 9 Mar 2026 13:16:06 GMT, Erik Joelsson <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Latest changes (inc. feecback). >> >> * feedback updates and tidying >> * better compile macro call - still not working >> - [[UNDO FORMATTING IN SQUASH BRANCH]] >> - [[AUTOMATIC FORMATTING]] > > make/CompileJavaModules.gmk line 85: > >> 83: >> 84: PROCESSOR_PATH += $(VALUETYPE_GENSRC_PROCESSOR_PATH) >> 85: DEPENDS += $(VALUETYPE_GENSRC_PROCESSOR_PATH) > > The DEPENDS argument to SetupJavaCompilation is unfortunately not smart > enough to take a directory, it needs the actual output file (touch file) from > the other SetupJavaCompilation call. See ToolsJdk:37-38 for an example of how > to generate that. I was using the batch file of the compilation, but that didn't work either. Can you maybe suggest an exact change here, since it's my big unsolved issue with this PR and when it doesn't work, I get no feedback as to whether I was miles off or a couple of letters out. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2911933534
