On Thu, 12 Mar 2026 15:37:45 GMT, David Beaumont <[email protected]> wrote:
>> Adds a new AnnotationProcessor to read the @MigratedValueClass on >> prospective value classes and generate the equivalent source file with the >> 'value' keyword at each annotated class declaration. >> >> This adds new PROCESSOR_PATH variable to the compilation macro and use it >> for annotation processing. >> This also requires moving the plugin discovery path to the new variable (was >> in classpath before) because the addition of a '--processor-path' flag >> disables using the classpath for plugin discovery. >> >> For now this is all limited to `java.base` but that's expandable later >> easily. There was an issue just enabling it for all modules however (esp. >> `jdk.incubator` which might be special). >> >> While there is currently no specific unit test for this code, if it were to >> fail to generate the correct value classes, a lot of other downstream tests >> would fail. > > David Beaumont has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 16 additional > commits since the last revision: > > - Merge branch 'lworld' into jdk_8377101_gensrc/squashed > - Finally working > - Latest changes (inc. feecback). > > * feedback updates and tidying > * better compile macro call - still not working > - [[UNDO FORMATTING IN SQUASH BRANCH]] > - [[AUTOMATIC FORMATTING]] > - better but still not working > - Simpler temp directory > - better error handling > - better error handling > - remove old version > - ... and 6 more: > https://git.openjdk.org/valhalla/compare/a4656375...800d6ff3 make/CompileJavaModules.gmk line 76: > 74: # The output directory must be present in GENERATED_PREVIEW_SUBDIRS in > Modules.gmk. > 75: # Temporarily restrict this to java.base, but it can be expanded later. > 76: # TODO: Remove Xlint directives below once the fix in JDK-8378740 is > merged into lworld. Let's integrate this after you remove the directives and this comment. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2925707703
