On Thursday 03 June 2010 05:54:13 Andre Moreira Magalhaes wrote: > I just did a quick look here and found one thing that should be changed. > Please remove the __k__ or similars to method names. Please use the > tp-qt4 convention which just uses onFoo, gotFoo, ...
Ok, will do after Olli has finished with this round of reviews > > Also please file a bug in fd.o (Product Telepathy, Component tp-qt4) if > not already there and add a patch keyword to Keywords when ready to > review and the link to your branch in URL. This is how we are doing code > review. So there is no need to send mails to the ml when ready to > review, just re-add the patch keyword and I or someone else will review > it. Ah - sorry for that. Will do for future branches. > > When approved I will add a r+ to the Whiteboard, meaning it is ready to > merge. > > Please don't merge this before I am able to fully review it, which is on > my priority list. Yep, that's for sure :) > > BR -- ------------------- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
