I just did a quick look here and found one thing that should be changed. Please remove the __k__ or similars to method names. Please use the tp-qt4 convention which just uses onFoo, gotFoo, ...
Also please file a bug in fd.o (Product Telepathy, Component tp-qt4) if not already there and add a patch keyword to Keywords when ready to review and the link to your branch in URL. This is how we are doing code review. So there is no need to send mails to the ml when ready to review, just re-add the patch keyword and I or someone else will review it. When approved I will add a r+ to the Whiteboard, meaning it is ready to merge. Please don't merge this before I am able to fully review it, which is on my priority list. BR -- Andre Moreira Magalhaes (andrunko) -------------------------------------------------------- Jabber: [email protected] MSN: [email protected] Skype: andrunko IRC: andrunko Blog: http://andrunko.blogspot.com _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
