On 2016/04/19 18:57, Christian Weisgerber wrote: > Stuart Henderson: > > > Looking at unique "RTL8168E/8111E (0x2c00)" entries from dmesglog > > back to Feb 2013, there are 7 APUs (=21 NICs), and 20 non-APUs. > > Do we care if we change led state for those others too? We could > > check the MAC vendor for 00:0d:b9, but I think this is unnecessary > > complexity (and who knows, maybe it's an improvement for some of > > those too). > > Checking the MAC address is brittle since it can be changed (ifconfig > lladdr). Instead, I suggest checking hw_vendor and hw_prod; see > for instance what skgpio(4) does. I don't think blindly reprogramming > the LED state for all chips of this type is acceptable.
Ah that's not a bad idea, I'll take a look. I'll need a tester for that as the board I was using is in production now. > Ideally, Pascal should fix this in the BIOS. :-( Ideally it would have been found/fixed during beta - I'm not sure if I'd be massively happy about the BIOS reprogramming the eeprom (which the user might have already modified). If I were him I wouldn't want to do more than providing a bootable OS image that people can run to do it..
