Did you bring this up to Pascal Dornier ? I think he would rather fix the eeprom...
This is specific to the hardware layout, the eeprom is the right place, not the driver! On the other hand, I think the CSR_WRITE_1 is perfectly clear.... Stuart Henderson [s...@spacehopper.org] wrote: > The re(4) variant on the PC Engines APU1, RTL8111E, has a flexible LED > configuration. The nic's default config seems to be intended for > controlling 3 LEDs (or one single-colour and a bi-colour LED with > different colours to indicate link speed) however the ethernet ports > on the APU1 only have two LEDs (one green one amber). > > Defaults can be changed in eeprom but (intentionally or not) this > hasn't been done on the APU1 so in normal situations with a 1GB link, > you only ever see one lit LED, and even that is normally off, only > blinking for activity. I don't know of any APU users who like > the default setup. > > Section 6.2.6 of the RTL8111E-VB-GR / -VB-CG / -VC-CG datasheet > tells us how to reprogramme it. Do we want to change it? > > Without diff: > > green: normally off, blink on for activity. > amber: on solid for 100MB link, off for 1GB link. > > With diff: > > green: normally on if link at any speed. blink off for activity. > amber: on solid for 1GB link, otherwise off. > > Some other settings are possible but I think this gives the best > combination of information under "normal" conditions given only > 2 LEDs. > > Looking at unique "RTL8168E/8111E (0x2c00)" entries from dmesglog > back to Feb 2013, there are 7 APUs (=21 NICs), and 20 non-APUs. > Do we care if we change led state for those others too? We could > check the MAC vendor for 00:0d:b9, but I think this is unnecessary > complexity (and who knows, maybe it's an improvement for some of > those too). > > Any comments/OKs? (I am not 100% happy with the clarity of the new > CSR_WRITE_1 line, but my earlier iterations were worse ;) >
