Stuart Henderson: > Looking at unique "RTL8168E/8111E (0x2c00)" entries from dmesglog > back to Feb 2013, there are 7 APUs (=21 NICs), and 20 non-APUs. > Do we care if we change led state for those others too? We could > check the MAC vendor for 00:0d:b9, but I think this is unnecessary > complexity (and who knows, maybe it's an improvement for some of > those too).
Checking the MAC address is brittle since it can be changed (ifconfig lladdr). Instead, I suggest checking hw_vendor and hw_prod; see for instance what skgpio(4) does. I don't think blindly reprogramming the LED state for all chips of this type is acceptable. Ideally, Pascal should fix this in the BIOS. :-( -- Christian "naddy" Weisgerber na...@mips.inka.de
