On 9 February 2013 16:27, Stuart Henderson <s...@spacehopper.org> wrote: > So I think the vr(4) diff has had a reasonable amount of testing; > any objections or ideally OKs to commit it? >
OK > I have also tested sis(4) on a PC Engines WRAP now; despite the > DP83815 datasheet indicating that "Accept Long Packets" > (SIS_RXCFG_RX_JABBER) should permit frames up to 2046 it seems > something more is required for that; however setting mtu to 1518 > does work. In the case of sis(4) there is no change to how the chip > is programmed at all, so this is a NOOP unless somebody deliberately > configures a larger MTU on the device. Therefore I believe that > this would be safe to allow without a big round of testing. OK? > Sounds good to me. OK mikeb