On Thu, Feb 07, 2013 at 05:02:10PM -0500, Vladimir Támara Patiño wrote: > Attached is a .tar.gz with 49 news files to place in /usr/src and > below there is a patch for /usr/src of OpenBSD 5.2 that modifies > 53 files to integrate the collation support of the xlocale implementation of > FreeBSD (POSIX 2008). If there is interest I can try to update it > to current in next days.
This is interesting, but I'm afraid your approach is adding and changing way too much all at once. I doubt you'll get anyone convinced to commit a giant patch like this. You're addressing two distinct and large problems in a single patch. Adding collation support and adding xlocale support are two different beasts. I would suggest to try improving the existing locale implementation first, without also adding xlocale. Can you produce a diff that contains the minimum amount of changes required to make strcoll() and strxfrm() do the right thing in e.g. the latin1 and/or UTF-8 locales? Perhaps for Spanish first, since you're familiar with that language. And once that works can you also add support for some other character sets (e.g. latin2, KOI8) and languages to make this enhancement more generally useful? You need to consider how your changes affect other parts of the overall system. For example, your change in distrib/special will break the install media. That is not acceptable. The libstub for setlocale() exists to prevent code in libc/citrus/ and libc/locale/ from being pulled onto the install media and waste precious space. Generally, changes to the locale code should be tested with 'make release' and an install or upgrade from the resulting media (see the release(8) man page). BTW, you can use cvsdo (from the cvutils package) to "add" new files to a local CVS checkout so that they show up in the output of 'cvs diff', rather than attaching new files in a tarball. I hope you're not discouraged by my comments. I'm very glad to see someone motivated to improve locale support. But it has to be done in smaller steps than you're proposing.
