Re: [RFC] Pager: why do we implement WM_NCPAINT instead of WM_PAINT?

2005-03-23 Thread Robert Shearman
Dimitrie O. Paun wrote: Hi folks, Does anyone know why the Pager common control (dlls/comctl32/pager.c) implements WM_NCPAINT instead of WM_PAINT? It is the only exception to the rule, all other controls implement WM_PAINT. We need to scroll a child window. In order to do this we move the child

[RFC] Pager: why do we implement WM_NCPAINT instead of WM_PAINT?

2005-03-23 Thread Dimitrie O. Paun
Hi folks, Does anyone know why the Pager common control (dlls/comctl32/pager.c) implements WM_NCPAINT instead of WM_PAINT? It is the only exception to the rule, all other controls implement WM_PAINT. -- Dimi.

Re: I think I know how uxtheme works...

2005-03-23 Thread Mike McCormack
Jonathan Wilson wrote: Exactly how the theme service and theme engine works "under the hood" doesnt matter. But for ReactOS and WINE purposes, I suggest we implement the following: 1.A function similar to RegisterUserApiHooks/UnregisterUserApiHooks (either reverse engineer the MS function or writ

Re: [ros-dev] I think I know how uxtheme works...

2005-03-23 Thread Jonathan Wilson
Also related to this (as pointed out in IRC) is Activation Contexts/SxS stuff), we need this to make sure the correct window classes are used at the correct time.

I think I know how uxtheme works...

2005-03-23 Thread Jonathan Wilson
What I strongly suspect happens is this: 1.The themes service is always loaded and running and holds the theme data (and it contains details of which .msstyles file to use) 2.At some point (either at startup if the changes are global or when an app loads if the changes are app specific, I cant fi

Re: World of Warcraft

2005-03-23 Thread cyrix12
On Thu, 24 Mar 2005 00:52:24 +0100 Raphael <[EMAIL PROTECTED]> wrote: > Hi again, > > > > Hi, > > > > > > can you try with this patch ? > > > > > > Regards, > > > Raphael > > > > Still doesn't work. I attached another opengl trace in case you can pick > > out something that's changed though. > >

Re: World of Warcraft

2005-03-23 Thread Raphael
Hi again, > > Hi, > > > > can you try with this patch ? > > > > Regards, > > Raphael > > Still doesn't work. I attached another opengl trace in case you can pick > out something that's changed though. > > Darckness Thx, intersesting :) And this one ? Regards, Raphael Index: wgl_ext.c =

Re: Attempt to make buttons themed

2005-03-23 Thread Kevin Koltzau
On Wednesday 23 March 2005 07:04 am, Boaz Harrosh wrote: > Maybe it only register as per Process, which makes sense. And it does > that before any window is displayed. Actually I know when. (A bug I had) > it does it in the InitCommonControlsEx call. Not even in the DLLMain. An > app that needs

Re: World of Warcraft

2005-03-23 Thread cyrix12
On Wed, 23 Mar 2005 23:37:49 +0100 Raphael <[EMAIL PROTECTED]> wrote: > On Wednesday 23 March 2005 22:15, [EMAIL PROTECTED] wrote: > > Sorry to keep bugging you guys about this, but a recent patch broke the > > opengl mode of World of Warcraft again. It simply fails to start, similar > > to the d

Re: World of Warcraft

2005-03-23 Thread Raphael
On Wednesday 23 March 2005 22:15, [EMAIL PROTECTED] wrote: > Sorry to keep bugging you guys about this, but a recent patch broke the > opengl mode of World of Warcraft again. It simply fails to start, similar > to the d3d mode (except for the fact that I know why d3d mode doesn't work > as of now)

Re: Segfault in X11DRV_DIB_BuildColorTable (DIB_PAL_COLORS)

2005-03-23 Thread Jesse D Zbikowski
The patch worked like a charm. I guess it's true about arrays being evil :) Thanks, Jesse Z. > I have attached a patch below which may fix the problem. Index is a > WORD but yet we only have 256 entries in the palette that we get from > GetPaletteEntries - if any of the values is more, we jump

Re: World of Warcraft

2005-03-23 Thread cyrix12
On Wed, 23 Mar 2005 15:22:46 -0600 James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, 23 Mar 2005 16:15:18 -0500, [EMAIL PROTECTED] <[EMAIL PROTECTED]> > wrote: > > Sorry to keep bugging you guys about this, but a recent patch broke the > > opengl mode of World of Warcraft again. It simply fail

[AppDB] Application queue: Getting ahead of me.

2005-03-23 Thread Tony Lambregts
I will be unable to tend to the application queue for the next week and as a matter of fact I am already behind maintaining it. (sorry). If one of you good souls (with administrative rights) could take could take care of it for the next week I would really appreciate it. Thanks. -- Tony Lambreg

Re: Segfault in X11DRV_DIB_BuildColorTable (DIB_PAL_COLORS)

2005-03-23 Thread Glenn Wurster
> I am experiencing a crash during startup of an application (The > Rosetta Stone 2.0.7a) under Wine. I reported this earlier on > wine-users and after some debugging was advised to move to this list. > I am using the latest Wine I built from CVS, after first encountering > this problem in the

World of Warcraft

2005-03-23 Thread cyrix12
What I meant to say in the previous message was something along the lines of "Here's an opengl trace; let me know if you need any others." Unfortunately, it seemed to come out in some other language which I am not familiar in. So here's the opengl trace. Darcknesstrace:opengl:X11DRV_OpenGL_In

Re: World of Warcraft

2005-03-23 Thread James Hawkins
On Wed, 23 Mar 2005 16:15:18 -0500, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Sorry to keep bugging you guys about this, but a recent patch broke the > opengl mode of World of Warcraft again. It simply fails to start, similar to > the d3d mode (except for the fact that I know why d3d mode d

Re: DDRAW: Surface locking patch, take 2

2005-03-23 Thread Tony Lambregts
Matthew Mastracci wrote: This patch (correctly) fixes the locking problems in SimCity 3000. We now check to see if the blit src and dest are the same surface and, if so, we make sure to lock the surface only once and, in the case of BltFast, re-adjust the surface pointers. This patch also make

World of Warcraft

2005-03-23 Thread cyrix12
Sorry to keep bugging you guys about this, but a recent patch broke the opengl mode of World of Warcraft again. It simply fails to start, similar to the d3d mode (except for the fact that I know why d3d mode doesn't work as of now). I was scanning through the traces and saw no errors though.

Re: Attempt to make buttons themed

2005-03-23 Thread Jonathan Wilson
ok, further to what I mentioned before about RegisterUserApiHooks (and poking around in uxtheme.dll), I see the following things being hooked by uxtheme (at least it seems to be the complete list) GetScrollInfo SetScrollInfo EnableScrollBar SetWindowRgn DefWindowProcW DefWindowProcA PreWndProc (p

Re: Native stack overlapping system heap base address on some systems

2005-03-23 Thread Steven Edwards
Hi, --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > Surprise surprise, 0x7fffb000 + (1024 * 20) == 0x8000 This looks like what I have seen on some users systems running Suse 9.2. Some users see errors like this err:virtual:NtMapViewOfSection map_file_into_view 0x8000 100 0

Re: Attempt to make buttons themed

2005-03-23 Thread Rob Shearman
Boaz Harrosh wrote: I'm not 100% but I think there is no need for duplicate code. All comctl32 needs to do is chain to the user32 classes, only overriding PAINT messages and some mouse events. So you don't have to reinvent the wheel. Erm, it's not just the painting that needs to be overridden.

Re: lostwages/templates/en contributing.template j ...

2005-03-23 Thread Jakob Eriksson
I submitted a patch for all casts I could find with that little grep: find . -name "*.[ch]" | xargs egrep "\) *Heap(Re)?Alloc" Jeremy Newman wrote: ChangeSet ID: 16817 CVSROOT:/opt/cvs-commit Module name:lostwages Changes by: [EMAIL PROTECTED] 2005/03/23 08:56:08 Modified

Re: Attempt to make buttons themed

2005-03-23 Thread Frank Richter
On 23.03.2005 13:04, Boaz Harrosh wrote: Maybe it only register as per Process, which makes sense. And it does that before any window is displayed. Actually I know when. (A bug I had) it does it in the InitCommonControlsEx call. Not even in the DLLMain. An app that needs theming needs 3 things.

Re: Attempt to make buttons themed

2005-03-23 Thread Boaz Harrosh
Frank Richter wrote: Most interesting is probably to find out how the standard controls from user32 are themed. Poking a bit around in comctl32 6.0, it seems that it actually just registers the standard classes with RegisterClassW, nothing more. AFAIK you can't register a class when the class n

Re: Native stack overlapping system heap base address on some systems

2005-03-23 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > I know people have been seeing this intermittently for a while now, we > have a few CodeWeavers support tickets with this problem too. The issue > seems to be that the Linux native (main thread) stack was allocated here: > >7fffb000 20K rwx--[

Re: Warn users who attempt to use native DirectDraw

2005-03-23 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > Maybe we should just extend the blacklist in the code, some DLLs will > never work as native like ntdll so we just never try and load them. > Probably that'd be better from a usability POV than any warning. That's not what the blacklist does, it just provi

Re: registry TODO

2005-03-23 Thread Jelmer Vernooij
Hi, On Tue, Mar 22, 2005 at 03:43:40PM -0800, Steven Edwards wrote about 'Re: registry TODO': > --- Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > How is ReactOS's current (future) system? > I think ReactOS's registry is binary compatible with NT4. It and the windows > 2000 format was > documented

Re: Attempt to make buttons themed

2005-03-23 Thread Frank Richter
On 22.03.2005 17:00, Alexandre Julliard wrote: Then the first thing to do is to figure out exactly how Windows does it, and do it the same way. Most interesting is probably to find out how the standard controls from user32 are themed. Poking a bit around in comctl32 6.0, it seems that it actually

Native stack overlapping system heap base address on some systems

2005-03-23 Thread Mike Hearn
Hi, Bug #2741 comes from a user who was able to grab a dump of the VM mappings when the following error occurred: HEAP_CreateSystemHeap system heap base address 0x8000 not available I know people have been seeing this intermittently for a while now, we have a few CodeWeavers support ticket

Re: Warn users who attempt to use native DirectDraw

2005-03-23 Thread Mike Hearn
On Wed, 23 Mar 2005 11:15:04 +0100, Alexandre Julliard wrote: > Messages that the user needs to see have to be a message box, yes. But > really if we are doing things right there shouldn't be any need for > such messages. In this specific case I'd suggest letting winecfg take > care of it, by not o

Re: Warn users who attempt to use native DirectDraw

2005-03-23 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > There are a whole class of messages like that which *should* be message > boxes but aren't for whatever reason. In this case we'd have to > LoadLibrary/GetProcAddress user32. We can do this, if Alexandre thinks > it'd be preferable - AJ? Messages that the

Re: Warn users who attempt to use native DirectDraw

2005-03-23 Thread Lars Segerlund
There is another category of users who doesn't like message boxes, perhaps an option between them which defaults to message boxes ? / Lars Segerlund. On Tue, 22 Mar 2005 23:58:15 + Mike Hearn <[EMAIL PROTECTED]> wrote: > On Tue, 22 Mar 2005 12:54:15 -0600, Robert Shearman wrote: > > I