[PATCH weston] weston-info: display output scale

2015-12-17 Thread Jonny Lamb
Fall back to not showing anything as before if we don't have a compositor with wl_output new enough (version 2 or newer). Signed-off-by: Jonny Lamb Reviewed-by: Daniel Stone --- clients/weston-info.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-)

[PATCH weston] weston-info: display output scale

2015-12-16 Thread Jonny Lamb
Fall back to not showing anything as before if we don't have a compositor with wl_output new enough (version 2 or newer). Signed-off-by: Jonny Lamb --- clients/weston-info.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/clients/weston-inf

Re: [PATCH weston 0/6] Configuration file control

2015-03-25 Thread Jonny Lamb
(-) Reviewed-by: Jonny Lamb -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston 09/10] platform: remove global variables

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- shared/platform.h | 55 +-- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/shared/platform.h b/shared/platform.h index ea5980e..be6d8e6 100644 --- a/shared/platform.h +++ b/shared/platform.h @@ -4

[PATCH weston 05/10] gl-renderer: call supports() automatically in create()

2015-03-24 Thread Jonny Lamb
This means compositors don't need to call supports() manually and create() will just return -1 in the failure case as before. This also means we can deal with the case of eglGetProcAddress returning non-NULL but not actually being available at runtime. Reviewed-by: Pekka Paalanen --- src/composi

[PATCH weston 07/10] nested-client: include platform.h

2015-03-24 Thread Jonny Lamb
Missed because buliding nested clients requires cairo-glesv2. Reviewed-by: Pekka Paalanen --- clients/nested-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/nested-client.c b/clients/nested-client.c index 5195831..200543c 100644 --- a/clients/nested-client.c +++ b/clients/

[PATCH weston 08/10] platform: provide platform_base fallbacks and remove ifdefs

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- shared/platform.h | 47 +-- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/shared/platform.h b/shared/platform.h index fd06046..ea5980e 100644 --- a/shared/platform.h +++ b/shared/platform.h @@ -25,26 +25

[PATCH weston 10/10] platform: rename create_egl_window to create_egl_surface

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- clients/nested-client.c | 4 ++-- clients/simple-egl.c | 6 +++--- clients/subsurfaces.c | 6 +++--- clients/window.c | 6 +++--- shared/platform.h | 12 ++-- tests/buffer-count-test.c | 6 +++--- 6 files changed, 20 inserti

[PATCH weston 03/10] gl-renderer: move all EGL_PLATFORM_* defines here

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 4 src/compositor-wayland.c | 4 src/compositor-x11.c | 4 src/gl-renderer.h| 12 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c inde

[PATCH weston 02/10] gl-renderer: fix build with --disable-egl

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 3 ++- src/gl-renderer.h| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index c0d0c84..8471a35 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1626,7 +1626,

[PATCH weston 04/10] compositor-{drm, wayland, x11}: remove useless tests for ->supports

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 3 +-- src/compositor-wayland.c | 3 +-- src/compositor-x11.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 158929f..9e42a8b 100644 --- a/src/compositor-drm.c

[PATCH weston 00/10] platform_base cleanups and review reply

2015-03-24 Thread Jonny Lamb
In reply to Pekka's late review, I've written some more patches to address his comments: Jonny Lamb (10): compositor-{drm,x11,wayland}: stop including EGL headers here gl-renderer: fix build with --disable-egl gl-renderer: move all EGL_PLATFORM_* defines here compositor-{drm,w

[PATCH weston 06/10] gl-renderer: provide platform_base fallbacks and remove ifdefs

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- src/gl-renderer.c | 16 +++- src/gl-renderer.h | 6 ++ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 2c36a8d..b3b2364 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -37,7 +37,

[PATCH weston 01/10] compositor-{drm, x11, wayland}: stop including EGL headers here

2015-03-24 Thread Jonny Lamb
Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 2 -- src/compositor-wayland.c | 2 -- src/compositor-x11.c | 2 -- src/gl-renderer.h| 1 + 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 450920e..c0d0c84 10064

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-23 Thread Jonny Lamb
t but nonetheless: % git grep "\*)[a-z]" | wc -l 89 % git grep "\*) [a-z]" | wc -l 187 Wayland also uses the space even more. -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://list

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- clients/nested-client.c | 7 +++ clients/simple-egl.c | 7 --- clients/subsurfaces.c | 6 +++--- clients/window.c | 8 shared/platform.h | 23 +++ tests/buffer-count-

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- src/compositor-drm.c | 13 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 20 +-- src/compositor-x11.c | 11 +- src/gl-renderer.c| 90 ++-- s

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 39 ++- src/gl-renderer.h

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- Makefile.am | 4 ++- clients/nested-client.c | 4 ++- clients/simple-egl.c | 6 +++- clients/subsurfaces.c | 5 ++- clients/window.c | 5 ++- clients/window.h | 1 + shared/platform.h

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- src/compositor-drm.c | 13 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 20 +-- src/compositor-x11.c | 11 +- src/gl-renderer.c| 90 ++-- src/gl-renderer.h| 6 ++

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- clients/nested-client.c | 7 +++ clients/simple-egl.c | 7 --- clients/subsurfaces.c | 6 +++--- clients/window.c | 8 shared/platform.h | 23 +++ tests/buffer-count-test.c | 7 +++ 6 files ch

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 39 ++- src/gl-renderer.h| 3 ++- 6 files changed, 45 i

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- Makefile.am | 4 ++- clients/nested-client.c | 4 ++- clients/simple-egl.c | 6 +++- clients/subsurfaces.c | 5 ++- clients/window.c | 5 ++- clients/window.h | 1 + shared/platform.h | 79

Re: [PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Jonny Lamb
yingly take slightly different arguments in the X11 case (see compositor-x11.c) so another argument was added to gl_renderer_interface.output_create which we'd lose the ability to use by using the new functions. Updated patch set incom

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-02-25 Thread Jonny Lamb
--- clients/nested-client.c | 36 +++- clients/simple-egl.c | 30 +- clients/subsurfaces.c | 35 ++- clients/window.c | 34 +- tests/buffer-count-test.c |

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-02-25 Thread Jonny Lamb
--- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 42 +- src/gl-renderer.h| 3 ++- 6 files changed, 48 insertions(+), 8 deletions

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-02-25 Thread Jonny Lamb
--- src/compositor-drm.c | 13 +- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 20 +++-- src/compositor-x11.c | 11 - src/gl-renderer.c| 109 +-- src/gl-renderer.h| 6 ++- 6 files changed, 151 ins

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-02-25 Thread Jonny Lamb
--- clients/nested-client.c | 22 ++ clients/simple-egl.c | 22 ++ clients/subsurfaces.c | 22 +++--- clients/window.c | 22 ++ tests/buffer-count-test.c | 25 - 5 files changed,

Re: [PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-02-25 Thread Jonny Lamb
the tail of the string (x11, gbm, wayland) and concatenate it (with EXT, MESA, KHR expecting some not to exist...) in this function and do all testing here without the compositor making potentially multiple calls. Whether that's a reasonable idea or not is up to you. :) OK yeah

Re: [PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Jonny Lamb
Il 23/02/2015 17:28, Derek Foreman ha scritto: On 23/02/15 10:02 AM, Jonny Lamb wrote: The intention here is to be able to find an existing wl_global using some search parameters and then get some information about it. I'm not sure I see a need for this, but if there is need there should

[PATCH wayland] server: add helper functions for wl_global

2015-02-23 Thread Jonny Lamb
The intention here is to be able to find an existing wl_global using some search parameters and then get some information about it. --- src/wayland-server.c | 33 + src/wayland-server.h | 4 2 files changed, 37 insertions(+) diff --git a/src/wayland-server.c

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-02-17 Thread Jonny Lamb
--- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 38 +- src/gl-renderer.h| 3 ++- 6 files changed, 44 insertions(+), 8 deletions(-)

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-02-17 Thread Jonny Lamb
--- clients/nested-client.c | 29 - clients/simple-egl.c | 23 ++- clients/subsurfaces.c | 26 +- clients/window.c | 27 ++- tests/buffer-count-test.c | 30 ++

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-02-17 Thread Jonny Lamb
--- src/compositor-drm.c | 14 - src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 21 +++-- src/compositor-x11.c | 14 - src/gl-renderer.c| 79 ++-- src/gl-renderer.h| 6 +++- 6 files changed,

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-02-17 Thread Jonny Lamb
--- clients/nested-client.c | 18 ++ clients/simple-egl.c | 18 ++ clients/subsurfaces.c | 18 +++--- clients/window.c | 17 + tests/buffer-count-test.c | 21 - 5 files changed, 72 insertions(+), 20

Re: [PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
gt; with just one generic error code, since this is a private protocol. OK, done. > Could this be 'enum desktop_shell_panel_position' instead of uint32_t? It certainly could. Done! -- Jonny Lamb ___ wayland-devel mailing list wa

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index e3abaad..e3241fd 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1758,

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-08-20 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 173 ++ 1 file changed, 120 insertions(+),

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
you constrain pointer position but resizing it easily under the > panel is really annoying. Ah, my fault, I didn't notice the other two. Feel free to ignore this patch in my group of three then. -- Jonny Lamb ___ wayland-de

[PATCH weston] desktop-shell: implement touch popup grabs

2014-08-20 Thread Jonny Lamb
--- desktop-shell/shell.c | 155 ++ 1 file changed, 143 insertions(+), 12 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index ec72287..db7841a 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -223,9 +223,11

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-08-20 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 173 ++ 1 file changed, 120 insertions(+),

[PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 9cb81d5..b9d5f39 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1758,

Re: [PATCH weston] desktop-shell: add option to avoid creating the panel

2014-08-12 Thread Jonny Lamb
On mar, 2014-08-12 at 15:09 +0200, Jonny Lamb wrote: > This option is so we can disable showing any panel at all. The default > is to continue showing the panel and no example is added to weston.ini > because it's an uncommon request. Apologies, please ignore this duplicate patch.

[PATCH weston] desktop-shell: add close-animation config option for destroying surfaces

2014-08-12 Thread Jonny Lamb
At the moment when surfaces are destroyed they are faded out but let's make it configurable! --- desktop-shell/shell.c | 11 +-- desktop-shell/shell.h | 1 + man/weston.ini.man| 6 ++ 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-

[PATCH weston] desktop-shell: add option to avoid creating the panel

2014-08-12 Thread Jonny Lamb
This option is so we can disable showing any panel at all. The default is to continue showing the panel and no example is added to weston.ini because it's an uncommon request. --- clients/desktop-shell.c | 38 +++--- man/weston.ini.man | 5 + 2 files chang

[PATCH weston] desktop-shell: add option to avoid creating the panel

2014-08-12 Thread Jonny Lamb
This option is so we can disable showing any panel at all. The default is to continue showing the panel and no example is added to weston.ini because it's an uncommon request. --- clients/desktop-shell.c | 38 +++--- man/weston.ini.man | 5 + 2 files chang

Re: [PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-08-12 Thread Jonny Lamb
patches. Even though they should be ok as one patch now I have split them. > Also, could you add updates to the weston.ini man page, please? Done. -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston 2/3] compositor-wayland: listen to repeat_info and save values to pass on

2014-08-12 Thread Jonny Lamb
--- src/compositor-wayland.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index a4dcec2..d5ea925 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -1573,12 +1573,24 @@ input_

[PATCH weston 3/3] clients: use repeat_info event details

2014-08-12 Thread Jonny Lamb
The weston-info client prints out the values, and the values are respected in toytoolkit when actually repeating keys.. --- clients/weston-info.c | 89 ++- clients/window.c | 49 +--- 2 files changed, 132 insertions(+), 6

[PATCH weston 1/3] compositor: fetch repeat info from weston.ini

2014-08-12 Thread Jonny Lamb
--- man/weston.ini.man | 11 +++ src/compositor.c | 5 + src/compositor.h | 3 +++ src/input.c| 9 ++--- 4 files changed, 25 insertions(+), 3 deletions(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index 667f70a..3d8eef9 100644 --- a/man/weston.ini.man +++

Re: [PATCH weston] desktop-shell: don't assume there's a pointer when mapping a popup

2014-08-06 Thread Jonny Lamb
On mer, 2014-08-06 at 11:50 +0200, Jonny Lamb wrote: > - if (shseat->seat->pointer->grab_serial == shsurf->popup.serial) { > + if (shseat->seat->pointer && > + shseat->seat->pointer->grab_serial == shsurf->popup.serial) { This shoul

[PATCH weston] desktop-shell: don't assume there's a pointer when mapping a popup

2014-08-06 Thread Jonny Lamb
--- desktop-shell/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 3c3649c..5a613f1 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -3116,7 +3116,8 @@ shell_map_popup(struct shell_surface *shsurf)

[PATCH weston] animation: also change stop value when updating a fade target

2014-07-29 Thread Jonny Lamb
If we're fading a view with weston_fade_run() and half way through we want to unfade it we can use weston_fade_update() to set a new alpha target. When the animation finishes, reset_alpha() is called which ensures the alpha value of the view is exactly as requested. Although weston_fade_update() w

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-07-22 Thread Jonny Lamb
In the process wl_keyboard's version has been incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 4 implies wl_keyboard version 4). --- protocol/wayland.xml | 28 ++-- 1 file changed, 26

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-07-16 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 175 ++ 1 file changed, 120 insertions(+),

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-07-16 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 3/3] shell: constrain resize grabs so windows don't go under the panel

2014-07-16 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 28 1 file changed, 28 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index e51c299..e0f001d 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -175

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-07-16 Thread Jonny Lamb
In the process wl_keyboard's version has been incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 4 implies wl_keyboard version 4). --- protocol/wayland.xml | 28 ++-- 1 file changed, 26

Re: [PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-07-16 Thread Jonny Lamb
On lun, 2014-06-02 at 10:43 +0300, Pekka Paalanen wrote: > Looks good, only few comments there. They should all be fixed now. -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mail

[PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-07-16 Thread Jonny Lamb
The compositor reads the values out from weston.ini, the weston compositor passes on the values, the weston-info client prints out the values, and the values are respected in toytoolkit. --- clients/weston-info.c| 89 +++- clients/window.c |

Re: [PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-07-16 Thread Jonny Lamb
at to do with zero? I added a note about negative values. > Re-reading it, this seems funnily said: > > > + summary="time in milliseconds between keys repeating"/> > I think it wants to say: "delay in milliseconds since key-down until &g

[PATCH wayland 1/2] protocol: document error cases with wl_shm_pool.create_buffer

2014-05-30 Thread Jonny Lamb
This already happens in weston. --- protocol/wayland.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 22eb6e7..3091d83 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -222,6 +222,11 @@ A buffer will keep a refere

[PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

2014-05-30 Thread Jonny Lamb
--- protocol/wayland.xml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 3091d83..951aafc 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -982,6 +982,14 @@ cursor images for pointers, drag icons, etc.

[PATCH weston] compositor: raise errors when bad scale or transform values are used

2014-05-30 Thread Jonny Lamb
--- src/compositor.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 574db2d..3c5c8e3 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -2138,6 +2138,16 @@ surface_set_buffer_transform(struct wl_client *client, { stru

[PATCH weston] xdg-shell: add description tags where missing

2014-05-30 Thread Jonny Lamb
wayland.dtd specifies the use of the description tags inside entry so let's use them. --- protocol/xdg-shell.xml | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index 28add40..00ff39f 100644 --- a/

Re: [PATCH weston] input: implement repeat_info event on wl_keyboard

2014-05-30 Thread Jonny Lamb
On gio, 2013-11-28 at 15:34 +0100, Jonny Lamb wrote: > Sorry for the delay with these patches, I forgot to update them. Here > they are again, updated to master and support for rate and delay in > toytoolkit implemented. Here they are updated again for current master. -- J

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-05-30 Thread Jonny Lamb
In the process wl_keyboard's version has been incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 4 implies wl_keyboard version 4). --- protocol/wayland.xml | 17 +++-- 1 file changed, 15 insertions

[PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-05-30 Thread Jonny Lamb
The compositor reads the values out from weston.ini, the weston compositor passes on the values, the weston-info client prints out the values, and the values are respected in toytoolkit. --- clients/weston-info.c| 106 --- clients/window.c |

[PATCH weston 2/5] desktop-shell: add set_panel_position to help place views onscreen

2014-05-22 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 3/5] desktop-shell: use panel location to calculate correct sizes and ranges

2014-05-22 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 229 ++ 1 file changed, 173 insertions(+),

[PATCH weston 4/5] animation: ensure repaints are always scheduled during animations

2014-05-22 Thread Jonny Lamb
Animations are run off the repaint cycle so if there's nothing to repaint, an animation will stop running. This is usually not a problem as each frame function of an animation causes something to change and therefore a repaint to happen. This patch helps detect when the animation isn't in said case

[PATCH weston 0/5] desktop-shell tweaks for maynard shell

2014-05-22 Thread Jonny Lamb
| 15 +- src/spring-tool.c | 5 + 5 files changed, 242 insertions(+), 64 deletions(-) Cheerio, -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston 1/5] animation: fix move scale animation

2014-05-22 Thread Jonny Lamb
Both weston_move_scale_run() and weston_slide_run() were broken in commit 3a869019. Commit a4a6f161 fixed and explained the problem for weston_slide_run() but weston_move_scale_run() remained broken. To fix weston_move_scale_run(), weston_view_animation_run() is also required. It was removed when

[PATCH weston 5/5] desktop-shell: make background applications less dark

2014-05-22 Thread Jonny Lamb
--- desktop-shell/shell.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 51683ee..a5886d7 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -911,21 +911,21 @@ animate_focus_change(struct desktop_shell *s

Re: [PATCH weston] xdg-shell: add description tags where missing

2014-02-24 Thread Jonny Lamb
Fair enough. It broke my Wayland XML documentation generator[1] which is the only reason I noticed it and checked the DTD. 1. http://people.collabora.co.uk/~jonny/weston/ > Reviewed-by: Jasper St. Pierre Thanks. -- Jonny Lamb ___ wayland-devel

[PATCH weston] xdg-shell: add description tags where missing

2014-02-24 Thread Jonny Lamb
wayland.dtd specifies the use of the description tags inside entry and description so let's use them. --- protocol/xdg-shell.xml | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index a2913c4..f88db49 100644 ---

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2013-11-28 Thread Jonny Lamb
In the process wl_keyboard's version has been incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 4 implies wl_keyboard version 4). --- protocol/wayland.xml | 17 +++-- 1 file changed, 15 insertions

[PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2013-11-28 Thread Jonny Lamb
The compositor reads the values out from weston.ini, the weston compositor passes on the values, the weston-info client prints out the values, and the values are respected in toytoolkit. --- clients/weston-info.c| 106 --- clients/window.c |

Re: [PATCH weston] input: implement repeat_info event on wl_keyboard

2013-11-28 Thread Jonny Lamb
re it > sets up the keyboard repeat, inside keyboard_handle_key. That aside, > I think this is good for merging. Sorry for the delay with these patches, I forgot to update them. Here they are again, updated to master and support for rate and delay in toytoolkit implemented.

Re: RFC: surface crop and scale protocol extension

2013-11-28 Thread Jonny Lamb
Il giorno mar, 26/11/2013 alle 18.19 +0100, Jonny Lamb ha scritto: > This is the initial version of the weston implementation of the > wl_scaler protocol extension for surface cropping and scaling. It is > based on the extension RFC version 3, written by Pekka Paalanen. Some slightly

Re: Protocol documentation

2013-11-27 Thread Jonny Lamb
use Wayland. You still have to know basically all of the concepts. At the same time, this is easy enough so yeah, done. -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Protocol documentation

2013-11-27 Thread Jonny Lamb
ce.attach > request documentation is supposed to have 7 paragraphs and they get > smashed into one: > > http://people.collabora.com/~jonny/wayland/wl_surface.html#Request:attach Fixed, thanks. -- Jonny Lamb ___ wayland-devel mailing list wayland-d

[PATCH weston 4/8] protocol: crop & scale RFC v3

2013-11-26 Thread Jonny Lamb
From: Pekka Paalanen Add cropping and scaling to wl_surface. Add a global factory interface wl_scaler, which creates wl_scaler_surface objects tied to a given wl_surface. The wl_scaler_surface object can be used to set a cropping and scaling transformation to change how a wl_buffer maps to wl_su

[PATCH weston 8/8] clients: add scaler test app

2013-11-26 Thread Jonny Lamb
This client tests the wl_scaler and wl_surface_scaler protocol extensions by cropping and then scaling a surface to ensure it is rendered correctly. More details in comments in the code. --- clients/.gitignore | 3 + clients/Makefile.am | 8 ++ clients/scaler.c| 215 ++

[PATCH weston 3/8] compositor: merge surface size from buffer size funcs

2013-11-26 Thread Jonny Lamb
From: Pekka Paalanen Replace the two functions getting the intended surface dimensions from the surface's buffer and buffer transformation parameters by a single function that just set the surface size according to all the buffer state. The old functions were always called in pairs, and always a

[PATCH weston 7/8] pixman-renderer: implement surface scaling and cropping

2013-11-26 Thread Jonny Lamb
The pixman renderer doesn't use the weston_surface_to_buffer* functions to alter coordinates depending on buffer transformation, buffer scaling, and surface scaler (wl_surface_scaler). pixman_transform_scale() is used instead to perform said transformations without having to modify each coordinate.

[PATCH weston 2/8] compositor: do not recompute size on pointer_set_cursor

2013-11-26 Thread Jonny Lamb
From: Pekka Paalanen This removes the calls to weston_surface_buffer_width/height() from input.c, which are the last external calls to them. Instead, use the cached values from weston_surface::width,height. These have already been set by weston_surface_commit(), because that is the only way a we

[PATCH weston 6/8] compositor: transform surface coordinates if a surface scaler is used

2013-11-26 Thread Jonny Lamb
Implements wl_surface_scaler.set by setting desired src_{x,y,width,height} and dst_{width,height} values in the weston_buffer_viewport struct, then altering coordinates in weston_surface_to_buffer* functions if there is a scaler set for said surface. --- src/compositor.c | 84 +

[PATCH weston 5/8] compositor: add stub scaler resources

2013-11-26 Thread Jonny Lamb
This registers the wl_scaler global object and lets clients create wl_surface_scaler objects for surfaces. wl_surface_scaler.set is not implemented so this doesn't really do anything useful yet. --- src/.gitignore | 2 ++ src/Makefile.am | 4 +++ src/compositor.c | 103 +

[PATCH weston 1/8] compositor: gather buffer_transform and _scale into a struct

2013-11-26 Thread Jonny Lamb
From: Pekka Paalanen Gather the variables affecting the coordinate transformations between buffer and local coordinates into a new struct weston_buffer_viewport. This will be more useful later, when the crop & scale extension is implemented. --- src/compositor-drm.c | 11 ++- src/compo

RFC: surface crop and scale protocol extension

2013-11-26 Thread Jonny Lamb
(by Pekka) can be pushed as is as it has nothing to do with wl_scaler, but just cleans up related code in preparation for wl_scaler code. Cropping and scaling has not yet been implemented in the Raspberry Pi renderer; this will happen at some point in the future. Comments appreciated. -- Jonny

Protocol documentation

2013-11-26 Thread Jonny Lamb
http://telepathy.freedesktop.org/spec/ 1. https://github.com/jonnylamb/wayland-docs -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] compositor: raise errors when bad scale or transform values are used

2013-11-21 Thread Jonny Lamb
--- src/compositor.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index c14ec1f..f14b487 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -2063,6 +2063,16 @@ surface_set_buffer_transform(struct wl_client *client, { stru

[PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

2013-11-21 Thread Jonny Lamb
--- protocol/wayland.xml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index a9c8e53..07cd2b1 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -979,6 +979,14 @@ cursor images for pointers, drag icons, etc.

[PATCH wayland 1/2] protocol: document error cases with wl_shm_pool.create_buffer

2013-11-21 Thread Jonny Lamb
This already happens in weston. --- protocol/wayland.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 61fde84..a9c8e53 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -220,6 +220,11 @@ A buffer will keep a refere

[PATCH weston] input: implement repeat_info event on wl_keyboard

2013-07-16 Thread Jonny Lamb
weston-compositor and the weston-info client have also been updated to pass on and print these values if present. The rate and delay defaults originate from X. --- clients/weston-info.c| 106 --- src/compositor-wayland.c | 18 ++-- src/composito

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2013-07-16 Thread Jonny Lamb
In the process wl_keyboard's version has bben incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 3 implies wl_keyboard version 2). --- protocol/wayland.xml | 17 +++-- 1 file changed, 15 insertions