On ven, 2014-07-25 at 15:01 +0300, Pekka Paalanen wrote:
> This may get nsec > 999999999, which seems to just make the timer fail.
> The first thing I tried was repeat_delay=1000 and got no repeat at
> all. It works, if I set it to 999 instead. :-)
>
> Also repeat_rate=1 would hit a similar problem.

Good points. I have fixed these now.

> You are bumping the wl_seat version straight from 1 up to 4, but you
> didn't implement the additions in versions 2 and 3. This leads to the
> following crash in the Wayland backend:

[snip]

> I didn't look further, but I suppose it is the wl_seat.name event
> causing this.

A great guess. I've fixed this.

> It might have made it a bit easier to patch compositor, wayland-backend
> and clients in separate commits, so I could have applied the compositor
> patch at least.

I like more atomic patches. Even though they should be ok as one patch
now I have split them.

> Also, could you add updates to the weston.ini man page, please?

Done.

-- 
Jonny Lamb
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to