Il 16/03/2015 21:44, Bryce Harrington ha scritto:
Since this pattern of code is repeating several places, perhaps having it in a helper function or macro might be more maintainable longer term?
OK I've done that in my next patch set revision but only in clients & tests. I decided not to use the new functions in gl-renderer.c for two reasons:
1. doing so removes the ability to give a warning of having fallen back to eglGetDisplay (and I don't think the warning should be in the helper function), 2. eglCreateWindowSurface and eglCreatePlatformWindowSurface annoyingly take slightly different arguments in the X11 case (see compositor-x11.c) so another argument was added to gl_renderer_interface.output_create which we'd lose the ability to use by using the new functions. Updated patch set incoming. -- Jonny Lamb _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
