On Wed, Apr 08, 2015 at 11:32:20AM +0800, Jonas Ådahl wrote:
> On Tue, Apr 07, 2015 at 06:36:56PM -0700, Jasper St. Pierre wrote:
> > On Tue, Apr 7, 2015 at 6:03 PM, Bryce Harrington
> > wrote:
> > > On Tue, Apr 07, 2015 at 05:01:21PM +0800, Jonas Ådahl wrote:
> > >> Require the client to have at
Regression introduced in 9f8edc5fd880e0a9c482b36e6b4120ccc056ee0b where it
changed from delta / (dpi/default) to delta * dpi/default, causing the inverse
effect of what the dpi setting is supposed to achieve.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 4 ++--
1 file changed, 2 insertions(+)
Hi Mario,
On Wednesday, April 8, 2015, Mario Kleiner
wrote:
>
> It should be fine, i was involved in this stuff for lots of XOrg DRI2/DRI3
> work, but i also tested it on single display and dual-display for each of
> the two outputs and for both outputs simultaneously and different refresh
> rate
tp->nfingers_down gives us the current state of the touchpad but in the case
of the tapping state we need the touchpoints separately. If all touchpoints
end in the same SYN_REPORT frame, tp->nfingers_down is 0 when we handle the
touch releases. This changes the tap state to IDLE on the first releas
On Tue, Apr 07, 2015 at 06:36:56PM -0700, Jasper St. Pierre wrote:
> On Tue, Apr 7, 2015 at 6:03 PM, Bryce Harrington
> wrote:
> > On Tue, Apr 07, 2015 at 05:01:21PM +0800, Jonas Ådahl wrote:
> >> Require the client to have attached (either previously committed, or
> >> newly) a buffer to the cor
On Tue, Apr 07, 2015 at 06:05:24PM -0700, Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:22PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
>
> Small typo, otherwise lgtm.
Fixed locally.
>
> Reviewed-by: Bryce Harrington
>
> (Should this patch be squashed with one of the
On Tue, Apr 07, 2015 at 05:33:55PM -0700, Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:19PM +0800, Jonas Ådahl wrote:
> > They are errors that may be as a result of calling get_xdg_popup on an
> > xdg_shell, not a result of calling a request on xdg_popup.
> >
> > Signed-off-by: Jonas Åd
On Tue, Apr 07, 2015 at 05:16:37PM -0700, Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:16PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
> > ---
> > protocol/xdg-shell.xml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/protocol/xdg-shell.xml b/protocol/x
Reviewed-by: Bryce Harrington
On Tue, Apr 07, 2015 at 05:01:32PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> clients/simple-damage.c | 2 +-
> clients/simple-egl.c| 2 +-
> clients/simple-shm.c| 2 +-
> clients/window.c| 2 +-
> desktop-shell/shell.c | 2 +-
On Tue, Apr 07, 2015 at 05:01:31PM +0800, Jonas Ådahl wrote:
> We cannot rely on the client to provide a surface filling the output so
> we must specify what happens with the outputs area that is not covered
> completely.
>
> Signed-off-by: Jonas Ådahl
I like it.
Reviewed-by: Bryce Harrington
On Tue, Apr 07, 2015 at 05:01:30PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
Couple typos, but nothing major. LGTM:
Reviewed-by: Bryce Harrington
> ---
> protocol/xdg-shell.xml | 41 +++--
> 1 file changed, 39 insertions(+), 2 deletions(-)
>
On Tue, Apr 07, 2015 at 05:01:29PM +0800, Jonas Ådahl wrote:
> Some times the compositor needs to send a configure request but without
> having any clue about what size the surface should have. Examples
> include unmaximizing a surface that was mapped as maximized, or an
> initial state which doesn
On Tue, Apr 07, 2015 at 05:01:28PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
Reviewed-by: Bryce Harrington
> ---
> protocol/xdg-shell.xml | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index
On Tue, Apr 07, 2015 at 05:01:27PM +0800, Jonas Ådahl wrote:
> Mention set_window_geometry in configure documentation.
>
> Add a strategic "For instance" to clarify what is just an example.
>
> Clarify that the arguments of set_window_geometry are in the surface
> local coordinate space.
>
> Poi
On Tue, Apr 07, 2015 at 07:12:48PM -0700, Jasper St. Pierre wrote:
> It's described as murky because it is super murky.
>
> In the brave new world, apps are supposed to be D-Bus Activatable.
> That means setting DBusActivatable=true in their desktop file. A
> requirement for this is that desktop f
On Tue, Apr 07, 2015 at 05:01:26PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 24 +---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index c2e1443..ef16b73 100
It's described as murky because it is super murky.
In the brave new world, apps are supposed to be D-Bus Activatable.
That means setting DBusActivatable=true in their desktop file. A
requirement for this is that desktop file name needs to match their
bus name. D-Bus doesn't require this -- the des
On Tue, Apr 07, 2015 at 05:01:25PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index 3db76ab..c2e1443 100644
> --- a/protocol/xdg-she
On Tue, Apr 07, 2015 at 05:01:24PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
Reviewed-by: Bryce Harrington
> ---
> protocol/xdg-shell.xml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index 46775fe..
On Tue, Apr 07, 2015 at 05:01:23PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index d013803..46775fe 100644
> --- a
On Tue, Apr 7, 2015 at 6:03 PM, Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:21PM +0800, Jonas Ådahl wrote:
>> Require the client to have attached (either previously committed, or
>> newly) a buffer to the corresponding wl_surface, and that the window
>> will not be potentially mapped u
On 04/07/2015 09:34 AM, Pekka Paalanen wrote:
On Sat, 04 Apr 2015 19:45:10 +0200
Mario Kleiner wrote:
On 04/02/2015 01:37 PM, Pekka Paalanen wrote:
On Thu, 2 Apr 2015 07:10:50 +0200
Mario Kleiner wrote:
drm_output_start_repaint_loop() incurred a delay of
one refresh cycle by using a no-op
On Tue, Apr 07, 2015 at 05:01:22PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
Small typo, otherwise lgtm.
Reviewed-by: Bryce Harrington
(Should this patch be squashed with one of the others?)
> ---
> protocol/xdg-shell.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --gi
On Tue, Apr 07, 2015 at 05:01:21PM +0800, Jonas Ådahl wrote:
> Require the client to have attached (either previously committed, or
> newly) a buffer to the corresponding wl_surface, and that the window
> will not be potentially mapped until calling wl_surface.commit after
> having created the wind
On Tue, Apr 07, 2015 at 05:01:20PM +0800, Jonas Ådahl wrote:
> Document that a compositor is free to ping in any way it wants, but a
> client must always respond to any xdg_shell object it created.
>
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 4
> 1 file changed, 4 insert
On Tue, Apr 07, 2015 at 05:01:19PM +0800, Jonas Ådahl wrote:
> They are errors that may be as a result of calling get_xdg_popup on an
> xdg_shell, not a result of calling a request on xdg_popup.
>
> Signed-off-by: Jonas Ådahl
One extremely unimportant grammatical nit in a comment, but otherwise
On Tue, Apr 07, 2015 at 05:01:18PM +0800, Jonas Ådahl wrote:
> Document that a wl_surface can only be assigned either a xdg_popup or
> xdg_surface once and that if the client still stries to do that an error
> is raised.
>
> Signed-off-by: Jonas Ådahl
LGTM,
Reviewed-by: Bryce Harrington
> ---
>
On Tue, Apr 07, 2015 at 05:01:17PM +0800, Jonas Ådahl wrote:
> Require all child objects to be destroyed before the parent. In other
> words, all popups and surfaces created by one xdg_shell instance needs
> to be destroyed before the xdg_shell object, otherwise a protocol error
> is raised.
>
> S
On Tue, Apr 07, 2015 at 05:01:16PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index 3656e10..d1b47d1 100644
> --- a/protocol/xdg-shell.xml
> ++
On Wed, Apr 01, 2015 at 08:10:44AM +0100, mateuszx.potr...@intel.com wrote:
> From: Mateusz Polrola
>
> After weston-launch is executing weston it cannot close TTY file,
> because it is still required to properly handle SIGUSR1 and SIGUSR2
> signals that are used for switching TTY.
>
> Additiona
Signed-off-by: Peter Hutterer
---
src/evdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/evdev.c b/src/evdev.c
index 16ebb9c..a394afa 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1679,6 +1679,11 @@ evdev_configure_device(struct evdev_device *device)
log_info(li
This device has a couple of axes (fake MT) and a wheel. The device itself
exports 4 nodes, this device is the second node, the most problematic one.
Signed-off-by: Peter Hutterer
---
test/Makefile.am| 1 +
test/litest-keyboard-razer-blackwidow.c | 350 ++
Signed-off-by: Peter Hutterer
---
test/pointer.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/test/pointer.c b/test/pointer.c
index 745af63..a39cb2c 100644
--- a/test/pointer.c
+++ b/test/pointer.c
@@ -396,11 +396,17 @@ START_TEST(pointer_scrol
The previous code didn't handle fake MT devices without ABS_X/Y axes (like the
Razer BlackWidow keyboard). Those devices usually start at ABS_MISC and go up
to ABS_MAX, thus triggering the Android check.
Split the condition up: if the device is not a fake MT device we check for the
Android missing
libevdev_set_abs_info() is a noop if the event code isn't enabled on the
device. This leaves ABS_X/Y on NULL, causing a crash later when dereferencing
the absinfo.
https://bugs.freedesktop.org/show_bug.cgi?id=89783
Signed-off-by: Peter Hutterer
---
src/evdev.c | 4 ++--
1 file changed, 2 insert
On Tue, Apr 7, 2015 at 7:39 PM, Jasper St. Pierre
wrote:
> Menus appear fine on my machine.
I just tried again, after updating my Arch system yesterday: Some of the
menus work, for example the view menu. Others are accessible as well
when clicking the middle mouse button, but they are placed in o
On Thu, Apr 02, 2015 at 07:37:07PM -0700, Bryce Harrington wrote:
> On Thu, Apr 02, 2015 at 07:20:00PM -0700, Bill Spitzak wrote:
> > I wasted a lot of time before I figured out that I needed to add those
> > square brackets to get this to work. Sigh...
>
> Lots clearer too.
>
> Reviewed-by: Bryc
On Tue, Apr 07, 2015 at 02:44:59PM +0300, Pekka Paalanen wrote:
> On Thu, 2 Apr 2015 19:16:49 -0700
> Bryce Harrington wrote:
>
> > This enables tests to provide their own .ini files for configuring
> > weston, via the recently added --config option. Also included in this
> > set is some relate
Thanks for taking a look!
On 07/04/15 01:34 PM, Bill Spitzak wrote:
> Oh ok I see you put this in a different patch. I think the patches
> should be merged since you have to change all the calls in the first
> patch anyway.
The 3rd patch fixes bugs, the 2nd is more cosmetic. I thought they'd be
Menus appear fine on my machine. I assume it's the recent Xwayland
bugs. Try weston from master combined with:
http://lists.freedesktop.org/archives/xorg-devel/2015-February/045701.html
On Mon, Apr 6, 2015 at 10:27 AM, Jasper St. Pierre
wrote:
> No, sorry. I'll take a look today.
>
> On Mon, Apr
Oh ok I see you put this in a different patch. I think the patches
should be merged since you have to change all the calls in the first
patch anyway.
I don't like the temporary variable, it seems like you can just put the
call to hash_table_lookup in the if statement and it will be clearer.
On 04/07/2015 10:12 AM, Derek Foreman wrote:
- window = hash_table_lookup(wm->window_hash, leave->event);
+ hash_table_lookup(wm->window_hash, leave->event, &window);
if (!window || !window->decorate)
return;
Shouldn't all of these patches use the return val
Make sure we always test hash_table_lookup()s return to prevent trying to
dereference a NULL window.
Signed-off-by: Derek Foreman
---
xwayland/window-manager.c | 103 +-
1 file changed, 74 insertions(+), 29 deletions(-)
diff --git a/xwayland/window-ma
Currently a window appearing and disappearing quickly can trigger a race that
causes the xwayland test to fail.
The root cause of this is hash_table_lookup failing to find a window that's
already been deleted but is still receiving events.
I've changed how hash_table_lookup() works a little so we
Previously hash_table_lookup returned a pointer which must always be tested
for NULL - but rarely was.
Now hash_table_lookup returns the found data as an out parameter and returns
an integer indicating whether the lookup succeeded or not. This lets us
flag the return value as warn_unused_result s
The first break in TYPE_WM_PROTOCOLS was almost certainly intended to be
nested within the if statement.
Even if it wasn't, it makes sense there.
Signed-off-by: Derek Foreman
---
xwayland/window-manager.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xwayland/window-
On Tue, 7 Apr 2015 11:42:08 +0300
Pekka Paalanen wrote:
> On Mon, 06 Apr 2015 15:46:51 -0500
> Derek Foreman wrote:
>
> > On 02/04/15 07:11 AM, Pekka Paalanen wrote:
> > > On Thu, 2 Apr 2015 01:04:12 +
> > > "Tanibata, Nobuhiko (ADITJ/SWG)" wrote:
> > >
> > >>
> > >>
> > >>> -Original
On Thu, 2 Apr 2015 19:16:49 -0700
Bryce Harrington wrote:
> This enables tests to provide their own .ini files for configuring
> weston, via the recently added --config option. Also included in this
> set is some related cleanup in weston-tests-env.
>
> [Update v2]
> Implemented review comment
On Thu, 2 Apr 2015 19:16:51 -0700
Bryce Harrington wrote:
> Implements a simple mechanism to allow tests to customize the
> configuration. Just place a .ini file at the same location as the
> test itself. If no configuration file is found, then no configuration
> will be used (i.e. --no-config
On Fri, 3 Apr 2015 10:33:02 -0700
Bryce Harrington wrote:
> On Fri, Apr 03, 2015 at 03:21:45PM +0200, Marek Chalupa wrote:
> > On Fri, Apr 3, 2015 at 4:16 AM, Bryce Harrington
> > wrote:
> >
> > > config-malformed uses an invalid configuration file to verify that the
> > > test harness is indee
We cannot rely on the client to provide a surface filling the output so
we must specify what happens with the outputs area that is not covered
completely.
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 4
1 file changed, 4 insertions(+)
diff --git a/protocol/xdg-shell.xml b/protoc
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index 46775fe..3db76ab 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -195,11 +195,10 @@
Th
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index f07ba5e..13168b3 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index 6d02510..84d39bb 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -516,11 +516,14 @@
Some times the compositor needs to send a configure request but without
having any clue about what size the surface should have. Examples
include unmaximizing a surface that was mapped as maximized, or an
initial state which doesn't have any size expectations.
Signed-off-by: Jonas Ådahl
---
prot
Document that a wl_surface can only be assigned either a xdg_popup or
xdg_surface once and that if the client still stries to do that an error
is raised.
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/prot
Signed-off-by: Jonas Ådahl
---
clients/simple-damage.c | 2 +-
clients/simple-egl.c| 2 +-
clients/simple-shm.c| 2 +-
clients/window.c| 2 +-
desktop-shell/shell.c | 2 +-
protocol/xdg-shell.xml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/clients/sim
Document that a compositor is free to ping in any way it wants, but a
client must always respond to any xdg_shell object it created.
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 4
1 file changed, 4 insertions(+)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index
Require the client to have attached (either previously committed, or
newly) a buffer to the corresponding wl_surface, and that the window
will not be potentially mapped until calling wl_surface.commit after
having created the window. This is required to make valid double
buffered xdg_surface state
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index c2e1443..ef16b73 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -265,9 +26
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 12
1 file changed, 12 insertions(+)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index 3db76ab..c2e1443 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -197,6 +197,18 @@
the surface
Mention set_window_geometry in configure documentation.
Add a strategic "For instance" to clarify what is just an example.
Clarify that the arguments of set_window_geometry are in the surface
local coordinate space.
Point out that the client needs to destroy a dismissed popup.
Signed-off-by: Jo
They are errors that may be as a result of calling get_xdg_popup on an
xdg_shell, not a result of calling a request on xdg_popup.
Signed-off-by: Jonas Ådahl
---
desktop-shell/shell.c | 37 +++--
protocol/xdg-shell.xml | 10 ++
2 files changed, 21 insertio
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index d316e06..d013803 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -370,6 +370,9 @@
portions like drop-shad
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index d013803..46775fe 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -233,10 +233,19 @@
Require all child objects to be destroyed before the parent. In other
words, all popups and surfaces created by one xdg_shell instance needs
to be destroyed before the xdg_shell object, otherwise a protocol error
is raised.
Signed-off-by: Jonas Ådahl
---
desktop-shell/shell.c | 26 +
Signed-off-by: Jonas Ådahl
---
protocol/xdg-shell.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
index 3656e10..d1b47d1 100644
--- a/protocol/xdg-shell.xml
+++ b/protocol/xdg-shell.xml
@@ -69,6 +69,9 @@
unstable versions of the p
Hi,
This series is a follow up mostly addressing the issues raised by Pekka
during the last series as well as some other clarifications.
The patches them self is a better in depth description of the changes, but
there are a couple of things that I'd like to bring up more explicitly.
1.
This s
On Mon, 06 Apr 2015 15:46:51 -0500
Derek Foreman wrote:
> On 02/04/15 07:11 AM, Pekka Paalanen wrote:
> > On Thu, 2 Apr 2015 01:04:12 +
> > "Tanibata, Nobuhiko (ADITJ/SWG)" wrote:
> >
> >>
> >>
> >>> -Original Message-
> >>> From: wayland-devel
> >>> [mailto:wayland-devel-boun...@li
On Thu, 02 Apr 2015 09:14:36 -0500
Derek Foreman wrote:
> Makes sense, fixes the problem for me.
>
> Reviewed-by: Derek Foreman
Pushed.
f30af4e..04f8a9b master -> master
Thanks,
pq
> On 02/04/15 08:54 AM, Pekka Paalanen wrote:
> > From: Pekka Paalanen
> >
> > Weston running the Waylan
On Sat, 04 Apr 2015 19:45:10 +0200
Mario Kleiner wrote:
> On 04/02/2015 01:37 PM, Pekka Paalanen wrote:
> > On Thu, 2 Apr 2015 07:10:50 +0200
> > Mario Kleiner wrote:
> >
> >> drm_output_start_repaint_loop() incurred a delay of
> >> one refresh cycle by using a no-op page-flip to get
> >> an ac
71 matches
Mail list logo
