On 04/07/2015 10:12 AM, Derek Foreman wrote:
- window = hash_table_lookup(wm->window_hash, leave->event);
+ hash_table_lookup(wm->window_hash, leave->event, &window);
if (!window || !window->decorate)
return;
Shouldn't all of these patches use the return value, instead of ignoring
it and/or checking the looked up value? How about:
if (!hash_table_lookup(wm->window_hash, leave->event, &window))
return;
if (!window->decorate)
return;
The main reason for making this change is that your version indicates
that it is possible for it to return true and also set window to null,
the above version makes it clear (imho) that a true return value also
means window is not null.
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
