Oh ok I see you put this in a different patch. I think the patches should be merged since you have to change all the calls in the first patch anyway.

I don't like the temporary variable, it seems like you can just put the call to hash_table_lookup in the if statement and it will be clearer.

On 04/07/2015 10:12 AM, Derek Foreman wrote:

+       int found;

-       hash_table_lookup(wm->window_hash, leave->event, &window);
-       if (!window || !window->decorate)
+       found = hash_table_lookup(wm->window_hash, leave->event, &window);
+       if (!found || !window->decorate)
                return;

ie:

        if (!hash_table_lookup(wm->window_hash, leave->event, &window))
          return;
        if (!window->decorate)
          return;
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to