Re: fix pfctl regress on armv7

2019-07-04 Thread Claudio Jeker
On Thu, Jul 04, 2019 at 10:03:20PM +0200, Moritz Buhl wrote: > Hi, > > due to the pfctl regression tests failing on armv7 I noticed that the > yyerror function is having the usual format attributes. This lead to > garbage in error messages on armv7. I added the directives and then > adjusted the f

Re: fix format strings in relayd

2019-07-04 Thread Claudio Jeker
On Thu, Jul 04, 2019 at 10:15:54PM +0200, Moritz Buhl wrote: > Hi, > > as promised a patch to relayd to enable formatting warnings for yyerror. OK claudio@ > Greetings, > Moritz Buhl > > Index: usr.sbin/relayd/parse.y > === > RCS

Re: lock(1): make -n and -t options mutually exclusive

2019-07-04 Thread Theo de Raadt
Klemens Nanni wrote: > On Thu, Jul 04, 2019 at 12:43:21PM -0500, Scott Cheloha wrote: > > It doesn't make sense to allow the user to simultaneously set -n > > (never time out) and also set -t timeout (release the terminal after > > timeout minutes). > Makes sense but the synopsis should probably

Re: drm(4), multi-threaded task queues and barriers

2019-07-04 Thread Jonathan Gray
On Wed, Jun 12, 2019 at 09:15:36AM +0200, Mark Kettenis wrote: > > Date: Wed, 12 Jun 2019 17:04:10 +1000 > > From: Jonathan Gray > > > > On Tue, Jun 11, 2019 at 09:10:46PM +0200, Mark Kettenis wrote: > > > The drm(4) codebase really needs multi-threaded task queues since the > > > code has taks t

Re: syslogd unveil cleanup

2019-07-04 Thread Theo de Raadt
Looks good to me. Alexander Bluhm wrote: > Hi, > > When syslogd(8) parent exists, the file cleanup code does not work > anymore. unveil(2) prevents removal. > > Removing the UNIX domain sockets is not necessary. They are harmless > and unlinked before a new bind. I removed that code. > > /

syslogd unveil cleanup

2019-07-04 Thread Alexander Bluhm
Hi, When syslogd(8) parent exists, the file cleanup code does not work anymore. unveil(2) prevents removal. Removing the UNIX domain sockets is not necessary. They are harmless and unlinked before a new bind. I removed that code. /var/run/syslog.pid is a common feature so we want to keep it.

Re: sync acme-client.conf.5 with the example about LE API url

2019-07-04 Thread Solene Rapenne
On Thu, Jul 04, 2019 at 10:52:50PM +0200, Sebastian Benoit wrote: > Solene Rapenne(sol...@perso.pw) on 2019.07.04 06:56:44 +0200: > > The example uses acme-v02.api.letsencrypt.org while acme-client.conf(5) > > still uses v01. > > ups. > > ok benno@ > thanks! I reply in thread because I receive

Re: sync acme-client.conf.5 with the example about LE API url

2019-07-04 Thread Sebastian Benoit
Solene Rapenne(sol...@perso.pw) on 2019.07.04 06:56:44 +0200: > The example uses acme-v02.api.letsencrypt.org while acme-client.conf(5) > still uses v01. ups. ok benno@ > > Index: acme-client.conf.5 > === > RCS file: /data/cvs/src/

Re: fix pfctl regress on armv7

2019-07-04 Thread Alexander Bluhm
On Thu, Jul 04, 2019 at 10:03:20PM +0200, Moritz Buhl wrote: > - yyerror("rule label too long (max %d chars)", > + yyerror("rule label too long (max %ld chars)", > sizeof(r->label)-1); > yyerror("rule qname too

Re: cwm: label application windows with command name

2019-07-04 Thread Klemens Nanni
Please disregard the patch, I've already found the first flaw in it.

unveil vnode leak

2019-07-04 Thread Alexander Bluhm
Hi, If an unlink fails due to unveil, the reference count of the inode is not decremented. You cannot unmount the file system anymore. I have added unveilleak.c that triggers the breakage. dd if=/dev/zero of=diskimage bs=512 count=4k vnconfig vnd0 diskimage newfs vnd0c mount /dev/vnd0c /mnt unve

fix format strings in relayd

2019-07-04 Thread Moritz Buhl
Hi, as promised a patch to relayd to enable formatting warnings for yyerror. Greetings, Moritz Buhl Index: usr.sbin/relayd/parse.y === RCS file: /cvs/src/usr.sbin/relayd/parse.y,v retrieving revision 1.238 diff -u -p -r1.238 parse.y

fix pfctl regress on armv7

2019-07-04 Thread Moritz Buhl
Hi, due to the pfctl regression tests failing on armv7 I noticed that the yyerror function is having the usual format attributes. This lead to garbage in error messages on armv7. I added the directives and then adjusted the formatting to what the compiler suggested. The same goes for relayd. A pa

ssh-keygen: tweak error for -b

2019-07-04 Thread Christian Weisgerber
Seen on misc@: > $ ssh-keygen -t ed25519 -b 2 > key bits exceeds maximum 16384 The check for > OPENSSL_RSA_MAX_MODULUS_BITS should only be applied to RSA keys. No point in checking for > OPENSSL_DSA_MAX_MODULUS_BITS, since we only permit 1024-bit DSA keys anyway. While there, only set DEFAU

uvideo(4): dynamic max ctrl size

2019-07-04 Thread Patrick Wildt
Hi, on my Lenovo X395 the uvideo(4) follows the current UVC 1.5 spec. The message length was increased with each specification, so now the buffer for probe messages is up to 48 bytes. On that particular device the camera sends a USB stall if we only supply the 26 bytes from the original UVC 1.0

uvideo(4): dump interface association descriptor

2019-07-04 Thread Patrick Wildt
Hi, since we already dump most of the descriptors, also dump the interface association descriptor, which helped me debug the previous issue. Patrick diff --git a/sys/dev/usb/uvideo.c b/sys/dev/usb/uvideo.c index c990c899c45..1a9dfc733fa 100644 --- a/sys/dev/usb/uvideo.c +++ b/sys/dev/usb/uvideo.

uvideo(4): handle interface associations

2019-07-04 Thread Patrick Wildt
Hi, newer laptops can have more than one camera. For instance the Lenovo X395 ships with a normal camera and an infrared camera. These cameras are behind a single USB device and their "functions" are separated using interface association descriptors. This means that there are USB descriptors th

ADMtec aue interface does not work with full 1500 VLAN_MTU

2019-07-04 Thread Christopher Zimmermann
Hi, I own this old USB ethernet controller: aue0 at uhub9 port 5 configuration 1 interface 0 "ADMtek USB To LAN Converter" rev 2.00/1.01 addr 4 aue0: address 00:05:1b:b2:96:02 ukphy0 at aue0 phy 1: Generic IEEE 802.3u media interface, rev. 1: OUI 0x000749, model 0x0001 This works: doas ifconf

Re: lock(1): make -n and -t options mutually exclusive

2019-07-04 Thread Klemens Nanni
On Thu, Jul 04, 2019 at 12:43:21PM -0500, Scott Cheloha wrote: > It doesn't make sense to allow the user to simultaneously set -n > (never time out) and also set -t timeout (release the terminal after > timeout minutes). Makes sense but the synopsis should probably stay the same. You could simply

lock(1): make -n and -t options mutually exclusive

2019-07-04 Thread Scott Cheloha
It doesn't make sense to allow the user to simultaneously set -n (never time out) and also set -t timeout (release the terminal after timeout minutes). ok? Index: lock.c === RCS file: /cvs/src/usr.bin/lock/lock.c,v retrieving revisio

Re: SAS drives on Sparc64

2019-07-04 Thread Theo de Raadt
Andrew Grillet wrote: > I have several SAS H/Ds that are reporting "device not configured" with > fdisk and disklabel. > dd if=/dev/zero of=/dev/sd1 > The dmesg entry for one is ... > sd1 at scsibus1 targ 1 lun 0: SCSI4 > 0/direct fixed naa.5000cca0222458c0 > > I assumed that the problem lies w

Re: SAS drives on Sparc64

2019-07-04 Thread Theo de Raadt
Andrew Grillet wrote: > I assumed that the problem lies with the boot sector contents, and managed > to do > dd if=/dev/zero of=/dev/sd1 > however, the problem has not gone away. Ignoring your other comments, I hope you didn't do that precise command because now you have a gigantic useless regul

SAS drives on Sparc64

2019-07-04 Thread Andrew Grillet
I have several SAS H/Ds that are reporting "device not configured" with fdisk and disklabel. dd if=/dev/zero of=/dev/sd1 The dmesg entry for one is ... sd1 at scsibus1 targ 1 lun 0: SCSI4 0/direct fixed naa.5000cca0222458c0 I assumed that the problem lies with the boot sector contents, and manage

Re: socket splicing without kernel lock

2019-07-04 Thread Claudio Jeker
On Thu, Jul 04, 2019 at 01:16:53PM +0200, Alexander Bluhm wrote: > On Thu, Jul 04, 2019 at 10:47:22AM +0200, Claudio Jeker wrote: > > Would it be possible to use some #defined flags here instead of 1,2,3? > > Maybe use FREAD/FWRITE or define something new. > > Makes code longer, but more readable.

Re: socket splicing without kernel lock

2019-07-04 Thread Alexander Bluhm
On Thu, Jul 04, 2019 at 10:47:22AM +0200, Claudio Jeker wrote: > Would it be possible to use some #defined flags here instead of 1,2,3? > Maybe use FREAD/FWRITE or define something new. Makes code longer, but more readable. ok? bluhm Index: sys/kern/uipc_socket.c ===

Re: move to interface rx queue backpressure for if_rxr livelock detection

2019-07-04 Thread Hrvoje Popovski
On 1.7.2019. 3:16, David Gwynne wrote: > interface rx queue processing includes detection of when the stack > becomes too busy to process packets. > > there's three stages to this mechanism. firstly, everything is fine > and the packets are simply queued for processing. the second is the > "pressu

Re: ftplist.cgi & ftpinstall.cgi source code

2019-07-04 Thread Stuart Henderson
On 2019/07/04 12:59, Lauri Tirkkonen wrote: > Hi tech@, > > I was doing an install into a fresh VM, and the installer was able to > guess the (non-public) mirror I want to use correctly; I got curious and > ran into ftplist.cgi in install.sub. That in itself made me more > curious, but I was unabl

ftplist.cgi & ftpinstall.cgi source code

2019-07-04 Thread Lauri Tirkkonen
Hi tech@, I was doing an install into a fresh VM, and the installer was able to guess the (non-public) mirror I want to use correctly; I got curious and ran into ftplist.cgi in install.sub. That in itself made me more curious, but I was unable to find the source code for these CGI scripts anywhere

Re: socket splicing without kernel lock

2019-07-04 Thread Claudio Jeker
On Wed, Jul 03, 2019 at 11:49:51PM +0200, Alexander Bluhm wrote: > Hi, > > I would like to remove a useless kernel lock during socket splicing. > > We have a socket "so" that splices data to socket "sosp". Everytime > when space in sosp gets available, we add a task to move data from > so to sos

Re: ospfd: point-to-point on ethernet interfaces

2019-07-04 Thread Remi Locherer
On Thu, Jul 04, 2019 at 09:20:59AM +0300, Kapetanakis Giannis wrote: > Hi, > > This does not work for me with IOS. > > neighbor is full, > rib is ok > fib does not list the routes to IOS and > routing table is not updated on BSD > > On IOS I do have the loopback route the BSD is announcing. Tha