Re: [Scid-users] Please commit this simple patch

2011-01-25 Thread Joost 't Hart
On 01/25/2011 12:17 PM, Fulvio wrote: Can someone please commit this patch to current cvs? It will be easier to me to send new patches. The code is perfectly safe, it basically do nothing :-) 1) mfile.h and mfile.cpp The patch inlines the Read*Bytes functions avoiding some million calls 2) pboo

Re: [Scid-users] Please commit this simple patch

2011-01-25 Thread Joost 't Hart
On 01/25/2011 12:17 PM, Fulvio wrote: Can someone please commit this patch to current cvs? It will be easier to me to send new patches. The code is perfectly safe, it basically do nothing :-) 1) mfile.h and mfile.cpp The patch inlines the Read*Bytes functions avoiding some million calls 2) pboo

Re: [Scid-users] Please commit this simple patch

2011-01-25 Thread Joost 't Hart
Looks convincing indeed! Joost. On Tue, Jan 25, 2011 at 2:38 PM, Steven wrote: > >> > 3) stored.cpp >> > Solves a bug that leaves storedLineMatches_[line] >> > uninitializated in some >> > lines. >> >> I will check this; tomorrow probably. > > I was looking at some nasty tree anomalies today. > (

Re: [Scid-users] Best Games List/Games list + Filter interaction was: Potential data loss using trees

2011-01-25 Thread gerd . lorscheid
Hello, your note that filters are more or less queries is right. In the product they are called everywhere filters, so I prefer to keep it. treeFilter and dbFilter are already independent, so there is no need for changes. If the user wants to filter by position and header search he performs a th

Re: [Scid-users] Please commit this simple patch

2011-01-25 Thread Joost 't Hart
Hi, On Tue, Jan 25, 2011 at 12:17 PM, Fulvio wrote: > Can someone please commit this patch to current cvs? > It will be easier to me to send new patches. > The code is perfectly safe, it basically do nothing :-) > > 1) mfile.h and mfile.cpp > The patch inlines the Read*Bytes functions avoiding so

[Scid-users] Please commit this simple patch

2011-01-25 Thread Fulvio
Can someone please commit this patch to current cvs? It will be easier to me to send new patches. The code is perfectly safe, it basically do nothing :-) 1) mfile.h and mfile.cpp The patch inlines the Read*Bytes functions avoiding some million calls 2) pbook.cpp When you start scid (even without

Re: [Scid-users] Best Games List/Games list + Filter interaction was: Potential data loss using trees

2011-01-25 Thread Fulvio
Alexander Wagner wrote: > In general we should discuss this point further. Probably, the games > list should indeed learn some states: all, tree, header and a > combination of those. What I tried to discuss with Gerd (but he seems > to miss understand me here a bit) is how we make clear to the u

Re: [Scid-users] Best Games List/Games list + Filter interaction was: Potential data loss using trees

2011-01-25 Thread Fulvio
Gerd Lorscheid wrote: > Hello, > > What I have implemented is the following: > I have added a checkbox, which controls whether the games in the list are > filtered by the actual position. Ok, the user interface is perfect in my opinion. Can we try to discuss how to do that, maybe starting wit