Hi, On Tue, Jan 25, 2011 at 12:17 PM, Fulvio <f...@libero.it> wrote: > Can someone please commit this patch to current cvs? > It will be easier to me to send new patches. > The code is perfectly safe, it basically do nothing :-) > > 1) mfile.h and mfile.cpp > The patch inlines the Read*Bytes functions avoiding some million calls
a: What is the performance gain? Please test this. My feeling is that you cannot even measure it. b: What is the code size increase? c: (Concluding): Is it really worth it? > > 2) pbook.cpp > When you start scid (even without a database) an eco file is read that needs > to create 10000 standard board > The change make that clear to the compiler so it will avoid 10000 StdStart() > calls. I will check this; tomorrow probably. > > 3) stored.cpp > Solves a bug that leaves storedLineMatches_[line] uninitializated in some > lines. I will check this; tomorrow probably. > > 4) analysis.tcl > Correct the indentation of proc toggleFinishGame. I will not commit this. Whenever I write (virtually) new code, I will apply an indentation of 4 (spaces, no tabs), as that is _my_ preference and it allows _me_ to perform better. I would not even consider touching the style preferred and used by others. Cheers, Joost. ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
