YyJyyy left a comment (openstreetmap/openstreetmap-website#6099)
Why did I deploy according to the ID process, but why is it like this later
on，help me！！！
--
Reply to this email directly or view it on Git
tomhughes left a comment (openstreetmap/openstreetmap-website#6137)
If the `yarn.lock` changes are to add the two extra modules and any
dependencies they have then sure.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuec
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757)
I still feel it's harder than before to spot changesets with comments, it's
doable but requires one to look more carefully when scrolling through the list
slowly rather than a quick scan.
I feel there could be more visual se
pnorman left a comment (openstreetmap/openstreetmap-website#6137)
I've got it working now. When this is ready for merging I'll rebase and squish
before taking it out of draft.
How should I handle updating yarn.lock? Should I just accept all the changes?
--
Reply to this email directly or view
@pnorman pushed 1 commit.
0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae Fix manipulation of VT style URLs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/f32315a96f4920495c22409ed8070536a4d61642..0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae
You are receiving
mnalis left a comment (openstreetmap/openstreetmap-website#3386)
Anyway, as nowadays one can filter notes by status (thus forcing only
unresolved notes to show), the need for this has diminished significantly for
me, so I'll close it.
--
Reply to this email directly or view it on GitHub:
https
Closed #3386.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3386#event-18376014245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#6148)
Great. I think this looks good then.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6148#issuecomment-3016856410
You are receiving this because you are subscribe
Closed #6146 as completed via #6148.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6146#event-18374934632
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6148 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6148#event-18374934576
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6148)
Yes because it's not a "real" link, it's handled by javascript, like the one on
an element version page:
A real link would write its an
tomhughes left a comment (openstreetmap/openstreetmap-website#6148)
I assume it's deliberate that the new label is styled as body text even when
it's a link?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6148#issuecomment-30168
Fixes #6146.
Before:
After:
You can view, comment on, or merge this pull request online at:
https://github.com/op
@hlfan pushed 1 commit.
24e24f9e447e7c678f4d7bd417d51b9a0f515c5e Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/f4cac8897124af3ca2d987e4f8fbd6ff87384b9c..24e24f9e447e7c678f4d7bd417d51b9a0f515c5e
You are r
@hlfan pushed 7 commits.
6a452e072ecd43879e41539d34a48852ba95800b Make Rails handle SVG partials
1a0034b028ce3ec626d1c2c4b433db659d043d75 Move search icons to partials
fb25c3cebea73930222537451ce4451339b2dd66 Move about icons to partials
78dbb8493b0796379823842ef6918d146fee7b92 Move welcome ic
@hlfan pushed 1 commit.
0a0898ad53d11a2dd0be83b19d9d8c0824789460 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/59d71a87257c512573153fcc669d961455b9dfc0..0a0898ad53d11a2dd0be83b19d9d8c0824789460
You are rec
@AntonKhorev commented on this pull request.
> @@ -23,6 +23,90 @@
};
OSM.MappedElement = function (map, type) {
+let abortController = null;
+
+function markWikidataLinkAsExplainable(i, link) {
Why is all of this wikidata code inside `OSM.MappedElement`? The idea behind
`OSM.El
Merged #6143 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6143#event-18374544184
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6138 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6138#event-18374544191
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6140 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6140#event-18374544190
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #6130 as completed via #6138.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6130#event-18374544250
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6144 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6144#event-18374544188
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6138)
This does really need a test but it's quite complicated to do... I did start
looking at it in Friday but didn't make any conclusive progress.
This certainly looks right so I'm going to merge it and deal with testing later.
--
tomhughes left a comment (openstreetmap/openstreetmap-website#6144)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6144#issuecomment-3016766622
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6143)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6143#issuecomment-3016764989
You are receiving this because you are subscribed to this t
@AntonKhorev commented on this pull request.
> +$("")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, height: "32" })
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
In case anyone asks for an image attribution, we can have i
@hlfan pushed 1 commit.
59d71a87257c512573153fcc669d961455b9dfc0 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/753cf765807e1e6af2f152f1618003410d089347..59d71a87257c512573153fcc669d961455b9dfc0
You are rec
@hlfan pushed 1 commit.
753cf765807e1e6af2f152f1618003410d089347 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/a3bd94a902c1aa12728122a64bb3b3105e6cd1f8..753cf765807e1e6af2f152f1618003410d089347
You are rec
@AntonKhorev commented on this pull request.
> + fetch(OSM.WIKIDATA_URL + "?" + new URLSearchParams({
+action: "wbgetentities",
+format: "json",
+origin: "*",
+ids: qid,
+props: "labels|sitelinks|claims|descriptions",
+languages: langs.join("|
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6144#pullrequestreview-2969255540
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan left a comment (openstreetmap/openstreetmap-website#6092)
If you want to, you can copy this commit into a new PR, I'm not quite ready for
another round of this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6092#issueco
maro-21 left a comment (openstreetmap/openstreetmap-website#6092)
> something I already implemented in
> [cfb1743](https://github.com/openstreetmap/openstreetmap-website/commit/cfb17435d1b11cd94aa865a6448e487b1a0cca17)
So can it be merged too?
--
Reply to this email directly or view it on GitH
Robot8A left a comment (openstreetmap/openstreetmap-website#6147)
Fixed here
https://translatewiki.net/w/i.php?title=Osm%3ADate.formats.heatmap%2Fes&diff=13186905&oldid=13162294
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/614
Robot8A left a comment (openstreetmap/openstreetmap-website#6147)
Actually closing this, as I realize it should be done through TranslateWiki,
thanks @github-actions for the heads up
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pul
Closed #6147.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6147#event-18373386243
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Robot8A left a comment (openstreetmap/openstreetmap-website#6147)
Also fixed the `% {count}` on the Spanish translation in here, by removing the
wrongly placed space:
https://translatewiki.net/w/i.php?title=Osm%3AJavascripts.heatmap.tooltip.contributions%2Fes&diff=13186891&oldid=13102972
--
Re
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6147)
1 Warning
:warning:
The following YAML files other than
en.yml have been modified: config/locales/es.yml.
Only en.yml is allowed to be changed. Tran
Related to #6017
### Description
How it currently reads:
How it should read:
%{count} contribuciones el 23 de junio
### How has this been tested?
You ca
38 matches
Mail list logo
