Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-07-01 Thread Seiji Aguchi
> > > void error_report(const char *fmt, ...) > > > { > > > va_list ap; > > > +char timestr[TIMESTAMP_LEN]; > > > + > > > +if (enable_timestamp_msg) { > > > +qemu_get_timestamp_str(×tr); > > > +error_printf("%s ", timestr); > > > +} > > > > > > error_print_lo

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
> >> > >> I wonder if TIME_H is maybe a bit too nondescript and could conflict > >> with other guards. OK. I will use QEMU_TIME_H. Apologies for my curt reply. Seiji

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Laszlo Ersek
On 06/28/13 20:54, Seiji Aguchi wrote: > >>> diff --git a/include/qemu/time.h b/include/qemu/time.h >>> new file mode 100644 >>> index 000..f70739b >>> --- /dev/null >>> +++ b/include/qemu/time.h >>> @@ -0,0 +1,11 @@ >>> +#ifndef TIME_H >>> +#define TIME_H >> >> I wonder if TIME_H is maybe a b

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
> > diff --git a/include/qemu/time.h b/include/qemu/time.h > > new file mode 100644 > > index 000..f70739b > > --- /dev/null > > +++ b/include/qemu/time.h > > @@ -0,0 +1,11 @@ > > +#ifndef TIME_H > > +#define TIME_H > > I wonder if TIME_H is maybe a bit too nondescript and could conflict > wi

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-27 Thread Eric Blake
On 06/27/2013 04:21 AM, Laszlo Ersek wrote: > comments below > > On 06/27/13 04:08, Seiji Aguchi wrote: >> [Issue] >> When we offer a customer support service and a problem happens >> in a customer's system, we try to understand the problem by >> comparing what the customer reports with message lo

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-27 Thread Laszlo Ersek
comments below On 06/27/13 04:08, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we o

[Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-26 Thread Seiji Aguchi
[Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens. But, currently, there is