Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

[Seiji Aguchi]

> > >  void error_report(const char *fmt, ...)
> > >  {
> > >      va_list ap;
> > > +    char timestr[TIMESTAMP_LEN];
> > > +
> > > +    if (enable_timestamp_msg) {
> > > +        qemu_get_timestamp_str(&timestr);
> > > +        error_printf("%s ", timestr);
> > > +    }
> > >
> > >      error_print_loc();
> > >      va_start(ap, fmt);
> >
> > Does this print the timestamp to all kinds of monitors too? On stderr,
> > the timestamp is great. When printed to an "interactive monitor", it
> > could also help post-mortem debugging. But would it not confuse libvirt
> > eg.? (Apologies if this has been discussed before.)
> 
> I will try to add timestamp to monitor_printf().
> (In the long term, I would like to add it to all fprintf() in qemu.)

I tried to add timestamp to monitor_printf().
But, it wasn't easier than I expected.
(At least, we should not add it to monitor_printf() in readline.c.)
We need to discuss which message of monitor_printf() has to be
added timestamp.

Therefore, I would like to forcus on error_report() in this thread.
(I posted patch v5 just now.)

Seiji