Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-28 Thread Daniel P . Berrangé
On Mon, Jun 27, 2022 at 04:32:00PM -0400, Peter Xu wrote: > On Mon, Jun 27, 2022 at 04:03:09PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > diff --git

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-27 Thread Peter Xu
On Mon, Jun 27, 2022 at 03:44:21PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 27, 2022 at 03:41:57PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 23, 2022 at 03:13:36PM -0400, Peter Xu wrote: > > > On Thu, Jun 23, 2022 at 09:47:51AM +0100, Daniel P. Berrangé wrote: > > > > > Hmm, when I wan

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-27 Thread Peter Xu
On Mon, Jun 27, 2022 at 04:03:09PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > > index 74f919d

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-27 Thread Daniel P . Berrangé
On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > index 74f919de67..e206b05550 100644 > > --- a/migration/qemu-file.c > > +++ b/migration/qemu-f

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-27 Thread Daniel P . Berrangé
On Mon, Jun 27, 2022 at 03:41:57PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 23, 2022 at 03:13:36PM -0400, Peter Xu wrote: > > On Thu, Jun 23, 2022 at 09:47:51AM +0100, Daniel P. Berrangé wrote: > > > > Hmm, when I wanted to run the whole bunch of the migration-test again I > > > > found that

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-27 Thread Daniel P . Berrangé
On Thu, Jun 23, 2022 at 03:13:36PM -0400, Peter Xu wrote: > On Thu, Jun 23, 2022 at 09:47:51AM +0100, Daniel P. Berrangé wrote: > > > Hmm, when I wanted to run the whole bunch of the migration-test again I > > > found that precopy tls test hangs > > > (/x86_64/migration/precopy/unix/tls/psk). > >

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Peter Xu
On Thu, Jun 23, 2022 at 09:47:51AM +0100, Daniel P. Berrangé wrote: > > Hmm, when I wanted to run the whole bunch of the migration-test again I > > found that precopy tls test hangs (/x86_64/migration/precopy/unix/tls/psk). > > Though for this time it also hangs for me even with the master branch,

[PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixup len = *-*EIO as

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > > index 74f919de67..e206b05550 10

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Daniel P . Berrangé
On Wed, Jun 22, 2022 at 04:13:39PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > > index 74f919de67..e206b

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Daniel P . Berrangé
On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > index 74f919de67..e206b05550 100644 > > --- a/migration/qemu-file.c > > +++ b/migration/qemu-f

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > index 74f919de67..e206b05550 100644 > > --- a/migration/qemu-file.c > > +++ b/migration/qemu-f

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index 74f919de67..e206b05550 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -377,8 +377,22 @@ static ssize_t qemu_fill_buffer(QEMUFil

[PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-22 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.