On Mon, Jun 27, 2022 at 03:44:21PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 27, 2022 at 03:41:57PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 23, 2022 at 03:13:36PM -0400, Peter Xu wrote: > > > On Thu, Jun 23, 2022 at 09:47:51AM +0100, Daniel P. Berrangé wrote: > > > > > Hmm, when I wanted to run the whole bunch of the migration-test again > > > > > I > > > > > found that precopy tls test hangs > > > > > (/x86_64/migration/precopy/unix/tls/psk). > > > > > Though for this time it also hangs for me even with the master > > > > > branch, so > > > > > maybe not anything wrong with this specific pull req but still > > > > > something > > > > > needs fixing.. > > > > > > > > That pre-existing test has been runnnig by default in CI for a while > > > > now, under different OS builds, so I'm surprised. Is there anything > > > > especially unusual / different about your setup that could explain > > > > why you see hang that we don't get anywhere else ? > > > > > > TL;DR: I think it's not run in CI? > > > > > > Please see ufd_version_check(), as when uffd not detected we'll skip the > > > whole thing. > > > > Our CI should be passing that check for the private runners eg > > > > https://gitlab.com/qemu-project/qemu/-/jobs/2641920502 > > > > shows us running 35 tests > > > > 2/178 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK > > 65.57s 35 subtests passed > > > > but yes, the container based jobs are all skipping > > > > > > > > We really need to apply this patch, soon-ish.. > > > > > > https://lore.kernel.org/all/20210615175523.439830-2-pet...@redhat.com/ > > BTW, I'd suggest re-sending that patch to bump it up in the inbox as > its a year old at this point.
Indeed it already conflicts with the preempt series, I'll post one based on that. Thanks. -- Peter Xu
