Re: [PATCH 2/2] target/arm: Fix big-endian handling of SVE gdb remote debugging

2025-07-21 Thread Philippe Mathieu-Daudé
On 21/7/25 23:19, Vacha Bhavsar wrote: This patch adds big endian support for SVE GDB remote debugging. It replaces the use of pointer dereferencing with the use of ldq_p() as explained in the first part of this patch series. Additionally, the order in which the buffer content is loaded into the

Re: [PATCH 1/2] target/arm: Fix big-endian handling of NEON gdb remote debugging

2025-07-21 Thread Philippe Mathieu-Daudé
Hi, On 21/7/25 23:19, Vacha Bhavsar wrote: This patch adds big endian support for NEON GDB remote debugging. It replaces the use of ldq_le_p() with the use of ldq_p() as explained in the first part of this patch series. Additionally, the order in which the buffer content is loaded into the CPU s

Re: [PATCH 1/2] target/arm: hvf: add timer frequency note

2025-07-21 Thread Philippe Mathieu-Daudé
Hi Mohamed, On 21/7/25 17:29, Mohamed Mediouni wrote: On Apple M3 and later, the timer frequency within apps and VM guests are different from each other. Also M1/M2, so all Apple Silicon chipsets IMO. This might be the issue I fixed here: https://lore.kernel.org/qemu-devel/20250620130709.310

Re: [PATCH-for-10.1 0/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size()

2025-07-21 Thread Philippe Mathieu-Daudé
On 21/7/25 14:40, Peter Maydell wrote: On Wed, 16 Jul 2025 at 18:28, Philippe Mathieu-Daudé wrote: Have get_physical_address_range() return when HVF is not usable, allowing to try another accelerator if requested with '-accel hvf:tcg', reported here: https://gitlab.com/qemu-pr

Re: [PATCH] util: win32: Write hex value when can't get error message

2025-07-21 Thread Philippe Mathieu-Daudé
On 21/7/25 12:12, Kostiantyn Kostiuk wrote: On Mon, Jul 21, 2025 at 12:22 PM Markus Armbruster > wrote: Kostiantyn Kostiuk mailto:kkost...@redhat.com>> writes: > On Sat, Jul 19, 2025 at 9:27 AM Markus Armbruster mailto:arm...@redhat.com>> wrote: >

Re: apparent race condition in mttcg memory handling

2025-07-21 Thread Philippe Mathieu-Daudé
(Cc'ing few more developers) On 30/5/25 21:20, Michael Tokarev wrote: Hi! For quite some time (almost whole day yesterday) I'm trying to find out what's going on with mmtcg in qemu.  There's apparently a race condition somewhere, like a use-after-free or something. It started as an incarnation

Re: [PATCH-for-10.1] ui/curses: Fix infinite loop on windows

2025-07-21 Thread Philippe Mathieu-Daudé
Ping? On 8/4/25 21:01, Philippe Mathieu-Daudé wrote: On 3/4/25 03:07, William Hu via wrote:  From a42046272f0544dd18ed58661e53ea17d1584c2c Mon Sep 17 00:00:00 2001 From: William Hu Date: Wed, 2 Apr 2025 12:00:00 -0400 Subject: [PATCH] ui/curses: Fix infinite loop on windows Replace -1

Re: [PATCH v2 2/2] tests/functional/test_aarch64_rme: update image

2025-07-21 Thread Philippe Mathieu-Daudé
On 19/7/25 17:38, Pierrick Bouvier wrote: On 7/19/25 3:57 AM, Manos Pitsidianakis wrote: On Sat, Jul 19, 2025 at 7:00 AM Pierrick Bouvier wrote: TF-A needs to be patched to enable support for FEAT_TCR2 and FEAT_SCTLR2. This new image contains updated firmware. Signed-off-by: Pierrick Bouvier

Re: [PATCH for-10.1 07/10] target/arm: Correct sense of FPCR.AH test for FMAXQV and FMINQV

2025-07-21 Thread Philippe Mathieu-Daudé
"handling" Fixes: 1de7ecfc12d05 ("target/arm: Implement FADDQV, F{MIN, MAX}{NM}QV for SVE2p1") Signed-off-by: Peter Maydell --- target/arm/tcg/translate-sve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Philippe Mathieu-Daudé
On 18/7/25 08:05, Philippe Mathieu-Daudé wrote: On 18/7/25 07:11, Markus Armbruster wrote: Adam Williamson writes: In cfcacba an `error_report` was added to this file, but the    In commit cfcacbab38e ("xen/passthrough: use gsi to map pirq when    dom0 is PVH") an `error_r

Re: [PATCH-for-10.1] hw/arm/smmu-common: Avoid using inlined functions with external linkage

2025-07-17 Thread Philippe Mathieu-Daudé
al. Fixes: b8fa4c23 (hw/arm/smmu: Support nesting in the rest of commands) I suppose b8fa4c233bd was copy/pasted before 0b796f38106 ("hw/arm/smmu: Avoid using inlined functions with external linkage again"). Signed-off-by: JianChunfu Reviewed-by: Richard Henderson Reviewed-by: Phil

Re: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 22:57, Roman Kiryanov wrote: this function is declared in smmu-common.h without `inline`. It is also used outside of this file which causes linking errors because the non-inline version is not generated. Signed-off-by: Will Hollins Signed-off-by: Roman Kiryanov --- hw/arm/smmu-com

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Philippe Mathieu-Daudé
de effect of including "trace.h" a include/ file due to trace event being called in inlined function. Bad pattern indeed. Back to this patch: Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC PATCH RESEND 37/42] accel/hvf: Emulate HVC at EL2

2025-07-17 Thread Philippe Mathieu-Daudé
On 22/6/25 05:28, Richard Henderson wrote: On 6/20/25 10:27, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   target/arm/hvf/hvf.c | 6 ++   1 file changed, 6 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 3907ea8791e..a4f823f834d

Re: [PULL 14/17] esp.c: only call dma_memory_read function if transfer length is non-zero

2025-07-17 Thread Philippe Mathieu-Daudé
Hi Mark, On 15/7/25 08:19, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland In the cases where mixed DMA/non-DMA transfers are used or no data is available, it is possible for the calculated transfer length to be zero. Only call the dma_memory_read function where the transfer length is

Re: [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 12:06, Mads Ynddal wrote: On 16 Jul 2025, at 19.28, Philippe Mathieu-Daudé wrote: Emit a warning when HVF doesn't return the IPA bit length and return -1 as "this accelerator is not usable", allowing QEMU to try with the next one (when using '-accel hvf:tcg&#

Re: [PATCH] docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 12:41, Alex Bennée wrote: Signed-off-by: Alex Bennée --- docs/devel/testing/functional.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 28/69] qapi: Move definitions related to accelerators in their own file

2025-07-17 Thread Philippe Mathieu-Daudé
On 16/7/25 11:24, Daniel P. Berrangé wrote: On Wed, Jul 16, 2025 at 10:23:26AM +0200, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Markus, I missed this one, sorry! On 3/7/25 12:54, Philippe Mathieu-Daudé wrote: Extract TCG and KVM definitions from machine.json to

Re: [PATCH v2 2/3] migration: HMP: Fix postcopy latency distribution label

2025-07-17 Thread Philippe Mathieu-Daudé
ood catch. Reviewed-by: Philippe Mathieu-Daudé

[PATCH-for-10.1 2/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size()

2025-07-16 Thread Philippe Mathieu-Daudé
Do not abort in hvf_arm_get_default_ipa_bit_size() and hvf_arm_get_max_ipa_bit_size() when the IPA can not be fetched. Return 0 (and document it). Signed-off-by: Philippe Mathieu-Daudé --- target/arm/hvf_arm.h | 11 +++ target/arm/hvf/hvf.c | 8 ++-- 2 files changed, 13 insertions

[PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X'

2025-07-16 Thread Philippe Mathieu-Daudé
Developers are custom to read RWX, not RWE. Replace E -> X. Reported-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- accel/hvf/hvf-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index e67a8105a66..0a4b498e836 100

[PATCH-for-10.1 0/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size()

2025-07-16 Thread Philippe Mathieu-Daudé
Have get_physical_address_range() return when HVF is not usable, allowing to try another accelerator if requested with '-accel hvf:tcg', reported here: https://gitlab.com/qemu-project/qemu/-/issues/2981 Philippe Mathieu-Daudé (3): accel/hvf: Display executable bit as 'X'

[PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length

2025-07-16 Thread Philippe Mathieu-Daudé
1 Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index ef6be3660f5..062812bf252 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3149,8 +3149,12 @@ static int virt_hvf_get_physical_a

Re: [PATCH 0/7] hw/i386/amd_iommu: Cleanups and fixes

2025-07-16 Thread Philippe Mathieu-Daudé
On 16/7/25 09:31, Sairaj Kodilkar wrote: This series provides few cleanups and fixes for the amd iommu The patches are based on top of 56c6e249b698 (v10.0.0-rc3) and Alejandro's DMA remapping series [1]. 56c6e249b698 is 4 months old, we are about to release v10.1.0-rc0. What is the point of p

Re: [PATCH 2/7] hw/i386/amd_iommu: Remove unused and wrongly set ats_enabled field

2025-07-16 Thread Philippe Mathieu-Daudé
On 16/7/25 09:31, Sairaj Kodilkar wrote: The ats_enabled field is set using HTTUNEN, which is wrong. Fix this by removing the field as it is never used. Fixes: d29a09ca68428 ("hw/i386: Introduce AMD IOMMU") Signed-off-by: Sairaj Kodilkar Reviewed-by: Vasant Hegde --- hw/i386/amd_iommu.c | 2

Re: [PATCH 1/7] hw/i386/amd_iommu: Fix MMIO register write tracing

2025-07-16 Thread Philippe Mathieu-Daudé
, 18 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()

2025-07-15 Thread Philippe Mathieu-Daudé
lean it up. Signed-off-by: Xiaoyao Li --- target/i386/host-cpu.h | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PULL 00/13] Net patches

2025-07-15 Thread Philippe Mathieu-Daudé
On 16/7/25 04:21, Jason Wang wrote: Hi Stefan: On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote: Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. I sent a V2 of the PULL: https://mail.gnu.org/archive/html/qemu-devel/2

Re: [PATCH] system/qdev: Remove pointless NULL check in qdev_device_add_from_qdict

2025-07-15 Thread Philippe Mathieu-Daudé
On 10/7/25 16:48, Peter Maydell wrote: On Mon, 10 Feb 2025 at 12:10, Philippe Mathieu-Daudé wrote: Coverity reported a unnecessary NULL check: qemu/system/qdev-monitor.c: 720 in qdev_device_add_from_qdict() 683 /* create device */ 684 dev = qdev_new(driver); ... 719

[PULL 08/17] accel: Extract AccelClass definition to 'accel/accel-ops.h'

2025-07-15 Thread Philippe Mathieu-Daudé
Only accelerator implementations (and the common accelator code) need to know about AccelClass internals. Move the definition out but forward declare AccelState and AccelClass. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Message-Id

[PULL 04/17] qapi/machine: Add @qom-type field to CpuInfoFast structure

2025-07-15 Thread Philippe Mathieu-Daudé
Knowing the QOM type name of a CPU can be useful, in particular to infer its model name. Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xiaoyao Li Message-Id: <20250715090624.52377-2-phi...@linaro.org> --- qapi/machin

[PULL 17/17] system/runstate: Document qemu_add_vm_change_state_handler_prio* in hdr

2025-07-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Message-Id: <20250715171920.89670-1-phi...@linaro.org> --- include/system/runstate.h | 30 ++ system/runstate.c | 30 -- 2 files changed, 30 insertions(

[PULL 16/17] system/runstate: Document qemu_add_vm_change_state_handler()

2025-07-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-4-phi...@linaro.org> --- include/system/runstate.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/system/runsta

[PULL 00/17] Accelerators patches for 2025-07-15

2025-07-15 Thread Philippe Mathieu-Daudé
-cpu-ops.h Richard Henderson (maintainer:Overall) Paolo Bonzini (reviewer:Overall) "Philippe Mathieu-Daudé" (reviewer:Overall) 10/17 Checking commit 8cc04fd9df3b (accel/tcg: Extract statistic related code to tcg-stats.c) WARNING: Saw acceptable license 'LGPL-2.1-or-later'

[PULL 15/17] accel/hvf: Implement AccelClass::get_vcpu_stats() handler

2025-07-15 Thread Philippe Mathieu-Daudé
Co-developed-by: Mads Ynddal Signed-off-by: Mads Ynddal Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250715104015.72663-8-phi...@linaro.org> --- accel/hvf/hvf-accel-ops.c | 25 + 1 file changed, 25 insertions(+) diff -

[PULL 11/17] accel/system: Introduce @x-accel-stats QMP command

2025-07-15 Thread Philippe Mathieu-Daudé
Unstable QMP 'x-accel-stats' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Markus Armbruster Reviewed-by: Zhao Liu Message-Id: <20250715140048.84942-4-phi...@linaro.o

[PULL 10/17] accel/tcg: Extract statistic related code to tcg-stats.c

2025-07-15 Thread Philippe Mathieu-Daudé
-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Message-Id: <20250715140048.84942-3-phi...@linaro.org> --- accel/tcg/monitor.c | 201 --- accel/tcg/tcg-stats.c | 215 ++ acc

[PULL 07/17] accel: Rename 'system/accel-ops.h' -> 'accel/accel-cpu-ops.h'

2025-07-15 Thread Philippe Mathieu-Daudé
$(git grep -l system/accel-ops.h) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-38-phi...@linaro.org> --- include/{system/accel-ops.h => accel/accel-cpu-ops.h} | 8 +

[PULL 05/17] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
916 model=cortex-r5f CPU #3: thread_id=42916 model=cortex-r5f (qemu) Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Tested-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xiaoyao Li Message-Id: <20250715090624.52377-3-phi...@linaro.org> --- hw/core/machine-hm

[PULL 03/17] qapi/accel: Move definitions related to accelerators in their own file

2025-07-15 Thread Philippe Mathieu-Daudé
Extract KVM definitions from machine.json to accelerator.json. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Zhao Liu Message-Id: <20250703105540.67664-29-phi...@linaro.org> --- MAINTAINERS| 1 + qapi/accelerator.json

[PULL 12/17] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
'info accel' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Pierrick Bouvier Message-Id: <20250715140048.84942-5-phi...@linaro.org> --- accel/accel-system.c | 8 ++

[PULL 13/17] accel/tcg: Propagate AccelState to dump_accel_info()

2025-07-15 Thread Philippe Mathieu-Daudé
y: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20250715140048.84942-6-phi...@linaro.org> --- accel/tcg/internal-common.h | 2 -- include/tcg/tcg.h | 2 ++ accel/tcg/monitor.c | 1 + accel/tcg/tcg-stats.c | 5 ++--- 4 files changed, 5 insertions

[PULL 14/17] accel/tcg: Implement AccelClass::get_stats() handler

2025-07-15 Thread Philippe Mathieu-Daudé
Factor tcg_get_stats() out of tcg_dump_stats(), passing the current accelerator argument to match the AccelClass::get_stats() prototype. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250715140048.84942-7-phi...@linaro.org> --- accel/tcg/internal-co

[PULL 09/17] Revert "accel/tcg: Unregister the RCU before exiting RR thread"

2025-07-15 Thread Philippe Mathieu-Daudé
This reverts commit bc93332fe460211c2d2f4ff50e1a0e030c7b5159, which was merged prematurely, re-introducing Coverity CID 1547782 (unreachable code). Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id

[PULL 01/17] hw/xen/arch_hvm: Unify x86 and ARM variants

2025-07-15 Thread Philippe Mathieu-Daudé
As each target declares the same prototypes, we can use a single header, removing the TARGET_XXX uses. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Stefano Stabellini Message-Id: <20250513171737.74386-1-phi...@linaro.org> --- include/hw/arm/xen_arch

[PULL 02/17] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header

2025-07-15 Thread Philippe Mathieu-Daudé
"hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and arch_xen_set_memory() prototypes, which are not used by xen-pvh.c. Remove the unnecessary header inclusion. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xiaoyao Li Reviewed-by: Manos Pitsidianakis

[PULL 06/17] accel/tcg: Do not dump NaN statistics

2025-07-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Manos Pitsidianakis Message-Id: <20250710111303.8917-1-phi...@linaro.org> --- accel/tcg/monitor.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c

Re: [PATCH-for-10.1 v6 0/8] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 16:00, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (8): Revert "accel/tcg: Unregister the RCU before exiting RR thread" accel/tcg: Extract statistic related code to tcg-stats.c accel/system: Introduce @x-accel-stats QMP command accel/system: Add '

Re: [PATCH-for-10.1] system/runstate: Document qemu_add_vm_change_state_handler_prio* in hdr

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 19:19, Philippe Mathieu-Daudé wrote: Generally APIs to the rest of QEMU should be documented in the headers. Comments on individual functions or internal details are fine to live in the C files. Make qemu_add_vm_change_state_handler_prio[_full]() docstrings consistent by moving them

Re: [PATCH-for-10.1 v7 0/2] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 11:06, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (2): qapi/machine: Add @qom-type field to CpuInfoFast structure hw/core/machine: Display CPU model name in 'info cpus' command Queued, thanks.

Re: [PATCH] accel/tcg: Do not dump NaN statistics

2025-07-15 Thread Philippe Mathieu-Daudé
On 10/7/25 13:13, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/monitor.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) Queued, thanks.

Re: [PATCH] hw/xen/arch_hvm: Unify x86 and ARM variants

2025-07-15 Thread Philippe Mathieu-Daudé
On 13/5/25 19:17, Philippe Mathieu-Daudé wrote: As each target declares the same prototypes, we can use a single header, removing the TARGET_XXX uses. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/xen_arch_hvm.h | 9 - include/hw/i386/xen_arch_hvm.h | 11

Re: [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 09:15, Philippe Mathieu-Daudé wrote: "hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and arch_xen_set_memory() prototypes, which are not used by xen-pvh.c. Remove the unnecessary header inclusion. Cc: Xiaoyao Li Signed-off-by: Philippe Mathieu-Daudé --

Re: [PATCH v5 28/69] qapi: Move definitions related to accelerators in their own file

2025-07-15 Thread Philippe Mathieu-Daudé
On 3/7/25 18:42, Philippe Mathieu-Daudé wrote: Hi Markus, On 3/7/25 12:54, Philippe Mathieu-Daudé wrote: Extract TCG and KVM definitions from machine.json to accelerator.json. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Zhao Liu ---   MAINTAINERS

Re: [PATCH 7/7] crypto: allow client/server cert chains

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 18:09, Daniel P. Berrangé wrote: On Tue, Jul 15, 2025 at 11:46:31AM +0200, Philippe Mathieu-Daudé wrote: On 15/7/25 11:29, Daniel P. Berrangé wrote: From: matoro Should we use here? I generally don't like to change the git metadata that a user submits with unless it is cl

[PATCH-for-10.1] system/runstate: Document qemu_add_vm_change_state_handler_prio* in hdr

2025-07-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20250703173248.44995-4-phi...@linaro.org> --- include/system/runstate.h | 30 ++ system/runstate.c | 30 -- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/i

[NOTFORMERGE PATCH-for-10.1 v6 8/8] linux-user: Dump TCG stats to logfile

2025-07-15 Thread Philippe Mathieu-Daudé
Running 'qemu-user -D stats.log' will dump TCG statistics to 'stats.log' before exiting. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/exit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/exit.c b/linux-user/exit.c index 1ff8fe4f072..17d2ad0517

[PATCH-for-10.1 v6 4/8] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
'info accel' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- accel/accel-system.c | 8 hmp-commands-info.hx | 12 2 files c

Re: [PATCH 2/2] cutils: Add time_us_to_str

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 14:45, Fabiano Rosas wrote: The migration code has a function that converts a time value (us) to a string with the proper suffix. Move it to cutils since it's generic enough that it could be reused. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Fabiano Rosas --- in

[PATCH-for-10.1 v6 5/8] accel/tcg: Propagate AccelState to dump_accel_info()

2025-07-15 Thread Philippe Mathieu-Daudé
y: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/internal-common.h | 2 -- include/tcg/tcg.h | 2 ++ accel/tcg/monitor.c | 1 + accel/tcg/tcg-stats.c | 5 ++--- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/accel/tcg/internal-common.h b

Re: [PATCH 1/2] migration: Fix postcopy latency distribution formatting computation

2025-07-15 Thread Philippe Mathieu-Daudé
ons(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH-for-10.1 v6 7/8] accel/hvf: Implement AccelClass::get_vcpu_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
Co-developed-by: Mads Ynddal Signed-off-by: Mads Ynddal Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/hvf/hvf-accel-ops.c | 24 1 file changed, 24 insertions(+) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index

[PATCH-for-10.1 v6 6/8] accel/tcg: Implement AccelClass::get_stats() handler

2025-07-15 Thread Philippe Mathieu-Daudé
Factor tcg_get_stats() out of tcg_dump_stats(), passing the current accelerator argument to match the AccelClass::get_stats() prototype. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/internal-common.h | 2 ++ accel/tcg/tcg-all.c | 1 + accel/tcg/tcg

[PATCH-for-10.1 v6 1/8] Revert "accel/tcg: Unregister the RCU before exiting RR thread"

2025-07-15 Thread Philippe Mathieu-Daudé
This reverts commit bc93332fe460211c2d2f4ff50e1a0e030c7b5159, which was merged prematurely, re-introducing Coverity CID 1547782 (unreachable code). Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- accel/tcg

[PATCH-for-10.1 v6 0/8] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
Since v5: - Addressed rth review comments - Added R-b tags Philippe Mathieu-Daudé (8): Revert "accel/tcg: Unregister the RCU before exiting RR thread" accel/tcg: Extract statistic related code to tcg-stats.c accel/system: Introduce @x-accel-stats QMP command accel/system: Add &

[PATCH-for-10.1 v6 3/8] accel/system: Introduce @x-accel-stats QMP command

2025-07-15 Thread Philippe Mathieu-Daudé
Unstable QMP 'x-accel-stats' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Markus Armbruster Reviewed-by: Zhao Liu --- qapi/accelerator.json | 17

[PATCH-for-10.1 v6 2/8] accel/tcg: Extract statistic related code to tcg-stats.c

2025-07-15 Thread Philippe Mathieu-Daudé
-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson --- accel/tcg/monitor.c | 201 --- accel/tcg/tcg-stats.c | 215 ++ accel/tcg/meson.build | 1 + 3 files changed, 216 insertions

Re: [PATCH-for-10.1 v5 6/7] accel/tcg: Implement get_[vcpu]_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 15:18, Richard Henderson wrote: On 7/15/25 07:06, Philippe Mathieu-Daudé wrote: On 15/7/25 14:48, Richard Henderson wrote: On 7/15/25 04:40, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson ---   accel/tcg/tcg-all.c | 6 ++   1

Re: [PATCH-for-10.1 v5 6/7] accel/tcg: Implement get_[vcpu]_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 14:48, Richard Henderson wrote: On 7/15/25 04:40, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson ---   accel/tcg/tcg-all.c | 6 ++   1 file changed, 6 insertions(+) Oh, this is what causes tcg-stats to be used by user-only

[PATCH-for-10.1 v5 7/7] accel/hvf: Implement get_vcpu_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
Co-developed-by: Mads Ynddal Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- Mads, I welcome your Signed-off-by tag on top :) --- accel/hvf/hvf-accel-ops.c | 24 1 file changed, 24 insertions(+) diff --git a/accel/hvf/hvf-accel-ops.c b/accel

[PATCH-for-10.1 v5 5/7] accel/tcg: Propagate AccelState to tcg_dump_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
Next commit will register tcg_dump_stats() as AccelClass::get_stats handler. Since we want this handler to be called with the correct accelerator state, propagate it along. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/internal-common.h | 2 +- accel/tcg/monitor.c | 3 ++- accel

Re: [PATCH-for-10.1 v5 6/7] accel/tcg: Implement get_[vcpu]_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
Maybe "accel/tcg: Implement get_stats()" is a better subject. On 15/7/25 12:40, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/tcg-all.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/accel/tcg/tcg-all

[PATCH-for-10.1 v5 0/7] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
Missing review: #1 and #5 Philippe Mathieu-Daudé (7): Revert "accel/tcg: Unregister the RCU before exiting RR thread" accel/tcg: Extract statistic related code to tcg-stats.c accel/system: Introduce @x-accel-stats QMP command accel/system: Add 'info accel' on human

[PATCH-for-10.1 v5 3/7] accel/system: Introduce @x-accel-stats QMP command

2025-07-15 Thread Philippe Mathieu-Daudé
Unstable QMP 'x-accel-stats' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Markus Armbruster Reviewed-by: Zhao Liu --- qapi/accelerator.json | 17

[PATCH-for-10.1 v5 4/7] accel/system: Add 'info accel' on human monitor

2025-07-15 Thread Philippe Mathieu-Daudé
'info accel' dispatches to the AccelOpsClass::get_stats() and get_vcpu_stats() handlers. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- accel/accel-system.c | 8 hmp-commands-info.hx | 12 2 files c

[PATCH-for-10.1 v5 2/7] accel/tcg: Extract statistic related code to tcg-stats.c

2025-07-15 Thread Philippe Mathieu-Daudé
Statistic code is not specific to system emulation (except cross-page checks) and can be used to analyze user-mode binaries. Extract statistic related code to its own file: tcg-stats.c, keeping the original LGPL-2.1-or-later license tag. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao

[PATCH-for-10.1 v5 6/7] accel/tcg: Implement get_[vcpu]_stats()

2025-07-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/tcg-all.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index eaeb465dfd5..fc3f28e3532 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -236,6

[PATCH-for-10.1 v5 1/7] Revert "accel/tcg: Unregister the RCU before exiting RR thread"

2025-07-15 Thread Philippe Mathieu-Daudé
This reverts commit bc93332fe460211c2d2f4ff50e1a0e030c7b5159, which was merged prematurely, re-introducing Coverity CID 1547782 (unreachable code). Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/tcg-accel-ops-rr.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH v5 09/11] hw/riscv: Add support for MIPS Boston-aia board model

2025-07-15 Thread Philippe Mathieu-Daudé
On 3/7/25 12:49, Djordje Todorovic wrote: The board model supports up to 64 harts with MIPS CPS, MIPS GCR, MIPS CPC, AIA plic, and AIA clint devices. The model can create boot code, if there is no -bios parameter. We can specify -smp x, cores=y,thread=z. Ex: Use 4 cores and 2 threads with each c

Re: [PATCH v5 08/11] hw/misc: Add RISC-V CMGCR and CPC device implementations

2025-07-15 Thread Philippe Mathieu-Daudé
Hi, On 3/7/25 12:49, Djordje Todorovic wrote: Add RISC-V implementations of the Coherent Manager Global Control Register (CMGCR) and Cluster Power Controller (CPC) devices. These are based on the existing MIPS CMGCR and CPC implementations but adapted for RISC-V systems. The CMGCR device provid

Re: [PATCH v5 00/11] riscv: Add support for MIPS P8700 CPU

2025-07-15 Thread Philippe Mathieu-Daudé
Hi, On 3/7/25 12:49, Djordje Todorovic wrote: In v5 of this patch set I addressed two comments: - 02/11: Moved cpu_set_exception_base from target/riscv/translate.c to target/riscv/cpu.c, and added some NULL pointer checking so the code follows the convention - 08/11: Improved git com

Re: [PATCH 7/7] crypto: allow client/server cert chains

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 11:29, Daniel P. Berrangé wrote: From: matoro Should we use here? The existing implementation assumes that client/server certificates are single individual certificates. If using publicly-issued certificates, or internal CAs that use an intermediate issuer, this is unlikely to

Re: [PATCH 22/22] vfio/pci.h: rename VFIOPCIDevice pdev field to parent_obj

2025-07-15 Thread Philippe Mathieu-Daudé
insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 14/22] vfio/pci.h: update VFIOPCIDevice declaration

2025-07-15 Thread Philippe Mathieu-Daudé
/vfio/pci.h index 495fae737d..16f092a0c6 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -132,6 +132,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOPCIDevice, VFIO_PCI_BASE) struct VFIOPCIDevice { PCIDevice pdev; + Could be squashed with #22, anyhow: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 11:42, Philippe Mathieu-Daudé wrote: On 15/7/25 11:25, Mark Cave-Ayland wrote: Update the VFIOUserPCIDevice declaration so that it is closer to our coding guidelines: add a blank line after the parent object. Signed-off-by: Mark Cave-Ayland ---   hw/vfio-user/pci.c | 1 +   1 file

Re: [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

2025-07-15 Thread Philippe Mathieu-Daudé
; Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration

2025-07-15 Thread Philippe Mathieu-Daudé
/? + SocketAddress *socket; bool send_queued; /* all sends are queued */ uint32_t wait_time; /* timeout for message replies */ Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

2025-07-15 Thread Philippe Mathieu-Daudé
(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 08/22] vfio-user/container.h: update VFIOUserContainer declaration

2025-07-15 Thread Philippe Mathieu-Daudé
-Ayland --- hw/vfio-user/container.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 07/22] vfio/vfio-container.h: rename VFIOContainer bcontainer field to parent_obj

2025-07-15 Thread Philippe Mathieu-Daudé
(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 02/22] vfio/vfio-container.h: update VFIOContainer declaration

2025-07-15 Thread Philippe Mathieu-Daudé
--- include/hw/vfio/vfio-container.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH-for-10.1 v7 2/2] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
On 15/7/25 11:30, Xiaoyao Li wrote: On 7/15/2025 5:06 PM, Philippe Mathieu-Daudé wrote: Display the CPU model in 'info cpus'. Example before:   $ qemu-system-aarch64 -M xlnx-versal-virt -S -monitor stdio   QEMU 10.0.0 monitor - type 'help' for more information   (qemu)

Re: [PATCH 5/7] crypto: remove extraneous pointer usage in gnutls certs

2025-07-15 Thread Philippe Mathieu-Daudé
deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH-for-10.1 v7 2/2] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
916 model=cortex-r5f CPU #3: thread_id=42916 model=cortex-r5f (qemu) Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Tested-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé --- hw/core/machine-hmp-cmds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/cor

[PATCH-for-10.1 v7 1/2] qapi/machine: Add @qom-type field to CpuInfoFast structure

2025-07-15 Thread Philippe Mathieu-Daudé
Knowing the QOM type name of a CPU can be useful, in particular to infer its model name. Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 3 +++ hw/core/machine-qmp-cmds.c | 1 + 2 files changed, 4 insertions(+) diff

[PATCH-for-10.1 v7 0/2] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
Since v6 [*]: - Expose QOM type name on QMP (instead of model name) (R-b tags kept) [*] https://lore.kernel.org/qemu-devel/20250703173248.44995-2-phi...@linaro.org/ Philippe Mathieu-Daudé (2): qapi/machine: Add @qom-type field to CpuInfoFast structure hw/core/machine: Display CPU model name

Re: [PATCH v6 01/39] hw/core/machine: Display CPU model name in 'info cpus' command

2025-07-15 Thread Philippe Mathieu-Daudé
On 4/7/25 06:59, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Display the CPU model in 'info cpus'. Example before: $ qemu-system-aarch64 -M xlnx-versal-virt -S -monitor stdio QEMU 10.0.0 monitor - type 'help' for more information (qemu) info cpus * CPU

[RFC PATCH 1/2] system/os-win32: Remove unused Error** argument in qemu_socket_unselect

2025-07-15 Thread Philippe Mathieu-Daudé
@errp is always NULL. Remove it, as unused. Signed-off-by: Philippe Mathieu-Daudé --- include/system/os-win32.h | 2 +- io/channel-socket.c | 4 ++-- util/oslib-win32.c| 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/system/os-win32.h b/include

[RFC PATCH 0/2] system/win32: Remove unused Error argument in qemu_socket_[un]select()

2025-07-15 Thread Philippe Mathieu-Daudé
We should use Error** more, but in this case it is always NULL so we never really care. Remove the argument... Philippe Mathieu-Daudé (2): system/os-win32: Remove unused Error** argument in qemu_socket_unselect system/os-win32: Remove unused Error** argument in qemu_socket_select

[RFC PATCH 2/2] system/os-win32: Remove unused Error** argument in qemu_socket_select

2025-07-15 Thread Philippe Mathieu-Daudé
@errp is always NULL. Remove it, as unused. Signed-off-by: Philippe Mathieu-Daudé --- include/system/os-win32.h | 2 +- util/aio-win32.c | 2 +- util/oslib-win32.c| 13 + 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/include/system/os-win32.h b

  1   2   3   4   5   6   7   8   9   10   >