Re: [PATCH] ACPI ERST: specification for ERST support

2021-10-05 Thread Ani Sinha
From: Eric DeVolder >--- > docs/specs/acpi_erst.txt | 147 +++ > 1 file changed, 147 insertions(+) > create mode 100644 docs/specs/acpi_erst.txt >

Re: Deprecate the ppc405 boards in QEMU?

2021-10-05 Thread Thomas Huth
On 05/10/2021 23.53, BALATON Zoltan wrote: [...] Maybe these 405 boards in QEMU ran with modified firmware where the memory detection was patched out I guess you're right - the code also expects a file called ppc405_rom.bin, and not u-boot.bin, so this board was likely used with a completely di

Re: [PATCH v4 05/11] hw/arm/virt: Use object_property_set instead of qdev_prop_set

2021-10-05 Thread Igor Mammedov
On Fri, 1 Oct 2021 18:33:53 +0100 Jean-Philippe Brucker wrote: > To propagate errors to the caller of the pre_plug callback, use the > object_poperty_set*() functions directly instead of the qdev_prop_set*() > helpers. > > Suggested-by: Igor Mammedov > Signed-off-by: Jean-Philippe Brucker Re

Re: [PATCH v4 04/11] hw/arm/virt: Reject instantiation of multiple IOMMUs

2021-10-05 Thread Igor Mammedov
On Fri, 1 Oct 2021 18:33:52 +0100 Jean-Philippe Brucker wrote: > We do not support instantiating multiple IOMMUs. Before adding a > virtio-iommu, check that no other IOMMU is present. This will detect > both "iommu=smmuv3" machine parameter and another virtio-iommu instance. > > Fixes: 70e89132

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Laurent Vivier
Le 05/10/2021 à 22:46, Warner Losh a écrit : > > > On Tue, Oct 5, 2021 at 2:41 PM Laurent Vivier > wrote: > > Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > > On 27/09/21 11:52, Daniel P. Berrangé wrote: > >>    bsd_user_ss.add(files('gdbstub.c')) > >

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-05 Thread Ani Sinha
On Tue, 5 Oct 2021, Laurent Vivier wrote: > On 05/10/2021 17:14, Michael S. Tsirkin wrote: > > On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > > > Failover needs to detect the end of the PCI unplug to start migration > > > after the VFIO card has been unplugged. > > > > > > To

Re: [PATCH] tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34

2021-10-05 Thread Richard Henderson
On 10/5/21 3:16 PM, Paolo Bonzini wrote: On 05/10/21 22:58, Richard Henderson wrote: For unknown and unrepeatable reasons, the cross-i386-tci test has started failing.  "Fix" this by updating the container to use fedora 34. Add sysprof-capture-devel as a new dependency of glib2-devel that was n

Re: [PATCH v2] target/ppc: Fix the test raising the decrementer exception

2021-10-05 Thread David Gibson
On Tue, Oct 05, 2021 at 07:33:24AM +0200, Cédric Le Goater wrote: > Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced > new int64t variables and broke the test triggering the decrementer > exception. Revert partially the change to evaluate both clause of the > if statement. > >

Re: [PATCH] ide: Cap LBA28 capacity announcement to 2^28-1

2021-10-05 Thread Samuel Thibault
Ping? Samuel Thibault, le mar. 24 août 2021 12:43:44 +0200, a ecrit: > The LBA28 capacity (at offsets 60/61 of identification) is supposed to > express the maximum size supported by LBA28 commands. If the device is > larger than this, we have to cap it to 2^28-1. > > At least NetBSD happens to be

Re: [PATCH] net/slirp: Use newer slirp_*_hostxfwd API

2021-10-05 Thread Samuel Thibault
Nicholas Ngai, le sam. 25 sept. 2021 16:22:02 -0700, a ecrit: > Sorry for the duplicate email. The cc’s for the maintainers on the email > didn’t go through the first time. > > Nicholas Ngai > > On 9/25/21 2:48 PM, Nicholas Ngai wrote: > > libslirp provides a newer slirp_*_hostxfwd API meant for

Re: [PULL 00/57] pc,pci,virtio: features, fixes

2021-10-05 Thread Richard Henderson
On 10/5/21 2:32 PM, Michael S. Tsirkin wrote: On Tue, Oct 05, 2021 at 10:21:43AM -0700, Richard Henderson wrote: On 10/5/21 9:00 AM, Michael S. Tsirkin wrote: The following changes since commit 9618c5badaa8eed25259cf095ff880efb939fbe7: Merge remote-tracking branch 'remotes/vivier/tags/tri

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Paolo Bonzini
On 05/10/21 22:25, Richard Henderson wrote: On 10/5/21 12:27 PM, Paolo Bonzini wrote: On 05/10/21 20:24, Alex Bennée wrote: This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes:

Re: [PATCH] tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34

2021-10-05 Thread Paolo Bonzini
On 05/10/21 22:58, Richard Henderson wrote: For unknown and unrepeatable reasons, the cross-i386-tci test has started failing. "Fix" this by updating the container to use fedora 34. Add sysprof-capture-devel as a new dependency of glib2-devel that was not correctly spelled out in the rpm rules.

Re: [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-05 Thread Michael S. Tsirkin
On Tue, Oct 05, 2021 at 12:10:08PM -0400, Eduardo Habkost wrote: > On Tue, Oct 05, 2021 at 03:01:05PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Tue, Oct 05, 2021 at 02:18:40AM +0300, Roman Kagan wrote: > > > > On Mon, Oct 04, 2021 at 11:11:00AM

Re: Deprecate the ppc405 boards in QEMU?

2021-10-05 Thread BALATON Zoltan
On Tue, 5 Oct 2021, Thomas Huth wrote: On 05/10/2021 14.17, BALATON Zoltan wrote: On Tue, 5 Oct 2021, Thomas Huth wrote: On 05/10/2021 10.07, Thomas Huth wrote: On 05/10/2021 10.05, Alexey Kardashevskiy wrote: [...] What is so special about taihu? taihu is the other 405 board defined in hw

Re: [PULL 00/12] Misc changes for 2021-10-05

2021-10-05 Thread Richard Henderson
On 10/5/21 9:43 AM, Paolo Bonzini wrote: The following changes since commit 9618c5badaa8eed25259cf095ff880efb939fbe7: Merge remote-tracking branch 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request' into staging (2021-10-04 16:27:35 -0700) are available in the Git repository at:

Re: [PULL 00/57] pc,pci,virtio: features, fixes

2021-10-05 Thread Michael S. Tsirkin
On Tue, Oct 05, 2021 at 10:21:43AM -0700, Richard Henderson wrote: > On 10/5/21 9:00 AM, Michael S. Tsirkin wrote: > > The following changes since commit 9618c5badaa8eed25259cf095ff880efb939fbe7: > > > >Merge remote-tracking branch > > 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request'

Re: [PATCH v7 3/8] qmp: add QMP command x-debug-query-virtio

2021-10-05 Thread Eric Blake
On Tue, Oct 05, 2021 at 12:45:48PM -0400, Jonah Palmer wrote: > From: Laurent Vivier > > This new command lists all the instances of VirtIODevice with > their QOM paths and virtio type/name. > > Signed-off-by: Jonah Palmer > --- > hw/virtio/meson.build | 2 ++ > hw/virtio/virtio-stub.c

Re: [PATCH v7 1/8] virtio: drop name parameter for virtio_init()

2021-10-05 Thread Eric Blake
On Tue, Oct 05, 2021 at 12:45:46PM -0400, Jonah Palmer wrote: > This patch drops the name parameter for the virtio_init function. > > The pair between the numeric device ID and the string device ID > (name) of a virtio device already exists, but not in a way that > let's us map between them. s/le

[PATCH] tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34

2021-10-05 Thread Richard Henderson
For unknown and unrepeatable reasons, the cross-i386-tci test has started failing. "Fix" this by updating the container to use fedora 34. Add sysprof-capture-devel as a new dependency of glib2-devel that was not correctly spelled out in the rpm rules. Use dnf update Just In Case -- there are pre

[RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Alex Bennée
This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.") Signed-off-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Warner Losh
On Tue, Oct 5, 2021 at 2:41 PM Laurent Vivier wrote: > Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > > On 27/09/21 11:52, Daniel P. Berrangé wrote: > >>bsd_user_ss.add(files('gdbstub.c')) > >>specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) > >> > >> > >> So without t

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Laurent Vivier
Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > On 27/09/21 11:52, Daniel P. Berrangé wrote: >>    bsd_user_ss.add(files('gdbstub.c')) >>    specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) >> >> >> So without this change, we're already correctly dropping bsd_user_ss >> in its en

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Richard Henderson
On 10/5/21 12:27 PM, Paolo Bonzini wrote: On 05/10/21 20:24, Alex Bennée wrote: This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.")

Re: [PATCH 10/13] virtiofsd: Custom threadpool for remote blocking posix locks requests

2021-10-05 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 03:54:31PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:34AM -0400, Vivek Goyal wrote: > > Add a new custom threadpool using posix threads that specifically > > service locking requests. > > > > In the case of a fcntl(SETLKW) request, if the guest is waitin

Re: [PATCH v4 11/11] tests/acpi: add expected blobs for VIOT test on q35 machine

2021-10-05 Thread Eric Auger
On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > Add expected blobs of the VIOT and DSDT table for the VIOT test on the > q35 machine. > > Since the test instantiates a virtio device and two PCIe expander > bridges, DSDT.viot has more blocks than the base DSDT (long diff not > shown here). The

Re: [PATCH v4 09/11] tests/acpi: add test cases for VIOT

2021-10-05 Thread Eric Auger
On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > Add two test cases for VIOT, one on the q35 machine and the other on > virt. To test complex topologies the q35 test has two PCIe buses that > bypass the IOMMU (and are therefore not described by VIOT), and two > buses that are translated by vir

Re: [PATCH v4 10/11] tests/acpi: add expected blob for VIOT test on virt machine

2021-10-05 Thread Eric Auger
Hi Jean, On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > The VIOT blob contains the following: > > [000h 4]Signature : "VIOT"[Virtual I/O > Translation Table] > [004h 0004 4] Table Length : 0058 > [008h 0008 1] Revision

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Paolo Bonzini
On 05/10/21 20:24, Alex Bennée wrote: This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.") Signed-off-by: Alex Bennée --- meson.bui

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Paolo Bonzini
On 05/10/21 21:00, Philippe Mathieu-Daudé wrote: On 10/5/21 20:24, Alex Bennée wrote: This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes: 46627f41b6 ("ebpf: Added eBPF RSS load

Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally

2021-10-05 Thread Philippe Mathieu-Daudé
On 10/5/21 18:45, Laurent Vivier wrote: > Le 05/10/2021 à 16:57, Michael S. Tsirkin a écrit : >> On Wed, Sep 29, 2021 at 06:31:24PM +0200, Philippe Mathieu-Daudé wrote: >>> Instead of including a sysemu-specific header in "cpu.h" >>> (which is shared with user-mode emulations), include it >>> local

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 11:52, Daniel P. Berrangé wrote: bsd_user_ss.add(files('gdbstub.c')) specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) So without this change, we're already correctly dropping bsd_user_ss in its entirity, when not on BSD. With this change, we're dropping some

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 11:54, Peter Maydell wrote: True, but "meson.build is evaluated but just does nothing or adds files to a sourceset that isn't used" is pretty common (hw/pci/meson.build is evaluated even if we're not building a system with PCI support, for example). Selection of files from hw/pci/me

Re: [PATCH v4 07/11] pc: Allow instantiating a virtio-iommu device

2021-10-05 Thread Eric Auger
Hi Jean, On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > Allow instantiating a virtio-iommu device by adding an ACPI Virtual I/O > Translation table (VIOT), which describes the relation between the > virtio-iommu and the endpoints it manages. > > Add a hotplug handler for virtio-iommu on x86 and

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 07:24, Philippe Mathieu-Daudé wrote: Why here and not in the parent meson.build? This is what Paolo recommended me to do last time I added a conditional inclusion. Personally I prefer having it in the call site rather than the callee (no need to read the callee to notice it isn't ca

[RFC PATCH 3/4] hw/scsi/scsi-generic: Use automatic AIO context lock

2021-10-05 Thread Philippe Mathieu-Daudé
Use the automatic AIO context acquire/release in scsi_command_complete(). Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 665baf900e4..08ef623c030 1006

[RFC PATCH 2/4] hw/scsi/scsi-disk: Use automatic AIO context lock

2021-10-05 Thread Philippe Mathieu-Daudé
Use the automatic AIO context acquire/release in scsi_block_realize(). Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index e8a547dbb7d..fa2d8543718 100644 -

[RFC PATCH 1/4] block/aio: Add automatically released aio_context variants

2021-10-05 Thread Philippe Mathieu-Daudé
Similarly to commit 5626f8c6d46 ("rcu: Add automatically released rcu_read_lock variants"): AIO_CONTEXT_ACQUIRE_GUARD() acquires the aio context and then uses glib's g_auto infrastructure (and thus whatever the compiler's hooks are) to release it on all exits of the block. WITH_AIO_CONTEXT_ACQUIR

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Philippe Mathieu-Daudé
On 10/5/21 20:24, Alex Bennée wrote: > This library is only needed for the softmmu targets and as such > break static *-user builds where libbpf is detected and it tries to > link it into the user binaries. > > Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.") > Signed-off-by: Alex Bennée > ---

Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

2021-10-05 Thread Richard Henderson
On 10/5/21 11:24 AM, Alex Bennée wrote: This library is only needed for the softmmu targets and as such break static *-user builds where libbpf is detected and it tries to link it into the user binaries. Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.") Signed-off-by: Alex Bennée --- meson.b

[RFC PATCH 4/4] hw/block/virtio-blk: Use automatic AIO context lock

2021-10-05 Thread Philippe Mathieu-Daudé
Use the automatic AIO context acquire/release in virtio_blk_reset(). Signed-off-by: Philippe Mathieu-Daudé --- hw/block/virtio-blk.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index f139cd7cc9c..2

[RFC PATCH 0/4] aio: AIO_CONTEXT_ACQUIRE_GUARD() macro experiment

2021-10-05 Thread Philippe Mathieu-Daudé
Experiment to use glib g_autoptr/autofree features with AIO context. Since this is a RFC, only few examples are provided. TODO: Document the macros in docs/devel/multiple-iothreads.txt Philippe Mathieu-Daudé (4): block/aio: Add automatically released aio_context variants hw/scsi/scsi-disk: Us

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell > wrote: >> On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé >> wrote: >> > Reported-by: Warner Losh >> > Signed-off-by: Philippe Mathieu-Daudé >> > --- >> > bsd-user/meson.build | 4 >> > 1 file ch

Re: [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu

2021-10-05 Thread Eric Auger
On 8/11/21 10:58 AM, Jean-Philippe Brucker wrote: > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine > parameter definitions cannot use underscores, because keyval_dashify() > transforms them to dashes and the parser doesn't find the parameter. > > This affects option defa

Re: [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu

2021-10-05 Thread Eric Auger
Hi Paolo, Peter, On 10/2/21 7:30 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> Did this series fall through the cracks for 6.1? >> >> Missed 6.1. What now? > > If I understand this correctly, it's a regression in 6.1. Paolo, please > advise on

Re: [PULL 00/57] pc,pci,virtio: features, fixes

2021-10-05 Thread Richard Henderson
On 10/5/21 9:00 AM, Michael S. Tsirkin wrote: The following changes since commit 9618c5badaa8eed25259cf095ff880efb939fbe7: Merge remote-tracking branch 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request' into staging (2021-10-04 16:27:35 -0700) are available in the Git repository at:

[PATCH v7 3/8] qmp: add QMP command x-debug-query-virtio

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++ hw/virtio/virtio.c | 27 +++ include/

[PATCH v7 5/8] qmp: decode feature & status bits in virtio-status

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice. Display feature names instead of bitmaps for backend, protocol, acked, and features (hdev->features) for vhost devices. Decode

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-10-05 Thread Kevin Wolf
Am 05.10.2021 um 15:49 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 02.10.2021 um 15:33 hat Markus Armbruster geschrieben: > >> I apologize for this wall of text. It's a desparate attempt to cut > >> through the complexity and my confusion, and make sense of the actual > >> p

Re: [PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu

2021-10-05 Thread Eric Auger
On 8/11/21 10:58 AM, Jean-Philippe Brucker wrote: > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine > parameter definitions cannot use underscores, because keyval_dashify() > transforms them to dashes and the parser doesn't find the parameter. > > This affects option defa

[PATCH v7 1/8] virtio: drop name parameter for virtio_init()

2021-10-05 Thread Jonah Palmer
This patch drops the name parameter for the virtio_init function. The pair between the numeric device ID and the string device ID (name) of a virtio device already exists, but not in a way that let's us map between them. This patch will let us do this and removes the need for the name parameter i

[PULL 06/12] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread

2021-10-05 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito init_dirty_bitmap_migration assumes the iothread lock (BQL) to be held, but instead it isn't. Instead of adding the lock to qemu_savevm_state_setup(), follow the same pattern as the other ->save_setup callbacks and lock+unlock inside dirty_bitmap_save_setup(). S

[PATCH v7 6/8] qmp: add QMP commands for virtio/vhost queue-status

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 +++ qapi/virtio.json| 262 +

Re: [PATCH 1/2] block/backup: avoid integer overflow of `max-workers`

2021-10-05 Thread Vladimir Sementsov-Ogievskiy
10/5/21 19:11, Stefano Garzarella wrote: QAPI generates `struct BackupPerf` where `max-workers` value is stored in an `int64_t` variable. But block_copy_async(), and the underlying code, uses an `int` parameter. At the end that variable is used to initialize `max_busy_tasks` in block/aio_task.c

[PATCH v7 4/8] qmp: add QMP command x-debug-virtio-status

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature bits (backend, protocol, acked, and features). Also will decode status

[PATCH v7 8/8] hmp: add virtio commands

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp-commands.hx | 10 ++ hw/virtio/virtio.c | 355 +++

Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally

2021-10-05 Thread Laurent Vivier
Le 05/10/2021 à 16:57, Michael S. Tsirkin a écrit : > On Wed, Sep 29, 2021 at 06:31:24PM +0200, Philippe Mathieu-Daudé wrote: >> Instead of including a sysemu-specific header in "cpu.h" >> (which is shared with user-mode emulations), include it >> locally when required. >> >> Acked-by: Paolo Bonzin

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-05 Thread Kevin Wolf
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben: > > > On 10/5/21 16:37, Kevin Wolf wrote: > > Am 27.09.2021 um 13:39 hat Kevin Wolf geschrieben: > > > Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: > > > > On 9/24/21 11:04, Kevin Wolf wrote: > > > > > Directly call qdev_device_add_from

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-05 Thread Philippe Mathieu-Daudé
On 10/5/21 10:49, Daniel P. Berrangé wrote: > On Tue, Oct 05, 2021 at 06:44:23AM +0200, Christophe Leroy wrote: >> I will look at it, please allow me a few weeks though. > > Once something is deprecated, it remains in QEMU for a minimum of two > release cycles, before being deleted. At any time i

[PATCH v7 7/8] qmp: add QMP command x-debug-virtio-queue-element

2021-10-05 Thread Jonah Palmer
From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 ++ qapi/virtio.json| 191 +++

[PULL 09/12] meson: switch minimum meson version to 0.58.2, minimum recommended to 0.59.2

2021-10-05 Thread Paolo Bonzini
Meson 0.58.2 does not need b_staticpic=$pie anymore, and has stabilized the keyval module. Remove the workaround and use a few replacements for features deprecated in the 0.57.0 release cycle. One feature that we would like to use is passing dependencies to summary. However, that was broken in 0

[PATCH 1/2] block/backup: avoid integer overflow of `max-workers`

2021-10-05 Thread Stefano Garzarella
QAPI generates `struct BackupPerf` where `max-workers` value is stored in an `int64_t` variable. But block_copy_async(), and the underlying code, uses an `int` parameter. At the end that variable is used to initialize `max_busy_tasks` in block/aio_task.c causing the following assertion failure if

Re: [Virtio-fs] [PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list

2021-10-05 Thread Vivek Goyal
On Tue, Oct 05, 2021 at 04:50:43PM +0100, Stefan Hajnoczi wrote: > On Tue, Oct 05, 2021 at 11:16:18AM -0400, Vivek Goyal wrote: > > On Tue, Oct 05, 2021 at 01:22:58PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 30, 2021 at 11:30:37AM -0400, Vivek Goyal wrote: > > > > g_usleep() calls nanosleep(

[PATCH v7 0/8] hmp,qmp: Add commands to introspect virtio devices

2021-10-05 Thread Jonah Palmer
This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from July (v6). Original patches are from Laurent Vivier from May 2020. Rebase from v6 to v7 includes adding ability to map between the numeric device ID an

[PULL 02/12] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-10-05 Thread Paolo Bonzini
From: Dov Murik Add the sev_add_kernel_loader_hashes function to calculate the hashes of the kernel/initrd/cmdline and fill a designated OVMF encrypted hash table area. For this to work, OVMF must support an encrypted area to place the data which is advertised via a special GUID in the OVMF rese

[PATCH 0/2] block: avoid integer overflow of `max-workers` and assert `max_busy_tasks`

2021-10-05 Thread Stefano Garzarella
This series contains a patch that avoids an integer overflow of `max-workers` (struct BackupPerf) by adding a check and a patch that asserts this condition where the problem occurs. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310 Signed-off-by: Stefano Garzarella Stefano Garzarella

[PULL 01/12] i386: docs: Briefly describe KVM PV features

2021-10-05 Thread Paolo Bonzini
From: Vitaly Kuznetsov KVM PV features don't seem to be documented anywhere, in particular, the fact that some of the features are enabled by default and some are not can only be figured out from the code. Signed-off-by: Vitaly Kuznetsov Message-Id: <20211004140445.624875-1-vkuzn...@redhat.com>

[PATCH v7 2/8] virtio: add vhost support for virtio devices

2021-10-05 Thread Jonah Palmer
This patch adds a get_vhost() callback function for VirtIODevices that returns the device's corresponding vhost_dev structure if the vhost device is running. This patch also adds a vhost_started flag for VirtIODevices. Previously, a VirtIODevice wouldn't be able to tell if its corresponding vhost

Re: [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-05 Thread Eduardo Habkost
On Tue, Oct 05, 2021 at 03:01:05PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Tue, Oct 05, 2021 at 02:18:40AM +0300, Roman Kagan wrote: > > > On Mon, Oct 04, 2021 at 11:11:00AM -0400, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2021 at 06:07:29

[PULL 03/12] x86/sev: generate SEV kernel loader hashes in x86_load_linux

2021-10-05 Thread Paolo Bonzini
From: Dov Murik If SEV is enabled and a kernel is passed via -kernel, pass the hashes of kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV measured boot. Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé Me

[PULL 12/12] meson: show library versions in the summary

2021-10-05 Thread Paolo Bonzini
Meson 0.57 allows passing external programs and dependency objects to summary(). Use this to show library versions and paths in the summary. Signed-off-by: Paolo Bonzini --- meson.build | 112 +--- 1 file changed, 54 insertions(+), 58 deletions(-)

[PULL 33/57] acpi: build_waet: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Message-Id: <20210924122802.1455362-20-imamm...@redhat.com> Revi

[PULL 10/12] hexagon: use env keyword argument to pass PYTHONPATH

2021-10-05 Thread Paolo Bonzini
This feature is new in meson 0.57 and allows getting rid of the "env" wrapper. Signed-off-by: Paolo Bonzini --- target/hexagon/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build index 6fd9360b74..c6d858ffb2 10

[PULL 00/12] Misc changes for 2021-10-05

2021-10-05 Thread Paolo Bonzini
The following changes since commit 9618c5badaa8eed25259cf095ff880efb939fbe7: Merge remote-tracking branch 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request' into staging (2021-10-04 16:27:35 -0700) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-

[PULL 27/57] acpi: x86: build_dsdt: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Message-Id: <20210924122802.1455362-14-imamm...@redhat.com> Revi

[PULL 07/12] migration: add missing qemu_mutex_lock_iothread in migration_completion

2021-10-05 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito qemu_savevm_state_complete_postcopy assumes the iothread lock (BQL) to be held, but instead it isn't. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Dr. David Alan Gilbert Message-Id: <20211005080751.3797161-3-eespo...@redhat.com> Signed-off-by: Paolo B

Re: [PATCH v6 05/10] ACPI ERST: support for ACPI ERST feature

2021-10-05 Thread Eric DeVolder
Igor, again thanks for the detailed review. Inline responses below. eric On 10/5/21 6:39 AM, Igor Mammedov wrote: On Mon, 4 Oct 2021 16:13:09 -0500 Eric DeVolder wrote: Igor, thanks for the close examination. Inline responses below. eric On 9/21/21 10:30 AM, Igor Mammedov wrote: On Thu, 5

[PULL 55/57] hw/i386/amd_iommu: Rename amdviPCI TypeInfo

2021-10-05 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Per 'QEMU Coding Style': Naming == Variables are lower_case_with_underscores; easy to type and read. Rename amdviPCI variable as amdvi_pci. amdviPCI_register_types() register more than PCI types: TYPE_AMD_IOMMU_DEVICE inherits TYPE_X86_IOMMU_DEVICE which

[PULL 08/12] meson: bump submodule to 0.59.2

2021-10-05 Thread Paolo Bonzini
The update to 0.57 has been delayed due to it causing warnings for some actual issues, but it brings in important bugfixes and new features. 0.58 also brings in a bugfix that is useful for modinfo. Important bugfixes: - 0.57: https://github.com/mesonbuild/meson/pull/7760, build: use PIE objects

[PULL 53/57] virtio-balloon: Fix page-poison subsection name

2021-10-05 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" The subsection name for page-poison was typo'd as: vitio-balloon-device/page-poison Note the missing 'r' in virtio. When we have a machine type that enables page poison, and the guest enables it (which needs a new kernel), things fail rather unpredictably. The

[PULL 05/12] configure, meson: move CPU_CFLAGS out of QEMU_CFLAGS

2021-10-05 Thread Paolo Bonzini
Flags that choose the target architecture, such as -m32 on x86, affect all invocations of the compiler driver, for example including options such as --print-search-dirs. To ensure that they are treated as such, place them in the cross file in the [binaries] section instead of including them in QEM

[PULL 11/12] target/xtensa: list cores in a text file

2021-10-05 Thread Paolo Bonzini
Avoid that leftover files affect the build; instead, use the same mechanism that was in place before the Meson transition of updating a file from import_core.sh. Starting with Meson 0.57, the file can be easily read from the filesystem module, so do that instead of using run_command. Signed-off-b

[PULL 49/57] acpi: AcpiGenericAddress no longer used to map/access fields of MMIO, drop packed attribute

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Message-Id: <20210924122802.1455362-36-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/acpi-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PULL 04/12] hw/misc: applesmc: use host osk as default on macs

2021-10-05 Thread Paolo Bonzini
From: Pedro Tôrres When running on a Mac, QEMU is able to get the host OSK and use it as the default value for the AppleSMC device. The OSK query operation doesn't require administrator privileges and can be executed by any user on the system. This patch is based on open-source code from Apple,

Re: [RFC PATCH v2 03/25] block/block-backend.c: assertions for block-backend

2021-10-05 Thread Eric Blake
On Tue, Oct 05, 2021 at 10:31:53AM -0400, Emanuele Giuseppe Esposito wrote: > All the global state (GS) API functions will check that > qemu_in_main_thread() returns true. If not, it means > that the safety of BQL cannot be guaranteed, and > they need to be moved to I/O. > > Signed-off-by: Emanuel

[PULL 46/57] acpi: arm/virt: build_gtdt: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. while at it, replace packed structure with endian agnostic build_append_FOO() API. Signed-off-by: Igor Mammedov Revie

Re: [PATCH 0/2] block: avoid integer overflow of `max-workers` and assert `max_busy_tasks`

2021-10-05 Thread Vladimir Sementsov-Ogievskiy
10/5/21 19:11, Stefano Garzarella wrote: This series contains a patch that avoids an integer overflow of `max-workers` (struct BackupPerf) by adding a check and a patch that asserts this condition where the problem occurs. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310 Signed-off-b

[PULL 06/57] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *

2021-10-05 Thread Michael S. Tsirkin
From: Jason Wang This patch switches to let net_vhost_vdpa_init() to return NetClientState *. This is used for the callers to allocate multiqueue NetClientState for multiqueue support. Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-5-jasow...@redhat.com> Reviewed-by: Michael S. Tsir

Re: [PATCH 2/2] block/aio_task: assert `max_busy_tasks` is greater than 0

2021-10-05 Thread Vladimir Sementsov-Ogievskiy
10/5/21 19:11, Stefano Garzarella wrote: All code in block/aio_task.c expects `max_busy_tasks` to always be greater than 0. Assert this condition during the AioTaskPool creation where `max_busy_tasks` is set. Signed-off-by: Stefano Garzarella Reviewed-by: Vladimir Sementsov-Ogievskiy -- Be

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

2021-10-05 Thread Christian Schoenebeck
On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote: > On Tue, Oct 05, 2021 at 03:15:26PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 5. Oktober 2021 14:45:56 CEST Stefan Hajnoczi wrote: > > > On Mon, Oct 04, 2021 at 09:38:04PM +0200, Christian Schoenebeck wrote: > > > > Refac

[PULL 44/57] acpi: arm/virt: build_spcr: fix invalid cast

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov implicit cast to structure uint8_t member didn't raise error when assigning value from incorrect enum, but when using build_append_gas() (next patch) it will error out with (clang): implicit conversion from enumeration type 'AmlRegionSpace' to different enumeration type 'A

[PULL 01/57] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all()

2021-10-05 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé vring_get_region_caches() must be called with the RCU read lock acquired. virtqueue_packed_drop_all() does not, and uses the 'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD() macro. Reported-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daudé M

Re: In-tree docs vs. Wiki [Was: Re: [PATCH 0/3] rSTify SubmitAPatch, TrivialPatches, and SpellCheck wiki pages]

2021-10-05 Thread Philippe Mathieu-Daudé
On 10/5/21 18:03, Kashyap Chamarthy wrote: > On Tue, Oct 05, 2021 at 04:37:50PM +0100, Daniel P. Berrangé wrote: >> On Tue, Oct 05, 2021 at 05:07:06PM +0200, Philippe Mathieu-Daudé wrote: > > [...] > >>> One point Peter raised on IRC is it is easier to update a Wiki page >>> than get a patch merg

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-05 Thread Daniel P . Berrangé
On Tue, Oct 05, 2021 at 06:15:35PM +0200, Philippe Mathieu-Daudé wrote: > On 10/5/21 10:49, Daniel P. Berrangé wrote: > > On Tue, Oct 05, 2021 at 06:44:23AM +0200, Christophe Leroy wrote: > > >> I will look at it, please allow me a few weeks though. > > > > Once something is deprecated, it remain

[PULL 43/57] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov Drop usage of packed structures and explicit endian conversions when building IORT table use endian agnostic build_append_int_noprefix() API to build it. Signed-off-by: Igor Mammedov Message-Id: <20210924122802.1455362-30-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin

[PULL 52/57] bios-tables-test: Update ACPI DSDT table golden blobs for q35

2021-10-05 Thread Michael S. Tsirkin
From: Ani Sinha We have modified the IO address range for ACPI pci hotplug in q35. See change: 5adcc9e39e6a5 ("hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35") The ACPI DSDT table golden blobs must be regenrated in order to make the unit tests pass. This change upd

[PATCH 2/2] block/aio_task: assert `max_busy_tasks` is greater than 0

2021-10-05 Thread Stefano Garzarella
All code in block/aio_task.c expects `max_busy_tasks` to always be greater than 0. Assert this condition during the AioTaskPool creation where `max_busy_tasks` is set. Signed-off-by: Stefano Garzarella --- block/aio_task.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/aio_task.c b

[PULL 54/57] nvdimm: release the correct device list

2021-10-05 Thread Michael S. Tsirkin
From: Li Zhijian Signed-off-by: Li Zhijian Message-Id: <20210624110415.187164-1-lizhij...@cn.fujitsu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PULL 39/57] acpi: arm/virt: madt: use build_append_int_noprefix() API to compose MADT table

2021-10-05 Thread Michael S. Tsirkin
From: Igor Mammedov Drop usage of packed structures and explicit endian conversions when building MADT table for arm/x86 and use endian agnostic build_append_int_noprefix() API to build it. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Message-Id: <20210924122802.1455362-26-imamm...@red

[PULL 50/57] bios-tables-test: allow changes in DSDT ACPI tables for q35

2021-10-05 Thread Michael S. Tsirkin
From: Ani Sinha We are going to commit a change to fix IO address range allocated for acpi pci hotplug in q35. This affects DSDT tables. This change allows DSDT table modification so that unit tests are not broken. Signed-off-by: Ani Sinha Acked-by: Igor Mammedov Message-Id: <20210916132838.34

  1   2   3   4   >