On 27/09/21 07:24, Philippe Mathieu-Daudé wrote:
Why here and not in the parent meson.build?
This is what Paolo recommended me to do last time I added a
conditional inclusion.

Personally I prefer having it in the call site rather than
the callee (no need to read the callee to notice it isn't
called). I guess this is for readability, to not clutter
meson.build? files more...

Yes, pretty much. In this case it's quite obvious that bsd-user is BSD-only, but I prefer it if dir/meson.build has the knowledge of what goes on in dir/.

That said, we're not terribly consistent, see have_block and have_tools, so either will be okay.

Paolo

Paolo, what is your preference?



Reply via email to