On 27/09/21 11:52, Daniel P. Berrangé wrote:
bsd_user_ss.add(files('gdbstub.c'))
specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
So without this change, we're already correctly dropping bsd_user_ss
in its entirity, when not on BSD.
With this change, we're dropping some, but not all, of bsd_user_ss
files - gdbstub.c remains.
So this change on its own doesn't make a whole lot of sense.
Agreed; that said, the gdbstub.c files added by
bsd_user_ss.add(files('gdbstub.c'))
linux_user_ss.add(files('gdbstub.c', 'thunk.c'))
are unnecessary because there is already
specific_ss.add(files('cpu.c', 'disas.c', 'gdbstub.c'), capstone)
So, with those two instances of gdbstub.c removed, both patches are
Acked-by: Paolo Bonzini <[email protected]>
Thanks,
Paolo
