Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Paolo Bonzini
On 01/04/2016 22:05, Kevin O'Connor wrote: > > I looked closer at your setup and it appears the SeaBIOS virtio-scsi > driver is very slow because it does a full search of all 256 possible > scsi targets. This full scan takes a lot of time. I put together a > quick patch (see below) to stop the

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-04-01 Thread John Snow
On 04/01/2016 10:32 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Restart of ATAPI DMA used to be unreachable, because the request to do > so wasn't indicated in bus->error_status due to the lack of spare bits, and > ide_restart_bh() would return early doing nothing. > > This patch make

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 09:46:05PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 04:05:46PM -0400, Kevin O'Connor wrote: > > On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > > > On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote: > > > > > +# general st

Re: [Qemu-devel] [PATCH] doc: Flip bit sense for allowing trim during WRITE_ZEROES

2016-04-01 Thread Alex Bligh
On 1 Apr 2016, at 22:29, Eric Blake wrote: > Rather than requiring allocation by default and allowing trims > only on request during WRITE_ZEROES, it seems like a better > default is to allow server optimizations by default and require > full allocation by specific request. Since WRITE_ZEROES i

Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_order[]

2016-04-01 Thread Aurelien Jarno
On 2016-04-01 15:49, James Hogan wrote: > The MIPS TCG backend is the only one to have > tcg_target_reg_alloc_order[] elements of type TCGReg rather than int. > This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base > temporaries in a different order") breaking the build on MIPS since t

[Qemu-devel] [PATCH] doc: Flip bit sense for allowing trim during WRITE_ZEROES

2016-04-01 Thread Eric Blake
Rather than requiring allocation by default and allowing trims only on request during WRITE_ZEROES, it seems like a better default is to allow server optimizations by default and require full allocation by specific request. Since WRITE_ZEROES is experimental and has not yet been implemented, we ca

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Move away from anglo-centricity

2016-04-01 Thread John Snow
On 04/01/2016 10:50 AM, Max Reitz wrote: > In its organizational structure, the qemu project is rather > decentralized: Many different maintainers manage their own more or less > secluded subsystems. However, regarding languages, it is still rather > anglo-centric. > > This issue has been brough

Re: [Qemu-devel] [PATCH 2/3] ide: restart atapi dma by re-evaluating command packet

2016-04-01 Thread John Snow
On 04/01/2016 10:32 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > ide_atapi_dma_restart() used to just complete the DMA with an error, > under the assumption that there isn't enough information to restart it. > > However, as the contents of the ->io_buffer is preserved, it looks safe to

Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!

2016-04-01 Thread KY Srinivasan
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, April 1, 2016 1:18 AM > To: qemu-devel@nongnu.org > Cc: Andreas Färber ; Alex Williamson > ; Denis V. Lunev ; > Eduardo Habkost ; Roman Kagan > ; KY Srinivasan > Subje

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 04:05:46PM -0400, Kevin O'Connor wrote: > On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote: > > > > +# general stuff > > > > +CONFIG_QEMU=y > > > > +CONFIG_ROM_SIZE=128 > > > > > > Why for

Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_order[]

2016-04-01 Thread Richard Henderson
On 04/01/2016 07:49 AM, James Hogan wrote: The MIPS TCG backend is the only one to have tcg_target_reg_alloc_order[] elements of type TCGReg rather than int. This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different order") breaking the build on MIPS since the

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

2016-04-01 Thread Pranith Kumar
Hi Alex, I have one question inline below. Alex Bennée writes: > The __atomic primitives have been available since GCC 4.7 and provide > a richer interface for describing memory ordering requirements. As a > bonus by using the primitives instead of hand-rolled functions we can > use tools such

Re: [Qemu-devel] [PATCH 10/18] vhost-user: add slave-fd support

2016-04-01 Thread Eric Blake
On 04/01/2016 05:16 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn to give a socket to the slave to let him make requests to the > master. > > Signed-off-by: Marc-André Lureau > --- > docs/specs/vhost-user.txt | 23 > hw/virtio/vhost-user.c| 69

Re: [Qemu-devel] [PATCH 01/18 for-2.6] tests: append i386 tests

2016-04-01 Thread Eric Blake
On 04/01/2016 05:16 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not overwrite x86-64 tests, re-enable vhost-user-test. > > Signed-off-by: Marc-André Lureau > --- > tests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This one should go in 2.6. Re

Re: [Qemu-devel] [Nbd] [PATCH v2 1/1] NBD proto: add WRITE_ZEROES extension

2016-04-01 Thread Eric Blake
On 04/01/2016 02:37 AM, Wouter Verhelst wrote: > Hi, > > Thanks, applied. > > On Thu, Mar 31, 2016 at 04:02:05PM +0300, Denis V. Lunev wrote: >> From: Pavel Borzenkov >> >> There exist some cases when a client knows that the data it is going to >> write is all zeroes. Such cases include mirrorin

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 03:44:14PM -0400, Kevin O'Connor wrote: [...] I ran all the tests again, but this time I ran the test program 3 times (so 30 passes for each setting). As you can see from the results below the test is not very stable, so that could easily have accounted for the variation I

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote: > > > +# general stuff > > > +CONFIG_QEMU=y > > > +CONFIG_ROM_SIZE=128 > > > > Why force a size of 128K - I would think 64K would be fine. > > Agreed. Setting thi

Re: [Qemu-devel] [PATCH] doc: Cleanups to structured reads

2016-04-01 Thread Alex Bligh
On 1 Apr 2016, at 20:39, Eric Blake wrote: > A couple of typos, odd formatting, and missing words made it into > the structured read spec, and several potential ambiguous situations > were worth rewording for clarity. > > Signed-off-by: Eric Blake > Signed-off-by: Alex Bligh Reviewed-by: Ale

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 08:15:29PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 08:10:48PM +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote: > > > Otherwise, it doesn't make > > > sense that disabling CONFIG_BOOTORDER=n would change t

[Qemu-devel] [PATCH] doc: Cleanups to structured reads

2016-04-01 Thread Eric Blake
A couple of typos, odd formatting, and missing words made it into the structured read spec, and several potential ambiguous situations were worth rewording for clarity. Signed-off-by: Eric Blake Signed-off-by: Alex Bligh --- doc/proto.md | 112 +++

Re: [Qemu-devel] [Nbd] [PATCH] doc/proto.md: restore formatting

2016-04-01 Thread Eric Blake
On 04/01/2016 07:30 AM, Eric Blake wrote: > On 04/01/2016 04:34 AM, Alex Bligh wrote: >> Restore formatting and correct name of 'length' >> >> Signed-off-by: Alex Bligh >> --- >> doc/proto.md | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake I've folded t

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 08:10:48PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote: > > Otherwise, it doesn't make > > sense that disabling CONFIG_BOOTORDER=n would change the boot time. > > Could it be explained by it avoiding slow access to qemu

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote: > On Fri, Apr 01, 2016 at 07:59:02PM +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > > > Below are some benchmarks of the other things you mentioned. These > > > are complete

Re: [Qemu-devel] [PATCH 2/2] target-mips: Implement IEEE 754-2008 functionality for R6 and MSA instructions

2016-04-01 Thread Leon Alrae
On 25/03/16 12:50, Aleksandar Markovic wrote: > +#define MSA_CLASS_SIGNALING_NAN 0x001 > +#define MSA_CLASS_QUIET_NAN 0x002 > +#define MSA_CLASS_NEGATIVE_INFINITY 0x004 > +#define MSA_CLASS_NEGATIVE_NORMAL0x008 > +#define MSA_CLASS_NEGATIVE_SUBNORMAL 0x010 > +#define MSA_CLASS_NE

[Qemu-devel] [PATCH v4] bios: Add fast variant of SeaBIOS for use with -kernel on x86.

2016-04-01 Thread Richard W.M. Jones
The previous version was posted and discussed on this thread: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/threads.html#00013 Since v3: - CONFIG_ROM_SIZE=0 (it chooses 64K automatically) - CONFIG_RELOCATE_INIT=n - CONFIG_BOOTORDER=n Knocks another 10ms off the boot time. Ric

[Qemu-devel] [PATCH v4] bios: Add fast variant of SeaBIOS for use with -kernel on x86.

2016-04-01 Thread Richard W.M. Jones
This commit adds a fast variant of SeaBIOS called 'bios-fast.bin'. It's designed to be the fastest (also the smallest, but that's not the main aim) SeaBIOS that is just enough to boot a Linux kernel using the -kernel option on i686 and x86_64. This commit does not modify the -kernel option to use

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 07:59:02PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > > Below are some benchmarks of the other things you mentioned. These > > are complete appliance boot-to-shutdown times [*not* just SeaBIOS]. > > All debugging

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

2016-04-01 Thread Leon Alrae
On 25/03/16 12:50, Aleksandar Markovic wrote: > > /* > | The pattern for a default generated single-precision NaN. > > **/ > +float32 float32_

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > Below are some benchmarks of the other things you mentioned. These > are complete appliance boot-to-shutdown times [*not* just SeaBIOS]. > All debugging has been disabled, and I'm using a slightly different > kernel version, so

Re: [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows

2016-04-01 Thread Stefan Berger
On 03/31/2016 10:07 AM, Igor Mammedov wrote: On Thu, 31 Mar 2016 00:03:57 -0400 Stefan Berger wrote: On 03/30/2016 09:33 AM, Igor Mammedov wrote: On Mon, 21 Mar 2016 10:21:11 -0400 Stefan Berger wrote: This patch addresses BZ 1281413. Fix the APCI description to make it work on Windows ag

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote: > > +# general stuff > > +CONFIG_QEMU=y > > +CONFIG_ROM_SIZE=128 > > Why force a size of 128K - I would think 64K would be fine. Agreed. Setting this to =0 seems the best thing, and it does fit fine inside 64K. > > +# no input, no

[Qemu-devel] [V8 3/4] hw/core: Add AMD IOMMU to machine properties

2016-04-01 Thread David Kiarie
Added a bool, subject to review to machine properties which it used to override iommu emulated from Intel to AMD. Signed-off-by: David Kiarie --- hw/core/machine.c | 32 +--- include/hw/boards.h | 1 + qemu-options.hx | 7 +-- util/qemu-config.c | 8

[Qemu-devel] [V8 1/4] hw/i386: Introduce AMD IOMMU

2016-04-01 Thread David Kiarie
Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU The IOMMU does basic translation, error checking and has a minimal IOTLB implementation Signed-off-by: David Kiarie --- hw/i386/Makefile.objs |1 + hw/i386/amd_iommu.c | 1426 + hw/i38

[Qemu-devel] [V8 4/4] hw/pci-host: Emulate AMD IOMMU

2016-04-01 Thread David Kiarie
Add AMD IOMMU emulation support to q35 chipset Signed-off-by: David Kiarie --- hw/pci-host/q35.c | 21 +++-- include/hw/i386/intel_iommu.h | 1 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 70f897e..37f8

[Qemu-devel] [V8 2/4] hw/i386: ACPI table for AMD IOMMU

2016-04-01 Thread David Kiarie
Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 98 ++- include/hw/acpi/acpi-defs.h | 55 include/hw/i386/intel_iommu.h | 1 + 3 fil

[Qemu-devel] [V8 0/4] AMD IOMMU

2016-04-01 Thread David Kiarie
Hello all, Long time no see, at usual ;) AMD IOMMU patches fixing a few issues mentioned in previous version, formatting errors and commit messages David Kiarie (4): hw/i386: Introduce AMD IOMMU hw/i386: ACPI table for AMD IOMMU hw/core: Add AMD IOMMU to machine properties hw/pci-host:

[Qemu-devel] efi var store migration assert (bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed.)

2016-04-01 Thread Dr. David Alan Gilbert
In the continuing journeys of trying to migrate a q35 guest with ovmf, I've just hit this assert: qemu-system-x86_64: /root/git/qemu/block/io.c:1297: bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. This is just ahead of rc0 - 1458317c8ada834cf39287f6d11a8cb8a37360d6 from yest

Re: [Qemu-devel] [PATCH] block: Move away from anglo-centricity

2016-04-01 Thread Christian Borntraeger
On 04/01/2016 04:50 PM, Max Reitz wrote: > In its organizational structure, the qemu project is rather > decentralized: Many different maintainers manage their own more or less > secluded subsystems. However, regarding languages, it is still rather > anglo-centric. > > This issue has been brought

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

2016-04-01 Thread Olaf Hering
On Fri, Apr 01, Max Reitz wrote: > In any case, do you have a test case where a guest was able to submit a > request that led to the overflow error you described in the commit message? mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing device. When I added discard support to libxl I work

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

2016-04-01 Thread Max Reitz
On 01.04.2016 14:22, Olaf Hering wrote: > Large discard requests lead to sign expansion errors in qemu. > Since there is no API to tell a guest about the limitations qmeu > has to split a large request itself. > > Signed-off-by: Olaf Hering > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > --- > block/

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2016-04-01 Thread Serge Hallyn
Hi, I've redeployed my test box with 14.04 with kilo-staging archive, but i get a core dump when i try to run kvm the same way you did. Can you show your /etc/apt/sources.list and /etc/apt/sources.list.d, as well as output for uname -a dpkg -l | egrep -e '(qemu|linux|bios)' -- You received thi

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.5.1 Stable released

2016-04-01 Thread Peter Lieven
> Am 01.04.2016 um 16:53 schrieb Michael Roth : > > Quoting Peter Lieven (2016-04-01 02:43:31) >>> Am 30.03.2016 um 02:11 schrieb Michael Roth: >>> Hi everyone, >>> >>> I am pleased to announce that the QEMU v2.5.1 stable release is now >>> available at: >>> >>> http://wiki.qemu.org/download/

Re: [Qemu-devel] q35 migration broken

2016-04-01 Thread Marcel Apfelbaum
On 04/01/2016 08:01 PM, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (mar...@redhat.com) wrote: On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: Hi, I'm seeing a breakage on

Re: [Qemu-devel] q35 migration broken

2016-04-01 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote: > >* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >>* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >>>Hi, > >>> I'm seeing a breakage on q35 migration on head (and possibly olde

Re: [Qemu-devel] q35 migration broken

2016-04-01 Thread Marcel Apfelbaum
On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: Hi, I'm seeing a breakage on q35 migration on head (and possibly older but certainly head; it's also on a 2.5.0 world I've got wit

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6] crypto: Avoid memory leak on failure

2016-04-01 Thread Max Reitz
On 01.04.2016 17:57, Eric Blake wrote: > Commit 7836857 introduced a memory leak due to invalid use of > Error vs. visit_type_end(). If visiting the intermediate > members fails, we clear the error and unconditionally use > visit_end_struct() on the same error object; but if that > cleanup succeed

[Qemu-devel] [PATCH for-2.6] nbd: don't request FUA on FLUSH

2016-04-01 Thread Eric Blake
The NBD protocol does not clearly document what will happen if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH. Historically, both the qemu and upstream NBD servers silently ignored that flag, but that feels a bit risky. Meanwhile, the qemu NBD client unconditionally sends the flag (without even

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

2016-04-01 Thread Alex Bennée
James Hogan writes: > Hi Alex, > > On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote: >> The __atomic primitives have been available since GCC 4.7 and provide >> a richer interface for describing memory ordering requirements. As a >> bonus by using the primitives instead of hand-rolled

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Paolo Bonzini
On 01/04/2016 17:35, Kevin O'Connor wrote: > It's possible to build a third binary, but that seems like it would be > a bit annoying for distributions. I don't think that would be a problem. Fedora is already building 4 binaries (128k, 256k, CSM, coreboot), adding a fifth is not a big deal. Pa

Re: [Qemu-devel] [PATCH] block: Move away from anglo-centricity

2016-04-01 Thread Paolo Bonzini
On 01/04/2016 16:50, Max Reitz wrote: > Signed-off-by: Max Reitz Du hast zu viel freie Zeit. Paolo ps: given the latest news about AI, I hope Google Translate is not insulting any family member of yours, or worse. pps: the LibreOffice is looking for people translating comments from German to

[Qemu-devel] [PATCH for-2.6] crypto: Avoid memory leak on failure

2016-04-01 Thread Eric Blake
Commit 7836857 introduced a memory leak due to invalid use of Error vs. visit_type_end(). If visiting the intermediate members fails, we clear the error and unconditionally use visit_end_struct() on the same error object; but if that cleanup succeeds, we then skip the qapi_free call. Until a late

Re: [Qemu-devel] q35 migration broken

2016-04-01 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > Hi, > > I'm seeing a breakage on q35 migration on head (and possibly older > > but certainly head; it's also on a 2.5.0 world I've got with a bunch > > of patches but I've not tried a

[Qemu-devel] [PULL] slirp: Allow disabling IPv4 or IPv6

2016-04-01 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- net/slirp.c | 36 ++-- qapi-schema.json | 8 qemu-options.hx | 8 ++-- slirp

[Qemu-devel] [PULL] slirp updates

2016-04-01 Thread Samuel Thibault
The following changes since commit de1d099a448beb2ec39af4bd9ce4dd6452a18cb5: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault-2' into staging (2016-04-01 11:15:20 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thiba

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Alex Bligh
On 1 Apr 2016, at 16:31, Eric Blake wrote: > When qemu client is talking to a qemu server, there is no > incompatibility between the two - all client commands that set FUA are > sanely handled by the recipient server code. But the same is not true > if you pair a current qemu client with curren

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: 149: Use "/usr/bin/env python"

2016-04-01 Thread Max Reitz
On 01.04.2016 11:56, Fam Zheng wrote: > Do the same as other scripts, to pick the correct interpreter between > python2 and python3 from the environment. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/149 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my blo

Re: [Qemu-devel] [PATCH] build: link with libatomic on powerpc-linux

2016-04-01 Thread Olaf Hering
On Fri, Apr 01, Peter Maydell wrote: > On 1 April 2016 at 13:00, Olaf Hering wrote: > > Building on powerpc-linux fails with undefined reference to __atomic_load_8 > > in > > icount_warp_rt(). Force linking to -latomic. > > We should instead be fixing this by not doing atomic operations > on ty

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2016-04-01 Thread Serge Hallyn
Indeed building the kilo package from source gives me the same hang. So something else (seabios maybe) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563887 Title: qemu-system-ppc64 freezes on sta

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 12:49:47PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 01:32:51PM +0200, Gerd Hoffmann wrote: > > > I think we were working on the same thing ... Attached is my > > > version. > > > > > > Note that you must enable at least CONFIG_MPTABLE else virtio-scsi > >

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Eric Blake
On 04/01/2016 09:13 AM, Alex Bligh wrote: > > On 1 Apr 2016, at 16:12, Alex Bligh wrote: > >> as qemu doesn't use FUA on write and the kernel doesn't use FUA > > "as qemu doesn't use FUA other than on write" - sorry qemu's block/nbd-client.c currently sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH (u

Re: [Qemu-devel] [Qemu-block] [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree

2016-04-01 Thread Max Reitz
On 31.03.2016 11:49, Stefan Hajnoczi wrote: > On Thu, Mar 24, 2016 at 08:07:17PM +0100, Max Reitz wrote: >> As I responded to: >> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html >> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.html >> >> I think a genera

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-01 Thread Max Reitz
On 31.03.2016 13:42, Alberto Garcia wrote: > On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: >>> I also have another (not directly related) question: why not simply >>> use the node name when removing children? I understood that the idea >>> was that it's possible to have the same node attach

Re: [Qemu-devel] [PATCH v2 0/9] virtio: aio handler API

2016-04-01 Thread Christian Borntraeger
Now with enable-debug and better call traces (gdb) (gdb) thread apply all bt Thread 5 (Thread 0x3ffa0e7f910 (LWP 29839)): #0 0x03ffa530334a in ioctl () at /lib64/libc.so.6 #1 0x80081c84 in kvm_vcpu_ioctl (cpu=0x80e8c170, type=44672) at /home/cborntra/REPOS/qemu/kvm-all.c:1984 #2

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 04:06:23PM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 10:58:19AM -0400, Kevin O'Connor wrote: > > On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote: > > > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote: > > > > On 01/04/2016 10

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Alex Bligh
On 1 Apr 2016, at 16:12, Alex Bligh wrote: > as qemu doesn't use FUA on write and the kernel doesn't use FUA "as qemu doesn't use FUA other than on write" - sorry > at all; I realise that is not an exhaustive list. -- Alex Bligh signature.asc Description: Message signed with OpenPGP usi

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Alex Bligh
On 1 Apr 2016, at 16:08, Eric Blake wrote: > But yes, I'm favoring a) as well, for the simplicity factor. There's > still the issue that if we document a behavior, a new client talking to > an older server can't reliably tell if the behavior will be guaranteed. Existing clients should not be s

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Eric Blake
On 04/01/2016 09:00 AM, Alex Bligh wrote: >> >> Or rather than a flag bit, what about this strawman: >> >> NBD_FLAG_SEND_FUA: If set, the server understands the NBD_CMD_FLAG_FUA >> bit. Except where more specific mandatory or optional behavior is >> documented on a given request, the server MUST i

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 01:07:55PM +0200, Gerd Hoffmann wrote: > On Fr, 2016-04-01 at 11:17 +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 11:18:30AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > I wonder how we can make use of this in qemu and downstream distros? > > > > Can

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:58:19AM -0400, Kevin O'Connor wrote: > On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 10:14, Richard W.M. Jones wrote: > > > > Found it: only CONFIG_MPTABLE=y was n

Re: [Qemu-devel] [PATCH v1 2/2] include/qemu/atomic: add compile time asserts

2016-04-01 Thread Alex Bennée
Alex Bennée writes: > To be safely portable no atomic access should be trying to do more than > the natural word width of the host. The most common abuse is trying to > atomically access 64 bit values on a 32 bit host. > > This patch adds some QEMU_BUILD_BUG_ON to the __atomic instrinsic paths >

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Alex Bligh
> > Or rather than a flag bit, what about this strawman: > > NBD_FLAG_SEND_FUA: If set, the server understands the NBD_CMD_FLAG_FUA > bit. Except where more specific mandatory or optional behavior is > documented on a given request, the server MUST ignore NBD_CMD_FLAG_FUA > if it advertised NBD_

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Kevin O'Connor
On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote: > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote: > > On 01/04/2016 10:14, Richard W.M. Jones wrote: > > > Found it: only CONFIG_MPTABLE=y was necessary. It boots with: > > > > > > # CONFIG_PIRTABLE is not set > >

Re: [Qemu-devel] [PATCH] xen: write information about supported backends

2016-04-01 Thread Stefano Stabellini
On Wed, 30 Mar 2016, Juergen Gross wrote: > Add a Xenstore directory for each supported pv backend. This will allow > Xen tools to decide which backend type to use in case there are > multiple possibilities. > > The information is added under > /local/domain//device-model//backends > before the "r

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.5.1 Stable released

2016-04-01 Thread Michael Roth
Quoting Peter Lieven (2016-04-01 02:43:31) > Am 30.03.2016 um 02:11 schrieb Michael Roth: > > Hi everyone, > > > > I am pleased to announce that the QEMU v2.5.1 stable release is now > > available at: > > > > http://wiki.qemu.org/download/qemu-2.5.1.tar.bz2 > > > > v2.5.1 is now tagged in the off

[Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_order[]

2016-04-01 Thread James Hogan
The MIPS TCG backend is the only one to have tcg_target_reg_alloc_order[] elements of type TCGReg rather than int. This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different order") breaking the build on MIPS since the type differed from indirect_reg_alloc_order[]

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

2016-04-01 Thread Peter Maydell
On 1 April 2016 at 15:30, James Hogan wrote: > Hi Alex, > > On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote: >> The __atomic primitives have been available since GCC 4.7 and provide >> a richer interface for describing memory ordering requirements. As a >> bonus by using the primitives

Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!

2016-04-01 Thread Roman Kagan
On Fri, Apr 01, 2016 at 10:18:02AM +0200, Paolo Bonzini wrote: > Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever > we want in the Hyper-V vendor signature, let's show some love too! > > Cc: Andreas Färber > Cc: Alex Williamson > Cc: Denis V. Lunev > Cc: Eduardo Habkost

[Qemu-devel] [PATCH 2/3] ide: restart atapi dma by re-evaluating command packet

2016-04-01 Thread Denis V. Lunev
From: Pavel Butsykin ide_atapi_dma_restart() used to just complete the DMA with an error, under the assumption that there isn't enough information to restart it. However, as the contents of the ->io_buffer is preserved, it looks safe to just re-evaluate it and dispatch the ATAPI command again.

[Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-04-01 Thread Denis V. Lunev
From: Pavel Butsykin Restart of ATAPI DMA used to be unreachable, because the request to do so wasn't indicated in bus->error_status due to the lack of spare bits, and ide_restart_bh() would return early doing nothing. This patch makes use of the observation that not all bit combinations were po

[Qemu-devel] [PATCH v3 0/3] ide: fix loss of the dma/atapi state during migration

2016-04-01 Thread Denis V. Lunev
This patch set fixes bugs in the IDE DMA and the IDE ATAPI on operations to save/restore the state. >From the user point of view this results in IDE timeouts in the guest when the user reads from the DVD like the following: [424332.169229] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6

[Qemu-devel] [PATCH 1/3] ide: don't lose pending dma state

2016-04-01 Thread Denis V. Lunev
From: Pavel Butsykin If the migration occurs after the IDE DMA has been set up but before it has been initiated, the state gets lost upon save/restore. Specifically, ->dma_cb callback gets cleared, so, when the guest eventually starts bus mastering, the DMA never completes, causing the guest to t

Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks

2016-04-01 Thread Cornelia Huck
On Fri, 1 Apr 2016 16:14:22 +0200 Christian Borntraeger wrote: > On 04/01/2016 03:19 PM, Paolo Bonzini wrote: > > Reentrancy cannot happen while the BQL is being held. > > > > Reviewed-by: Cornelia Huck > > Signed-off-by: Paolo Bonzini > > Reverting this patch makes the segfaults go away. >

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

2016-04-01 Thread James Hogan
Hi Alex, On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote: > The __atomic primitives have been available since GCC 4.7 and provide > a richer interface for describing memory ordering requirements. As a > bonus by using the primitives instead of hand-rolled functions we can > use tools s

Re: [Qemu-devel] [PATCH v2] block: Fix bdrv_drain in coroutine

2016-04-01 Thread Laurent Vivier
On 01/04/2016 15:57, Fam Zheng wrote: > Using the nested aio_poll() in coroutine is a bad idea. This patch > replaces the aio_poll loop in bdrv_drain with a BH, if called in > coroutine. > > For example, the bdrv_drain() in mirror.c can hang when a guest issued > request is pending on it in qemu

Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks

2016-04-01 Thread Christian Borntraeger
On 04/01/2016 03:19 PM, Paolo Bonzini wrote: > Reentrancy cannot happen while the BQL is being held. > > Reviewed-by: Cornelia Huck > Signed-off-by: Paolo Bonzini Reverting this patch makes the segfaults go away. > --- > hw/block/dataplane/virtio-blk.c | 12 ++-- > hw/scsi/virtio-

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-01 Thread Eric Blake
On 04/01/2016 02:27 AM, Wouter Verhelst wrote: > That's what I'm mostly worried about. Yes, we have FUA, and yes, some > clients may send it on commands that aren't WRITE, but it is not very > well defined what happens then: > > - Currently-released versions of nbd-server will accept the flag on

Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!

2016-04-01 Thread Michael Roth
Quoting Paolo Bonzini (2016-04-01 03:18:02) > Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever > we want in the Hyper-V vendor signature, let's show some love too! This might actually fix GPU passthrough for Nvidia cards when Hyper-V is enabled. Cc'ing qemu-sta...@nongnu.

Re: [Qemu-devel] [PATCH 5/9] virtio: add aio handler

2016-04-01 Thread Cornelia Huck
On Fri, 1 Apr 2016 15:19:50 +0200 Paolo Bonzini wrote: > From: "Michael S. Tsirkin" > > In addition to handling IO in vcpu thread and > in io thread, blk dataplane introduces yet another mode: > handling it by aio. > > This reuses the same handler as previous modes, > which triggers races as

Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-04-01 Thread Cornelia Huck
On Fri, 1 Apr 2016 15:19:46 +0200 Paolo Bonzini wrote: > There is no need to run the handler one last time; the device is > being reset and it is okay to drop requests that are pending in > the virtqueue. Even in the case of migration, the requests would > be processed when ioeventfd is re-enab

Re: [Qemu-devel] [PATCH v2 0/9] virtio: aio handler API

2016-04-01 Thread Christian Borntraeger
On 04/01/2016 03:19 PM, Paolo Bonzini wrote: > This version fixes some commit messages, is based on qemu.git master > and adds Cornelia's Reviewed-by tags. There are no code changes apart > from context. > > Michael S. Tsirkin (2): > virtio: add aio handler > virtio-blk: use aio handler for d

Re: [Qemu-devel] [PATCH v2 0/9] virtio: aio handler API

2016-04-01 Thread Cornelia Huck
On Fri, 1 Apr 2016 15:19:45 +0200 Paolo Bonzini wrote: > This version fixes some commit messages, is based on qemu.git master > and adds Cornelia's Reviewed-by tags. There are no code changes apart > from context. > > Michael S. Tsirkin (2): > virtio: add aio handler > virtio-blk: use aio

Re: [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane

2016-04-01 Thread Cornelia Huck
On Fri, 1 Apr 2016 15:19:51 +0200 Paolo Bonzini wrote: > From: "Michael S. Tsirkin" > > In addition to handling IO in vcpu thread and in io thread, dataplane > introduces yet another mode: handling it by aio. > > This reuses the same handler as previous modes, which triggers races as > these

[Qemu-devel] [PATCH v2] block: Fix bdrv_drain in coroutine

2016-04-01 Thread Fam Zheng
Using the nested aio_poll() in coroutine is a bad idea. This patch replaces the aio_poll loop in bdrv_drain with a BH, if called in coroutine. For example, the bdrv_drain() in mirror.c can hang when a guest issued request is pending on it in qemu_co_mutex_lock(). Mirror coroutine in this case has

[Qemu-devel] How to extract task excution infomation from qemu

2016-04-01 Thread Sam
We have been trying to build a multicore NoC emulator, which can runs a full system. We plan to run the full system in qemu and get information from traces to feed noxim,which is a NoC emulator. Noxim needs to read a taskList to start emulating. Each task include the following data fields: #Exe

Re: [Qemu-devel] [PATCH] doc/proto.md: Clients MUST not set unknown client flags

2016-04-01 Thread Eric Blake
On 04/01/2016 03:58 AM, Alex Bligh wrote: > Clients MUST NOT set unknown client flags. Currently this is > permitted (but 'SHOULD NOT' be done), with the result that the > server MUST drop the connection if it happens. This in effect > gives the client an inappropriate way to close the connection.

Re: [Qemu-devel] [PATCH] doc/proto.md: restore formatting

2016-04-01 Thread Eric Blake
On 04/01/2016 04:34 AM, Alex Bligh wrote: > Restore formatting and correct name of 'length' > > Signed-off-by: Alex Bligh > --- > doc/proto.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virt

Re: [Qemu-devel] [PATCHv2 2/2] Correct definition of NBD_CMD_FLAG_FUA

2016-04-01 Thread Eric Blake
On 04/01/2016 04:46 AM, Alex Bligh wrote: > NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but > 1<<16 in nbd.h. > > The code currently treats the command as a 32 bit quantity > and masks this off. This is confusing. Until such time as the > code is fixed up, make it obvious this isn't

Re: [Qemu-devel] [PATCHv2 1/2] proto.md: Clearly set out NBDMAGIC is the actual value

2016-04-01 Thread Eric Blake
On 04/01/2016 04:46 AM, Alex Bligh wrote: > Clearly set out NBDMAGIC, not the name of a constant equal to > some value. Set out the value in hex as well. > > Document the newstyle magic number is "IHAVEOPT". > > Signed-off-by: Alex Bligh > --- > doc/proto.md | 12 > 1 file changed,

[Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane

2016-04-01 Thread Paolo Bonzini
From: "Michael S. Tsirkin" In addition to handling IO in vcpu thread and in io thread, dataplane introduces yet another mode: handling it by aio. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Use a separate handler just for aio,

[Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks

2016-04-01 Thread Paolo Bonzini
Reentrancy cannot happen while the BQL is being held. Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 12 ++-- hw/scsi/virtio-scsi-dataplane.c | 9 + include/hw/virtio/virtio-scsi.h | 2 -- 3 files changed, 3 insertions(+), 20 dele

  1   2   3   >