Re: [Qemu-devel] proposal: new qemu-arm mailing list

2015-10-27 Thread Pavel Fedin
Hello! > Just to jump on and bead a dead horse, I am not OK with the idea of a > mailing list where patches might get reviewed and staged for pull > without the general population of qemu-devel being able to look first. Ok ok, i don't object, Peter has already explained a similar thing to me, a

Re: [Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU API

2015-10-27 Thread Pavel Fedin
Hello! > If there are no dependent patches on list that are 2.5 candidate, I suggest > we just drop this one for the short term. > Is there something on list? For 2.5, AFAIK, no. Unless Shlomo suddenly comes up with clean GICv3 implementation which could be quickly accepted. I wanted to upst

[Qemu-devel] [PATCH v7 2/2] enable multi-function hot-add

2015-10-27 Thread Cao jin
Enable PCIe device multi-function hot-add, just ensure function 0 is added last, then driver will get the notification to scan the slot. Signed-off-by: Cao jin --- hw/pci/pci.c | 40 +++- hw/pci/pci_host.c| 15 +++ hw/pci/pcie.c

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation

2015-10-27 Thread Jason Wang
On 10/28/2015 01:41 PM, Jason Wang wrote: > > On 10/27/2015 09:20 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC registers that were absent before,

[Qemu-devel] [PATCH v7 1/2] remove function during multi-function hot-add

2015-10-27 Thread Cao jin
In case user want to cancel the hot-add operation, should roll back, device_del the added function that still don`t work. Signed-off-by: Cao jin --- hw/pci/pcie.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 6e28

[Qemu-devel] [PATCH v7 0/2] PCIe device multi-function hot-add support

2015-10-27 Thread Cao jin
Support multi-function hot-add of PCIe device via device_add, just ensure function 0 is added last. While allow user to cancel the hot-add operation via device_del. changelog v7: 1. fix issue according to Alex`s comments changelog v6: 1. reimplement pci_get_function_0() using mst`s suggestion cod

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation

2015-10-27 Thread Dmitry Fleytman
--- Daynix Computing LTD Dmitry Fleytman, CTO Email: dmi...@daynix.com Phone: +972-54-2819481 Web: www.daynix.com > On 28 Oct 2015, at 07:41 AM, Jason Wang wrote: > > > > On 10/27/2015 09:20 PM, Leonid Bloch wr

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-27 Thread Dmitry Fleytman
> On 28 Oct 2015, at 07:44 AM, Jason Wang wrote: > > > > On 10/26/2015 01:00 AM, Leonid Bloch wrote: >> Hello qemu-devel, >> >> This patch series is an RFC for the new networking device emulation >> we're developing for QEMU. >> >> This new device emulates the Intel 82574 GbE Controller and

[Qemu-devel] [PATCH 1/2] trace: count number of enabled events

2015-10-27 Thread Paolo Bonzini
This lets trace_event_get_state_dynamic quickly return false. Right now there is hardly any benefit because there are also many assertions and indirections, but the next patch will streamline all of this. Signed-off-by: Paolo Bonzini --- trace/control-internal.h | 4 +++- trace/control.c

[Qemu-devel] [PATCH 2/2] trace: track enabled events in a separate array

2015-10-27 Thread Paolo Bonzini
This is more cache friendly on the fast path, where we already have the event id available. Signed-off-by: Paolo Bonzini --- scripts/tracetool/format/events_c.py | 2 +- trace/control-internal.h | 15 +++ trace/control.c | 1 + trace/control.h

[Qemu-devel] [PATCH for-2.5 0/2] trace: decrease overhead of simpletrace and stderr backends

2015-10-27 Thread Paolo Bonzini
This patch series makes it faster for simpletrace and stderr backends to discard disabled events. This is done in two ways: patch 1 makes the common case of no enabled events faster; patch 2 makes the other case less heavy on the data cache by packing the "tracepoint enabled" flag and avoiding use

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-27 Thread Jason Wang
On 10/26/2015 01:00 AM, Leonid Bloch wrote: > Hello qemu-devel, > > This patch series is an RFC for the new networking device emulation > we're developing for QEMU. > > This new device emulates the Intel 82574 GbE Controller and works > with unmodified Intel e1000e drivers from the Linux/Windows

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation

2015-10-27 Thread Jason Wang
On 10/27/2015 09:20 PM, Leonid Bloch wrote: > This series fixes issues with packet/octet counting in e1000's Statistic > registers, fixes a bug in the packet address filtering procedure, and > implements many MAC registers that were absent before, some Statistic > counters among them. Additionall

Re: [Qemu-devel] [PATCH v6 2/2] enable multi-function hot-add

2015-10-27 Thread Cao jin
Hi Alex On 10/27/2015 10:21 PM, Alex Williamson wrote: On Tue, 2015-10-27 at 20:51 +0800, Cao jin wrote: Enable PCIe device multi-function hot-add, just ensure function 0 is added last, then driver will got the notification to scan the slot. Signed-off-by: Cao jin --- hw/pci/pci.c |

[Qemu-devel] [RFC PATCH] hw: Add support for LSI SAS1068 (mptsas) device

2015-10-27 Thread Paolo Bonzini
This adds the SAS1068 device, a SAS disk controller used in VMware that is oldish but widely supported and has decent performance. Unlike megasas, it presents itself as a SAS controller and not as a RAID controller. The device corresponds to the mptsas kernel driver in Linux. A few small things

Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-10-27 Thread Jason Wang
On 10/28/2015 02:39 AM, Paolo Bonzini wrote: > Wasn't someone else going to help Jan as SLIRP comaintainer? > > Jason, perhaps you can pick up this patch in the meanwhile? > > Paolo Not familiar with slirp, but the patch looks good. Picked in https://github.com/jasowang/qemu/commits/net Thank

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-27 Thread Gabriel L. Somlo
On Tue, Oct 27, 2015 at 01:43:39PM +0100, Laszlo Ersek wrote: > On 10/27/15 12:11, Gerd Hoffmann wrote: > > Hi, > > > >>> My hypothesis (which I guess I'm volunteering to verify, unless we > >>> end up rejecting this immediately as a bad idea, for some reason that > >>> I have missed), is that c

Re: [Qemu-devel] [PATCH for-2.5 v1 3/4] arm: highbank: Implement PSCI and dummy monitor

2015-10-27 Thread Rob Herring
On Tue, Oct 27, 2015 at 4:30 PM, Peter Crosthwaite wrote: > > > On Tue, Oct 27, 2015 at 1:29 PM, Rob Herring wrote: >> >> On Sun, Oct 25, 2015 at 6:13 PM, Peter Crosthwaite >> wrote: >> > Firstly, enable monitor mode and PSCI, both are which are features of >> > this board. >> > >> > In addition

[Qemu-devel] [PULL for-2.5] Update OpenBIOS images

2015-10-27 Thread Mark Cave-Ayland
The following changes since commit 7e038b94e74e1c2d1b3598e2e4b0b5c8b79a7278: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2015-10-27 10:10:46 +) are available in the git repository at: https://github.com/mcayland/qemu.git tags/qemu-openbios-signed

Re: [Qemu-devel] [PATCH v2 0/5] dataplane snapshot fixes

2015-10-27 Thread Denis V. Lunev
On 10/27/2015 10:05 PM, Denis V. Lunev wrote: On 10/27/2015 09:41 PM, Paolo Bonzini wrote: On 27/10/2015 15:09, Denis V. Lunev wrote: The following test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with

Re: [Qemu-devel] [PATCH] i.MX: add support for lower and upper interrupt in GPIO.

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 3:32 PM, Jean-Christophe Dubois wrote: > The i.MX6 GPIO device supports 2 interrupts instead of one. > > * 1 for the lower 16 GPIOs. > * 1 for the upper 16 GPIOs. > > i.MX31 and i.MX25 only support 1 interrupt for the 32 GPIOs. > > So an architectural question, is it the c

[Qemu-devel] [PATCH 1/2] i.MX: rework CCM driver.

2015-10-27 Thread Jean-Christophe Dubois
The CCM driver is in fact specific to the i.MX31. We need to add an i.MX25 CCM driver. As a first step, we split the CCM driver into 2 parts: 1) A common/utility part that allow to compute an manipulate clock freq for any CCM driver 2) The i.MX31 CCM specifc driver. We also remove EPIT/GPT tim

[Qemu-devel] [PATCH] i.MX: add support for lower and upper interrupt in GPIO.

2015-10-27 Thread Jean-Christophe Dubois
The i.MX6 GPIO device supports 2 interrupts instead of one. * 1 for the lower 16 GPIOs. * 1 for the upper 16 GPIOs. i.MX31 and i.MX25 only support 1 interrupt for the 32 GPIOs. So we add a property to turn the behavior on when required. Signed-off-by: Jean-Christophe Dubois --- hw/gpio/imx_gp

[Qemu-devel] [PATCH 0/2] i.MX: Add an i.MX25 specific CCM driver

2015-10-27 Thread Jean-Christophe Dubois
i.MX25 SOC has a different CCM device than i.MX31. Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows Linux to work on top of the i.MX25 emultion but this is not correct. Furthermore, other SOC we could emulate like i.MX6 have yet a different implementation of the CCM device. We

[Qemu-devel] [PATCH 2/2] i.MX: Add i.MX25 CCM driver

2015-10-27 Thread Jean-Christophe Dubois
The i.MX25 CCM device is different from the i.MX31 one. So for now the emulation was not correct even if linux was working OK on top of the i.MX25 emulation. We add an i.MX25 specific CCM driver and use it in the i.MX25 SOC emulation. Signed-off-by: Jean-Christophe Dubois --- hw/arm/fsl-imx25.

Re: [Qemu-devel] [PATCH for-2.5 v1 3/4] arm: highbank: Implement PSCI and dummy monitor

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 1:29 PM, Rob Herring wrote: > On Sun, Oct 25, 2015 at 6:13 PM, Peter Crosthwaite > wrote: > > Firstly, enable monitor mode and PSCI, both are which are features of > > this board. > > > > In addition to PSCI, this board also uses SMC for cache maintainence > > ops. This m

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-27 Thread Dmitry Osipenko
25.10.2015 20:39, Peter Crosthwaite пишет: On Sun, Oct 25, 2015 at 6:23 AM, Dmitry Osipenko wrote: 25.10.2015 02:55, Peter Crosthwaite пишет: On Sat, Oct 24, 2015 at 3:22 PM, Dmitry Osipenko wrote: 24.10.2015 22:45, Peter Crosthwaite пишет: This looks like a give-up without trying to g

[Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-27 Thread Michael S. Tsirkin
Stefan noticed that we must use memmove, not memcpy, as arguments overlap. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index ed1f274..939f802 100644 --- a/hw/virtio/virtio

Re: [Qemu-devel] [PATCH for-2.5 v1 3/4] arm: highbank: Implement PSCI and dummy monitor

2015-10-27 Thread Rob Herring
On Sun, Oct 25, 2015 at 6:13 PM, Peter Crosthwaite wrote: > Firstly, enable monitor mode and PSCI, both are which are features of > this board. > > In addition to PSCI, this board also uses SMC for cache maintainence > ops. This means we need a secure monitor to catch these and nop them. > Use the

Re: [Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU API

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 7:18 AM, Pavel Fedin wrote: > Hello! > > > But Peter C has a better grasp of the current status of > > multiarch than I do, so if he prefers using obj-y then > > I'm happy to take his recommendation. > > I am neutral, and i will accept any solution. OTOH, he agreed with

Re: [Qemu-devel] [RFC PATCH v1] spapr: Memory hot-unplug support

2015-10-27 Thread Nathan Fontenot
On 10/26/2015 04:53 AM, Bharata B Rao wrote: > Add support to hot remove pc-dimm memory devices. > > TODO: In response to memory hot removal operation on a DIMM device, > guest kernel might refuse to offline a few LMBs that are part of that device. > In such cases, we will have a DIMM device that

Re: [Qemu-devel] [PATCH 3/3] qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

2015-10-27 Thread Michael Roth
Quoting Denis V. Lunev (2015-10-27 14:13:57) > On 10/27/2015 10:11 PM, Michael Roth wrote: > > Quoting Denis V. Lunev (2015-10-27 12:48:43) > >> From: Olga Krishtal > >> > >> Set fd non-blocking to avoid common use cases (like reading from a > >> named pipe) from hanging the agent. This was missed

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Laszlo Ersek
On 10/27/15 20:25, Eduardo Habkost wrote: > On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: >> In addition to Markus' and Eric's comments, I think we should >> >> 1. make sure the first word's case is correct. Lowercase for phrases, >>uppercase for sentences and proper nouns. > >

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: > In addition to Markus' and Eric's comments, I think we should > > 1. make sure the first word's case is correct. Lowercase for phrases, >uppercase for sentences and proper nouns. I think I can understand this in the more obvious

Re: [Qemu-devel] [PATCH 3/3] qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

2015-10-27 Thread Michael Roth
Quoting Michael Roth (2015-10-27 14:11:12) > Quoting Denis V. Lunev (2015-10-27 12:48:43) > > From: Olga Krishtal > > > > Set fd non-blocking to avoid common use cases (like reading from a > > named pipe) from hanging the agent. This was missed in the original > > code. > > > > The patch introdu

Re: [Qemu-devel] [PATCH 3/3] qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

2015-10-27 Thread Denis V. Lunev
On 10/27/2015 10:11 PM, Michael Roth wrote: Quoting Denis V. Lunev (2015-10-27 12:48:43) From: Olga Krishtal Set fd non-blocking to avoid common use cases (like reading from a named pipe) from hanging the agent. This was missed in the original code. The patch introduces analog of qemu_set_non

Re: [Qemu-devel] [PATCH 3/3] qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

2015-10-27 Thread Michael Roth
Quoting Denis V. Lunev (2015-10-27 12:48:43) > From: Olga Krishtal > > Set fd non-blocking to avoid common use cases (like reading from a > named pipe) from hanging the agent. This was missed in the original > code. > > The patch introduces analog of qemu_set_non/block for HANDLES. > The usage o

Re: [Qemu-devel] [PATCH v2 0/5] dataplane snapshot fixes

2015-10-27 Thread Denis V. Lunev
On 10/27/2015 09:41 PM, Paolo Bonzini wrote: On 27/10/2015 15:09, Denis V. Lunev wrote: The following test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with enabled iothreads on a running VM leads to a l

Re: [Qemu-devel] [Xen-devel] [Patch V1 3/3] xen: add pvUSB backend

2015-10-27 Thread Konrad Rzeszutek Wilk
On Thu, Sep 03, 2015 at 12:45:13PM +0200, Juergen Gross wrote: > Add a backend for para-virtualized USB devices for xen domains. > > The backend is using host-libusb to forward USB requests from a > domain via libusb to the real device(s) passed through. > > Signed-off-by: Juergen Gross > --- >

Re: [Qemu-devel] [PATCH v2 0/5] dataplane snapshot fixes

2015-10-27 Thread Paolo Bonzini
On 27/10/2015 15:09, Denis V. Lunev wrote: > The following test > while /bin/true ; do > virsh snapshot-create rhel7 > sleep 10 > virsh snapshot-delete rhel7 --current > done > with enabled iothreads on a running VM leads to a lot of troubles: hangs, > asserts, error

Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-10-27 Thread Paolo Bonzini
Wasn't someone else going to help Jan as SLIRP comaintainer? Jason, perhaps you can pick up this patch in the meanwhile? Paolo On 29/08/2015 09:12, Stefan Weil wrote: > Casting pointers to long won't work on 64 bit Windows. > It is not needed with the right format strings. > > Signed-off-by: St

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 04:13:12PM +, Stefan Hajnoczi wrote: > On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote: > > +for (i = 0; i < *num_sg; i++) { > > len = sg[i].iov_len; > > sg[i].iov_base = cpu_physical_memory_map(addr[i], &len, is_write); > > -

Re: [Qemu-devel] [PATCH v3 for 2.5] cpu-exec: Fix compiler warning (-Werror=clobbered)

2015-10-27 Thread Paolo Bonzini
On 27/10/2015 19:31, Stefan Weil wrote: > Am 26.09.2015 um 13:23 schrieb Stefan Weil: >> Reloading of local variables after sigsetjmp is only needed for some >> buggy compilers. >> >> The code which should reload these variables causes compiler warnings >> with gcc 4.7 when compiler optimizations

Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 05:29:43PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > vhost-user-test prints a warning. A test should not need to run on > hugetlbfs, let's silence the warning under qtest. Unfortunately, the > condition can't check on qtest_enabled() or qtest_

Re: [Qemu-devel] [PATCH] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 02:24:17PM -0200, Eduardo Habkost wrote: > On Tue, Oct 27, 2015 at 11:08:26AM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2015 at 04:33:18PM -0200, Eduardo Habkost wrote: > > > On Mon, Oct 26, 2015 at 09:42:05AM +0100, Igor Mammedov wrote: > > > > commit aa8580cd "p

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 04:19:54PM +, Stefan Hajnoczi wrote: > On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote: > > This will still fail if there's no space left in the sg, but luckily max > > queue size in use is currently 256, while max sg size is 1024, so we > > should be

Re: [Qemu-devel] [PATCH v3 for 2.5] cpu-exec: Fix compiler warning (-Werror=clobbered)

2015-10-27 Thread Stefan Weil
Am 26.09.2015 um 13:23 schrieb Stefan Weil: > Reloading of local variables after sigsetjmp is only needed for some > buggy compilers. > > The code which should reload these variables causes compiler warnings > with gcc 4.7 when compiler optimizations are enabled: > > cpu-exec.c:204:15: error: >

Re: [Qemu-devel] [PATCH 4/5] migration: add missed aio_context_acquire into hmp_savevm/hmp_delvm

2015-10-27 Thread Denis V. Lunev
On 10/27/2015 09:12 PM, Paolo Bonzini wrote: On 27/10/2015 15:09, Denis V. Lunev wrote: aio_context should be locked in the similar way as was done in QMP snapshot creation in the other case there are a lot of possible troubles if native AIO mode is enabled for disk. - the command can hang (HM

Re: [Qemu-devel] arm mptimer implementation - why prescaler is multiply by 10?

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 11:19 AM, Peter Maydell wrote: > On 27 October 2015 at 18:01, Peter Crosthwaite > wrote: > > On Tue, Oct 27, 2015 at 7:19 AM, Dmitry Osipenko > wrote: > >> From my observation, Linux kernel is booting noticeably faster in the > >> emulated guest and host machine CPU usag

Re: [Qemu-devel] arm mptimer implementation - why prescaler is multiply by 10?

2015-10-27 Thread Peter Maydell
On 27 October 2015 at 18:01, Peter Crosthwaite wrote: > On Tue, Oct 27, 2015 at 7:19 AM, Dmitry Osipenko wrote: >> From my observation, Linux kernel is booting noticeably faster in the >> emulated guest and host machine CPU usage is lower if we "artificially" >> slowdown the MPtimer. You really s

Re: [Qemu-devel] [PATCH 2/3] qga: fixed CloseHandle in qmp_guest_file_open

2015-10-27 Thread Stefan Weil
Am 27.10.2015 um 18:48 schrieb Denis V. Lunev: > From: Olga Krishtal > > CloseHandle use HANDLE as an argument, but not *HANDLE > > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Michael Roth > CC: Stefan Weil > --- > qga/commands-win32.c | 2 +- > 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH 4/5] migration: add missed aio_context_acquire into hmp_savevm/hmp_delvm

2015-10-27 Thread Paolo Bonzini
On 27/10/2015 15:09, Denis V. Lunev wrote: > aio_context should be locked in the similar way as was done in QMP > snapshot creation in the other case there are a lot of possible > troubles if native AIO mode is enabled for disk. > > - the command can hang (HMP thread) with missed wakeup (the ope

Re: [Qemu-devel] arm mptimer implementation - why prescaler is multiply by 10?

2015-10-27 Thread Dmitry Osipenko
27.10.2015 21:01, Peter Crosthwaite пишет: On Tue, Oct 27, 2015 at 7:19 AM, Dmitry Osipenko mailto:dig...@gmail.com>> wrote: 27.10.2015 16:48, Krzeminski, Marcin (Nokia - PL/Wroclaw) пишет: Hello, I am playing with U-Boot on ARM under qemu. U-boot uses mptimer, and

Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-10-27 Thread Stefan Weil
Am 25.09.2015 um 21:48 schrieb Stefan Weil: > Am 29.08.2015 um 09:12 schrieb Stefan Weil: >> Casting pointers to long won't work on 64 bit Windows. >> It is not needed with the right format strings. >> >> Signed-off-by: Stefan Weil >> --- >> slirp/bootp.c | 12 +--- >> slirp/if.c

Re: [Qemu-devel] arm mptimer implementation - why prescaler is multiply by 10?

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 7:19 AM, Dmitry Osipenko wrote: > 27.10.2015 16:48, Krzeminski, Marcin (Nokia - PL/Wroclaw) пишет: > > Hello, >> I am playing with U-Boot on ARM under qemu. >> U-boot uses mptimer, and under qemu one second takes about 1 in real >> world. >> At the moment it seem that in u

[Qemu-devel] [PATCH 1/3] qga: drop hand-made guest_file_toggle_flags helper

2015-10-27 Thread Denis V. Lunev
We'd better use generic qemu_set_nonblock directly. Signed-off-by: Denis V. Lunev Reviewed-by: Yuri Pudgorodskiy Reviewed-by: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/qga/commands-posi

[Qemu-devel] [PATCH v3 for 2.5 0/3] qga: non-blocking fd cleanups

2015-10-27 Thread Denis V. Lunev
This patchset is reincarnation of one patch discussed in the scope of QEMU 2.4 and rejected for that time. Actually we should use non-blocking descriptors in QGA on Windows in guest-file-open exactly like was done for Posix. Changes from v2: - added fix for wrong argument to CloseHandle - switched

[Qemu-devel] [PATCH 3/3] qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

2015-10-27 Thread Denis V. Lunev
From: Olga Krishtal Set fd non-blocking to avoid common use cases (like reading from a named pipe) from hanging the agent. This was missed in the original code. The patch introduces analog of qemu_set_non/block for HANDLES. The usage of handles in qemu_set_non/block is impossible, because for wi

[Qemu-devel] [PATCH 2/3] qga: fixed CloseHandle in qmp_guest_file_open

2015-10-27 Thread Denis V. Lunev
From: Olga Krishtal CloseHandle use HANDLE as an argument, but not *HANDLE Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth CC: Stefan Weil --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/comm

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-27 Thread Sergey Fedorov
On 23.10.2015 15:41, Peter Maydell wrote: > On 23 October 2015 at 13:39, Sergey Fedorov wrote: >> On 23.10.2015 15:37, Peter Maydell wrote: >>> On 23 October 2015 at 13:35, Sergey Fedorov wrote: On 23.10.2015 14:10, Peter Maydell wrote: > On 23 October 2015 at 11:14, Sergey Fedorov wrot

Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 03:51:31PM +0300, Pavel Fedin wrote: > Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu > (default), but NUMA is not supported by the kernel. This makes it > impossible to use ivshmem in such configurations. > > This patch fixes the problem by ignoring

Re: [Qemu-devel] [PATCH for-2.5 v1 4/4] arm: xilinx_zynq: Add linux pre-boot

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 8:37 AM, Peter Maydell wrote: > On 27 October 2015 at 15:21, Peter Crosthwaite > wrote: > > > > > > On Tue, Oct 27, 2015 at 5:31 AM, Peter Maydell > > > wrote: > >> > >> On 25 October 2015 at 23:13, Peter Crosthwaite > >> wrote: > >> > Add a Linux-specific pre-boot rout

[Qemu-devel] [Bug 1508405] Re: qemu 2.4.0 with --enable-kvm hangs, takes 100% CPU

2015-10-27 Thread cptG
OK, I just git-bisected and it found the following commit to probably cause the problem: = SNIP 355023f2010c4df619d88a0dd7012b4b9c74c12c is the first bad commit commit 355023f2010c4df619d88a0dd7012b4b9c74c12c Author: Paolo Bonzini Date:

[Qemu-devel] [PATCH for-2.5 v2 3/4] mips: add Global Interrupt Controller

2015-10-27 Thread Yongbok Kim
The Global Interrupt Controller (GIC) is responsible for mapping each internal and external interrupt to the correct location for servicing. The internal representation of registers is different from the specification in order to consolidate information for each GIC Interrupt Sources and Virtual P

[Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-27 Thread Yongbok Kim
Add part of GCR Block which Linux Kernel utilises and it is enough to bring the GIC up. It defines full 32 Kbytes address space allocated for GCR but only few registers are implemented such as config, revision, status, L2 config and local config registers. To support MIPS Coherent Manager, this mod

[Qemu-devel] [PATCH for-2.5 v2 1/4] target-mips: add CMGCRBase register

2015-10-27 Thread Yongbok Kim
Physical base address for the memory-mapped Coherency Manager Global Configuration Register space. The MIPS default location for the GCR_BASE address is 0x1FBF_8. This register only exists if Config3 CMGCR is set to one. Signed-off-by: Yongbok Kim --- target-mips/cpu.h|3 ++- tar

[Qemu-devel] [PATCH for-2.5 v2 0/4] mips: add Global Interrupt Controller

2015-10-27 Thread Yongbok Kim
This patchset implement MIPS Global Interrupt Controller. In order to bring GIC up a part of GCR has been implemented as well. The Global Interrupt Controller (GIC) is responsible for mapping each internal and external interrupt to the correct location for servicing. With the patchset Linux Kerne

[Qemu-devel] [PATCH for-2.5 v2 4/4] mips: add gic support to malta

2015-10-27 Thread Yongbok Kim
Add Global Interrupt Controller support to Malta board. The I8259 is connected to pin 3 of the GIC. Increase number of CPUs supported to 32. Signed-off-by: Yongbok Kim --- hw/mips/mips_malta.c | 73 - 1 files changed, 71 insertions(+), 2 deletion

Re: [Qemu-devel] [PATCH for-2.5 v1 3/4] arm: highbank: Implement PSCI and dummy monitor

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 8:32 AM, Peter Maydell wrote: > On 27 October 2015 at 15:11, Peter Crosthwaite > wrote: > > > > > > On Tue, Oct 27, 2015 at 5:26 AM, Peter Maydell > > > wrote: > >> > >> On 25 October 2015 at 23:13, Peter Crosthwaite > >> wrote: > > >> > +static void hb_write_board_setu

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Eduardo Habkost
On Mon, Oct 26, 2015 at 01:10:31PM -0600, Eric Blake wrote: > On 10/26/2015 11:13 AM, Eduardo Habkost wrote: > > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > > > The trailing newlines, "qemu:" and "error:" message prefixes were > > removed. > > > > The only remaining

Re: [Qemu-devel] [PATCH 1/1] virtio: sync the dataplane vring state to the virtqueue before virtio_save

2015-10-27 Thread Stefan Hajnoczi
On Mon, Oct 26, 2015 at 02:42:57PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > When creating snapshot with the dataplane enabled, the snapshot file gets > not the actual state of virtqueue, because the current state is stored in > VirtIOBlockDataPlane. Therefore, before saving snapsho

Re: [Qemu-devel] proposal: new qemu-arm mailing list

2015-10-27 Thread John Snow
On 10/27/2015 07:16 AM, Peter Maydell wrote: > On 27 October 2015 at 11:07, Pavel Fedin wrote: >>> (Everything should still be cc'd to qemu-devel as well.) >> >> I would drop this requirement, except for stuff which could touch >> core functionality (qom, qobject). > > This is a standard requi

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/2015 10:01 AM, Markus Armbruster wrote: >> Eric Blake writes: > >> I went through all commit messages and tweaked around occurences of QMP. >> I pushed the result to qapi-next; please have a look. > > Commit 2858a50 (Prefer typesafe upcasts...) on that branch has to

Re: [Qemu-devel] [PATCH v2] gdb command: qemu handlers

2015-10-27 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 01:09:45PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > A new gdb commands are added: > > qemu handlers > > That dumps an AioContext list (by default qemu_aio_context) > possibly including a backtrace for cases it knows abou

Re: [Qemu-devel] [PATCH] ide: remove hardcoded 2GiB transactional limit

2015-10-27 Thread Stefan Hajnoczi
On Mon, Oct 26, 2015 at 07:38:02PM -0400, John Snow wrote: > Not that you can request a >2GiB transaction, but that's why checking > for it makes no sense anymore. > > With the newer 'limit' parameter to prepare_buf, we no longer need a > static limit. The maximum limit is still 2GiB, but the limi

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Eric Blake
On 10/27/2015 10:01 AM, Markus Armbruster wrote: > Eric Blake writes: > I went through all commit messages and tweaked around occurences of QMP. > I pushed the result to qapi-next; please have a look. Commit 2858a50 (Prefer typesafe upcasts...) on that branch has too much text (you pasted in cor

[Qemu-devel] [PATCH 0/1] Test the reopening of overlay_bs in 'block-commit'

2015-10-27 Thread Alberto Garcia
Hi, looks like we have a bug in the bdrv_reopen() code. It turns out that 'block-commit' fails if the 'top' node is not the active layer or its immediate backing file, and none of our test cases has detected that. I'm attaching one that reproduces the problem. What happens is that 'block-commit'

[Qemu-devel] [PATCH 1/1] qemu-iotests: Test the reopening of overlay_bs in 'block-commit'

2015-10-27 Thread Alberto Garcia
The 'block-commit' command needs the overlay image of 'top' to be opened in read-write mode in order to update the backing file string. If 'top' is not the active layer or its backing file then its overlay needs to be reopened during the block job. This is a test case for that scenario. Signed-of

Re: [Qemu-devel] [PATCH v2] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 10:14:56AM +0100, Igor Mammedov wrote: > On Tue, 27 Oct 2015 10:53:08 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Oct 27, 2015 at 09:48:37AM +0100, Igor Mammedov wrote: > > > On Tue, 27 Oct 2015 10:31:21 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon,

[Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest

2015-10-27 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-test prints a warning. A test should not need to run on hugetlbfs, let's silence the warning under qtest. Unfortunately, the condition can't check on qtest_enabled() or qtest_driver() since they are initialized later. Signed-off-by: Marc-André Lureau --- exec

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-27 Thread Valerio Aimale
On 10/27/15 10:11 AM, Markus Armbruster wrote: [...] Eduardo, I did try this approach. It takes 2 line changes in exec.c: comment the unlink out, and making sure MAP_SHARED is used when -mem-path and -mem-prealloc are given. It works beautifully, and libvmi accesses are fast. However, the VM is

Re: [Qemu-devel] [PATCH 0/6] virtio: handle non contigious s/g entries

2015-10-27 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 01:51:20PM +0200, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 10:47:54AM +0200, Michael S. Tsirkin wrote: > > TL;DR: > > This fixes virtio in a way transparent to guest. > > We should now be able to revert commits aa8580cd and df0acded19ec which > > worked > > aroun

Re: [Qemu-devel] [PATCH] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 11:08:26AM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 04:33:18PM -0200, Eduardo Habkost wrote: > > On Mon, Oct 26, 2015 at 09:42:05AM +0100, Igor Mammedov wrote: > > > commit aa8580cd "pc: memhp: force gaps between DIMM's GPA" > > > regressed memory hot-unplu

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-27 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote: > This will still fail if there's no space left in the sg, but luckily max > queue size in use is currently 256, while max sg size is 1024, so we > should be OK even is all entries happen to cross a single DIMM boundary. Don't for

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-27 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote: > +for (i = 0; i < *num_sg; i++) { > len = sg[i].iov_len; > sg[i].iov_base = cpu_physical_memory_map(addr[i], &len, is_write); > -if (sg[i].iov_base == NULL || len != sg[i].iov_len) { > +if (!s

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-27 Thread Markus Armbruster
Valerio Aimale writes: > On 10/27/15 9:00 AM, Markus Armbruster wrote: >> Valerio Aimale writes: >> >>> On 10/26/15 11:52 AM, Eduardo Habkost wrote: I was trying to advocate the use of a shared mmap'ed region. The sharing would be two-ways (RW for both) between the QEMU virtualize

Re: [Qemu-devel] [PULL 00/27] target-arm queue

2015-10-27 Thread Peter Maydell
On 27 October 2015 at 15:57, Peter Maydell wrote: > I will squash in the fix: > > diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c > index 45cf00d..261608d 100644 > --- a/hw/char/imx_serial.c > +++ b/hw/char/imx_serial.c > @@ -318,8 +318,7 @@ static void imx_serial_realize(DeviceState *dev

Re: [Qemu-devel] [PATCH for-2.5 v1 4/4] arm: xilinx_zynq: Add linux pre-boot

2015-10-27 Thread Peter Maydell
On 27 October 2015 at 15:21, Peter Crosthwaite wrote: > > > On Tue, Oct 27, 2015 at 5:31 AM, Peter Maydell > wrote: >> >> On 25 October 2015 at 23:13, Peter Crosthwaite >> wrote: >> > Add a Linux-specific pre-boot routine that matches the device >> > specific bootloaders behaviour. This is neede

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Eric Blake
On 10/27/2015 09:50 AM, John Snow wrote: >>> +default: >>> +printf("Parsing error -- %s\n", arg); >> >> I still think ':' is better than ' --' in error messages, but I'll leave >> it up to the maintainer. >> > > Crud, sorry Eric -- I didn't do this on purpose. As Kevin notes, I was >

[Qemu-devel] [PULL v2 00/27] target-arm queue

2015-10-27 Thread Peter Maydell
in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20151027-1 for you to fetch changes up to 9b539263faa5c1b7fce2551092b5c7b6eea92081: target-arm: Add support for S1 + S2 MMU translations (2015-10-27 15:59

Re: [Qemu-devel] [PATCH 4.5/7] glib: add compatibility interface for g_hash_table_add()

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/2015 08:51 AM, Markus Armbruster wrote: >> The next commit will use it. >> >> Signed-off-by: Markus Armbruster >> --- >> include/glib-compat.h | 7 +++ >> 1 file changed, 7 insertions(+) > > One nit: > >> >> diff --git a/include/glib-compat.h b/include/glib-c

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/26/2015 04:35 PM, Eric Blake wrote: >> We have two issues with our qapi union layout: >> 1) Even though the QMP wire format spells the tag 'type', the >> C code spells it 'kind', requiring some hacks in the generator. >> 2) The C struct uses an anonymous union, which pl

Re: [Qemu-devel] [PATCH] target-i386: fix clang sanitize warning

2015-10-27 Thread Peter Maydell
On 27 October 2015 at 14:24, wrote: > From: Marc-André Lureau > > When running vhost-user-test with clang compiled qemu with > --extra-cflags=-fsanitize=undefined, the following error is printed: > > qemu/target-i386/translate.c:2435:26: runtime error: left shift of negative > value -8 > > Acco

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Kevin Wolf
Am 27.10.2015 um 16:50 hat John Snow geschrieben: > > > On 10/26/2015 10:26 PM, Eric Blake wrote: > > On 10/26/2015 05:45 PM, John Snow wrote: > >> Reported-by: Max Reitz > >> Signed-off-by: John Snow > >> Reviewed-by: Eric Blake > >> --- > >> qemu-io-cmds.c | 53 +

Re: [Qemu-devel] [PATCH for-2.5 v1 2/4] arm: boot: Add board specific setup code API

2015-10-27 Thread Peter Crosthwaite
On Tue, Oct 27, 2015 at 5:19 AM, Peter Maydell wrote: > On 25 October 2015 at 23:13, Peter Crosthwaite > wrote: > > Add an API for boards to inject their own preboot software (or > > firmware) seqeuence. > > > > The software then returns to bootloader via the link register. This > > allows board

Re: [Qemu-devel] [PATCH v11 23/24] qapi: Reserve 'u' member name

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/2015 02:21 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that we have separated union tag values from colliding with >>> non-variant C names, by naming the union 'u', we should reserve >>> this name for our use. Note that we want to forbid 'u' even

Re: [Qemu-devel] [PULL 00/27] target-arm queue

2015-10-27 Thread Peter Maydell
t; Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-10-27 10:10:46 +) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20151027 > > for you to f

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread John Snow
On 10/26/2015 10:26 PM, Eric Blake wrote: > On 10/26/2015 05:45 PM, John Snow wrote: >> Reported-by: Max Reitz >> Signed-off-by: John Snow >> Reviewed-by: Eric Blake >> --- >> qemu-io-cmds.c | 53 ++--- >> 1 file changed, 34 insertions(+), 19 de

Re: [Qemu-devel] [PATCHv2] tests: re-enable vhost-user-test

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 10:33:26AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On 26 October 2015 at 14:32, wrote: > > > From: Marc-André Lureau > > > > > > Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, > > > since CONFIG_VHOST_NET is a per-targe

Re: [Qemu-devel] [RFC PATCH v2] tests/vhost-user-bridge: add vhost-user bridge application

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 03:29:21PM +0200, Victor Kaplansky wrote: > On Tue, Oct 27, 2015 at 01:40:03PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2015 at 07:19:23PM +0200, Victor Kaplansky wrote: > > > + > > > +#define VHOST_USER_PROTOCOL_FEATURE_MASK ((1 << > > > VHOST_USER_PROTOCOL_F_M

  1   2   3   >