On 10/28/2015 01:41 PM, Jason Wang wrote: > > On 10/27/2015 09:20 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC registers that were absent before, some Statistic >> counters among them. Additionally, several cosmetic changes are made. >> >> Differences from v1: >> -------------------- >> * Wording of several commit messages corrected. >> * For trivially implemented Diagnostic registers, a debug message is >> added on read/write attempts, alerting of incomplete implementation. >> * Following testing on a physical device, only the lower 16 bits can now >> be read from AIT, and only the lower 4 - from FFMT*. >> * The grow_8reg_if_not_full function is rewritten. >> * inc_tx_bcast_or_mcast_count and increase_size_stats are now called >> from within e1000_send_packet, to avoid code duplication. >> >> The majority of these changes result from Jason Wang's review - thank >> you, Jason! >> >> Leonid Bloch (6): >> e1000: Cosmetic and alignment fixes >> e1000: Trivial implementation of various MAC registers >> e1000: Fixing the received/transmitted packets' counters >> e1000: Fixing the received/transmitted octets' counters >> e1000: Fixing the packet address filtering procedure >> e1000: Implementing various counters >> >> hw/net/e1000.c | 352 >> +++++++++++++++++++++++++++++++++++++++------------- >> hw/net/e1000_regs.h | 8 +- >> 2 files changed, 275 insertions(+), 85 deletions(-) >> > Applied in https://github.com/jasowang/qemu/commits/net > > Thanks >
Actually one thing is missed in this series - migration. The value of new implemented registers will be lost after migration. This needs to be fixed. So need a v3, sorry.
