[Qemu-devel] [Bug 1195882] Re: Make fails on Centos - can't find autoreconf

2013-06-28 Thread Eric Blake
> As far as I know, autoreconf does not exist in the red hat/fedora/centos > world. > > Can't find a yum, rpm. or other distro for it on the above os. You aren't looking very hard; on my RHEL 6.4 box (which has the same packages as what you can install in CentOS), I see: $ rpm -qf `which aut

[Qemu-devel] [PATCH V5 5/7] monitor: support sub commands in auto completion

2013-06-28 Thread Wenchao Xia
This patch allow auto completion work normal for sub command case, "info block [DEVICE]" can auto complete now, by re-enter the completion function. Also, original "info" is treated as a special case, now it is treated as a sub command group, global variable info_cmds is not used in any more. "hel

[Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command

2013-06-28 Thread Wenchao Xia
Now special case "help *" in auto completion can work with sub commands, such as "help info a*". Signed-off-by: Wenchao Xia --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 2f5b91d..3ef18ee 100644 --- a/monitor.c +++ b/monito

[Qemu-devel] [PATCH V5 7/7] monitor: improve "help" to allow show details of single command in sub group

2013-06-28 Thread Wenchao Xia
A new parameter type 'S' is introduced to allow user input any string. "help info block" do not tip extra parameter error now. Signed-off-by: Wenchao Xia --- hmp-commands.hx |2 +- monitor.c | 30 +- 2 files changed, 30 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH V5 3/7] monitor: code move for parse_cmdline()

2013-06-28 Thread Wenchao Xia
get_str() is called by parse_cmdline() so it is moved also. Some code style error reported by check script, is also fixed. Signed-off-by: Wenchao Xia --- monitor.c | 191 +++-- 1 files changed, 98 insertions(+), 93 deletions(-) diff --git

[Qemu-devel] [PATCH V5 2/7] monitor: avoid direct use of global variable *mon_cmds

2013-06-28 Thread Wenchao Xia
New member *cmd_table is added in structure Monitor to avoid direct usage of *mon_cmds. Now monitor have an associated command table, when global variable *info_cmds is also discarded, structure Monitor would gain full control about how to deal with user input. Signed-off-by: Wenchao Xia Reviewed

[Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-06-28 Thread Wenchao Xia
Parameter *mon is added to replace *cur_mon, and readline_completion() pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). In short, structure ReadLineState controls where the action would be taken now. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake

[Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-06-28 Thread Wenchao Xia
In help functions info_cmds is treated as sub command group now, not as a special case any more. Still help can't show message for single command under "info", since command parser reject additional parameter, which can be improved by change "help" item parameter define later. "log" is still treate

[Qemu-devel] [PATCH V5 0/7] monitor: support sub command group in auto completion and help

2013-06-28 Thread Wenchao Xia
Global variable *mon_cmds and *info_cmds are not directly used any more, *cur_mon is not used in completion related functions. It is possible to create a monitor with different command table now, but that requirement do not exist yet, so not changed it to save trouble. Log command is still a specia

Re: [Qemu-devel] [PATCH V4 0/7] monitor: support sub command group in auto completion and help

2013-06-28 Thread Wenchao Xia
于 2013-6-28 11:39, Wenchao Xia 写道: > Global variable *mon_cmds and *info_cmds are not directly used any more, > *cur_mon is not used in completion related functions. It is possible to create > a monitor with different command table now, but that requirement do not exist > yet, so not changed it to

Re: [Qemu-devel] [PATCH v4 00/11] Fix versatile_pci

2013-06-28 Thread Rob Landley
On 04/08/2013 03:16:18 PM, Peter Maydell wrote: On 8 April 2013 18:37, Rob Landley wrote: > On 04/06/2013 10:44:25 AM, Peter Maydell wrote: >> >> This patch series fixes a number of serious bugs in our emulation of >> the PCI controller found on VersatilePB and the early Realview boards: >>

[Qemu-devel] [PATCH] migration: add timeout option for tcp migraion send/receive socket

2013-06-28 Thread Zhanghaoyu (A)
When network disconnection occurs during live migration, the migration thread will be stuck in the function sendmsg(), as the migration socket is in ~O_NONBLOCK mode now. Signed-off-by: Zeng Junliang --- include/migration/migration.h |4 migration-tcp.c | 23 ++

Re: [Qemu-devel] [Bug 1195882] Re: Make fails on Centos - can't find autoreconf

2013-06-28 Thread Todd Ross
As  far as I know,  autoreconf does not exist in the red hat/fedora/centos world. Can't find a yum, rpm. or other distro for it on the above os. Am I missing something obvious hrte? Thanks Sent from a mobile device. Original message From: Iggy Date: To: tr...@seraban

Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h

2013-06-28 Thread Ed Maste
On 28 June 2013 14:26, Paolo Bonzini wrote: > > +/* This is thread-local depending on __linux__ because: Is the comment perhaps unchanged from an earlier revision that used a different test? It seems odd to me to reference __linux__ here. > + * - the only -user mode supporting multiple VCPU th

Re: [Qemu-devel] [PATCH v2 0/8] rdma: core logic w/ unpin example

2013-06-28 Thread Michael R. Hines
FYI: This version also passes under the 'virt-test' framework in addition to my very aggressive looped regression tests, in case anyone was concerned about additional testing. I've also submitted a patch to virt-test to include rdma support. As soon as this patch applies, I'll do the same on the

[Qemu-devel] [Bug 1195882] Re: Make fails on Centos - can't find autoreconf

2013-06-28 Thread Iggy
autoreconf is part of the autoconf package. Do you have that installed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1195882 Title: Make fails on Centos - can't find autoreconf Status in QEMU:

Re: [Qemu-devel] Openbios upgrade broke sparc32 linux.

2013-06-28 Thread Mark Cave-Ayland
On 28/06/13 03:08, Rob Landley wrote: Commit 467b34689d27 upgraded the openbios image, and ever since my linux system images hang about the time they try to initialize interrupts. http://landley.net/aboriginal/bin/system-image-sparc.tar.bz2 Extract that and "./run-emulator.sh" in the tarball.

[Qemu-devel] [Bug 1195882] [NEW] Make fails on Centos - can't find autoreconf

2013-06-28 Thread Todd Ross
Public bug reported: [root@H002 qemu-1.4.2]# make \ GEN i386-softmmu/config-devices.mak GEN x86_64-softmmu/config-devices.mak

[Qemu-devel] [PULL] hmp: Make "info block" output more readable

2013-06-28 Thread Luiz Capitulino
From: Kevin Wolf HMP is meant for humans and you should notice it. This changes the output format to use a bit more space to display the information more readable and leaves out irrelevant information (e.g. mention only that an image is encrypted, but not when it's not; display I/O limits only i

[Qemu-devel] [PULL] QMP queue

2013-06-28 Thread Luiz Capitulino
The following changes since commit 36125631e79d53ffb9365740f43f386e2171d116: Merge remote-tracking branch 'kwolf/for-anthony' into staging (2013-06-28 10:37:34 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to fb

Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h

2013-06-28 Thread Anthony Liguori
Paolo Bonzini writes: > The next patch will change qemu/tls.h to support more platforms, but at > some performance cost. Declare cpu_single_env directly instead of using > the tls.h abstractions. > > Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- >

Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-06-28 Thread Anthony Liguori
Paolo Bonzini writes: > We're already using them in several places, but __sync builtins are just > too ugly to type, and do not provide seqcst load/store operations. > > Signed-off-by: Paolo Bonzini > --- > docs/atomics.txt | 345 > +++ > hw/

Re: [Qemu-devel] [PATCH 1/2] Refine and export infinite loop checking in collect_image_info_list()

2013-06-28 Thread Eric Blake
On 06/27/2013 01:38 AM, Xu Wang wrote: > From: Xu Wang > > Signed-off-by: Xu Wang > --- > qemu-img.c | 110 > + > 1 file changed, 89 insertions(+), 21 deletions(-) > > +/** > + * Check backing file chain if there is a loop in it and

Re: [Qemu-devel] [PATCH v5 14/14] Implement dimm-info

2013-06-28 Thread Eric Blake
On 06/26/2013 03:13 AM, Hu Tao wrote: > From: Vasilis Liaskovitis > > "query-dimm-info" and "info dimm" will give current state of all dimms in the > system e.g. > > +++ b/qapi-schema.json > @@ -3621,3 +3621,30 @@ > { 'type': 'MemoryInfo', >'data': { 'total': 'int' } } > { 'command': 'que

Re: [Qemu-devel] [PATCH v5 12/14] Implement "info memory" and "query-memory"

2013-06-28 Thread Eric Blake
On 06/26/2013 03:13 AM, Hu Tao wrote: > From: Vasilis Liaskovitis > > Returns total physical memory available to guest in bytes, including > hotplugged > memory. Note that the number reported here may be different from what the > guest > sees e.g. if the guest has not logically onlined hotplugg

Re: [Qemu-devel] [PATCH v2 1/8] rdma: update documentation to reflect new unpin support

2013-06-28 Thread Michael R. Hines
On 06/28/2013 04:14 PM, Eric Blake wrote: On 06/28/2013 01:59 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or othe

Re: [Qemu-devel] [PATCH v2 1/8] rdma: update documentation to reflect new unpin support

2013-06-28 Thread Eric Blake
On 06/28/2013 01:59 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As requested, the protocol now includes memory unpinning support. > This has been implemented in a non-optimized manner, in such a way > that one could devise an LRU or other workload-specific information > o

Re: [Qemu-devel] [PATCH 01/30] memory: access FlatView from a local variable

2013-06-28 Thread Anthony Liguori
Paolo Bonzini writes: > We will soon require accesses to as->current_map to be placed under > a lock (with reference counting so as to keep the critical section > small). To simplify this change, always fetch as->current_map into > a local variable and access it through that variable. > > Signed

Re: [Qemu-devel] [PATCH 03/30] memory: add reference counting to FlatView

2013-06-28 Thread Anthony Liguori
Paolo Bonzini writes: > With this change, a FlatView can be used even after a concurrent > update has replaced it. Because we do not have RCU, we use a > mutex to protect the small critical sections that read/write the > as->current_map pointer. Accesses to the FlatView can be done > outside th

[Qemu-devel] [PATCH v2 1/8] rdma: update documentation to reflect new unpin support

2013-06-28 Thread mrhines
From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or other workload-specific information on top of the basic mechanism to influence the way unpinning happens du

[Qemu-devel] [PATCH v2 4/8] rdma: unpin support

2013-06-28 Thread mrhines
From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or other workload-specific information on top of the basic mechanism to influence the way unpinning happens du

Re: [Qemu-devel] [PATCH 02/30] memory: use a new FlatView pointer on every topology update

2013-06-28 Thread Anthony Liguori
Paolo Bonzini writes: > This is the first step towards converting as->current_map to > RCU-style updates, where the FlatView updates run concurrently > with uses of an old FlatView. > > Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > memory.c | 34

[Qemu-devel] [PATCH v2 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-28 Thread mrhines
From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (what we're calling 'NONE' here) and QEMU has been unconditionally transitioning into this state when the QMP migration command was

[Qemu-devel] [PATCH v2 8/8] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-28 Thread mrhines
From: "Michael R. Hines" Using the previous patches, we're now able to timestamp the SETUP state. Once we have this time, let the user know about it in the schema. Reviewed-by: Juan Quintela Reviewed-by: Eric Blake Signed-off-by: Michael R. Hines --- hmp.c |4

[Qemu-devel] [PATCH v2 2/8] rdma: introduce ram_handle_compressed()

2013-06-28 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. H

[Qemu-devel] [PATCH v2 0/8] rdma: core logic w/ unpin example

2013-06-28 Thread mrhines
From: "Michael R. Hines" This version seems ready to go, if there are no fundamental problems. Changes since v1: - Complete endianness handling of all protocol messages - Splitout unpin patch - ./configure fixes - Fix documentation Michael R. Hines (8): rdma: update documentation to reflect n

[Qemu-devel] [PATCH v2 6/8] rdma: allow state transitions between other states besides ACTIVE

2013-06-28 Thread mrhines
From: "Michael R. Hines" This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state and QEMU has been unconditionally transitioning into this state when the QMP migrate command was called. In preparation

[Qemu-devel] [PATCH v2 5/8] rdma: send pc.ram

2013-06-28 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Te

[Qemu-devel] [PATCH 13/30] qemu-thread: report RCU quiescent states

2013-06-28 Thread Paolo Bonzini
Most threads will use mutexes and other sleeping synchronization primitives (condition variables, semaphores, events) periodically. For these threads, the synchronization primitives are natural places to report a quiescent state (possibly an extended one). Signed-off-by: Paolo Bonzini --- docs/

Re: [Qemu-devel] [PATCH 30/30] exec: put address space dispatch under RCU critical section

2013-06-28 Thread Jan Kiszka
On 2013-06-28 20:26, Paolo Bonzini wrote: > With this change, address space dispatch can be moved outside the > BQL. The actual I/O would still have to happen within the lock. > > The next step would be to introduce a function that can only > be called from outside the BQL, address_space_rw_unloc

Re: [Qemu-devel] [PATCH] block: add the optional file entry to query-block

2013-06-28 Thread Eric Blake
On 06/28/2013 08:32 AM, Federico Simoncelli wrote: > This patch adds the optional file entry to the query-block output. > The value is a json-object representing the information about the > underlying file or device (when present). > > Signed-off-by: Federico Simoncelli > --- > block/qapi.c

[Qemu-devel] [PATCH 02/30] memory: use a new FlatView pointer on every topology update

2013-06-28 Thread Paolo Bonzini
This is the first step towards converting as->current_map to RCU-style updates, where the FlatView updates run concurrently with uses of an old FlatView. Signed-off-by: Paolo Bonzini --- memory.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --g

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
> >> > >> I wonder if TIME_H is maybe a bit too nondescript and could conflict > >> with other guards. OK. I will use QEMU_TIME_H. Apologies for my curt reply. Seiji

Re: [Qemu-devel] [PATCH] q35 chipset: Extend support of SMBUS(module pm_smbus.c) HST_STS register v2.

2013-06-28 Thread Anthony Liguori
Maksim Ratnikov writes: > From b4c324b42b488aca76aae06c8fa23a45acd91fcf Mon Sep 17 00:00:00 2001 > From: MRatnikov > Date: Fri, 28 Jun 2013 02:57:51 +0400 > Subject: [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS > register v2 Patch is corrupted. Please send with git-send-email.

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Laszlo Ersek
On 06/28/13 20:54, Seiji Aguchi wrote: > >>> diff --git a/include/qemu/time.h b/include/qemu/time.h >>> new file mode 100644 >>> index 000..f70739b >>> --- /dev/null >>> +++ b/include/qemu/time.h >>> @@ -0,0 +1,11 @@ >>> +#ifndef TIME_H >>> +#define TIME_H >> >> I wonder if TIME_H is maybe a b

Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
Thank you for the review. > > +#include "qemu-common.h" > > + > > +/* "1970-01-01T00:00:00.99Z" + '\0' */ > > +#define TIMESTAMP_LEN 28 > > Self-documenting constants are nicer: > > #define TIMESTAMP_LEN (sizeof("1970-01-01T00:00:00.99Z")+1) I will fix it. > > extern void qemu_get_ti

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
> > diff --git a/include/qemu/time.h b/include/qemu/time.h > > new file mode 100644 > > index 000..f70739b > > --- /dev/null > > +++ b/include/qemu/time.h > > @@ -0,0 +1,11 @@ > > +#ifndef TIME_H > > +#define TIME_H > > I wonder if TIME_H is maybe a bit too nondescript and could conflict > wi

[Qemu-devel] [PATCH 30/30] exec: put address space dispatch under RCU critical section

2013-06-28 Thread Paolo Bonzini
With this change, address space dispatch can be moved outside the BQL. The actual I/O would still have to happen within the lock. The next step would be to introduce a function that can only be called from outside the BQL, address_space_rw_unlocked. The function would do something like mr =

Re: [Qemu-devel] [PATCH v4 07/10] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems

2013-06-28 Thread Laszlo Ersek
On 06/28/13 20:01, Laszlo Ersek wrote: > (b) error_setg_win32() should imitate error_setg_errno(): > > #define error_setg_win32(err, win32, fmt, ...) \ > error_set_errno(err, win32, ERROR_CLASS_GENERIC_ERROR, fmt, ## > __VA_ARGS__) Typo of course, that's error_set_win32() in the rep

[Qemu-devel] [PATCH 27/30] exec: change some APIs to take AddressSpaceDispatch

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- exec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index 7f87e16..528c4d7 100644 --- a/exec.c +++ b/exec.c @@ -236,11 +236,10 @@ bool memory_region_is_unassigned(MemoryRegion *mr) && mr != &io_mem_watch;

[Qemu-devel] [PATCH 29/30] exec: add a reference to the region returned by address_space_translate

2013-06-28 Thread Paolo Bonzini
Once address_space_translate will only be protected by RCU, the returned MemoryRegion might disappear as soon as the RCU read-side critical section ends. Avoid this by adding a reference to the region, and dropping it in the caller of address_space_translate. This generalizes what was done for ad

[Qemu-devel] [PATCH 28/30] exec: change iotlb APIs to take AddressSpaceDispatch

2013-06-28 Thread Paolo Bonzini
This makes it possible to start following RCU rules, which require not dereferencing as->dispatch more than once. It is not covering the whole of TCG, since the TLB data structures are not RCU-friendly, but it is enough for exec.c. Signed-off-by: Paolo Bonzini --- cputlb.c | 7

[Qemu-devel] [PATCH 24/30] exec: separate current radix tree from the one being built

2013-06-28 Thread Paolo Bonzini
This same treatment previously done to phys_node_map and phys_sections is now applied to the dispatch field of AddressSpace. Topology updates use as->next_dispatch while accesses use as->dispatch. Signed-off-by: Paolo Bonzini --- exec.c| 23 --- include/exec/

[Qemu-devel] [PATCH 26/30] exec: remove cur_map

2013-06-28 Thread Paolo Bonzini
cur_map is not used anymore; instead, each AddressSpaceDispatch has its own nodes/sections pair. The priorities of the MemoryListeners, and in the future RCU, guarantee that the nodes/sections are not freed while they are still in use. (In fact, next_map itself is not needed except to free the da

[Qemu-devel] [PATCH 25/30] exec: put memory map in AddressSpaceDispatch

2013-06-28 Thread Paolo Bonzini
This lets us get a consistent (phys_map, nodes, sections) using RCU. After this patch, cur_map is not used anymore except for freeing it at the end of the topology update. Signed-off-by: Paolo Bonzini --- exec.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-

[Qemu-devel] [PATCH 23/30] exec: move listener from AddressSpaceDispatch to AddressSpace

2013-06-28 Thread Paolo Bonzini
This will help having two copies of AddressSpaceDispatch during the recreation of the radix tree (one being built, and one that is complete and accessed under RCU). We do not want to have to unregister and re-register the listener. Signed-off-by: Paolo Bonzini --- exec.c| 17 +++

[Qemu-devel] [PATCH 21/30] exec: separate current memory map from the one being built

2013-06-28 Thread Paolo Bonzini
Currently, phys_node_map and phys_sections are shared by all of the AddressSpaceDispatch. When updating mem topology, all AddressSpaceDispatch will rebuild dispatch tables sequentially on them. In order to prepare for RCU access, leave the old memory map alive while the next one is being accessed

[Qemu-devel] [PATCH 18/30] memory: protect current_map by RCU

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 5 + memory.c | 50 +- 2 files changed, 26 insertions(+), 29 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 9c33bba..aa7a922 100644 --- a/incl

[Qemu-devel] [PATCH 22/30] memory: move MemoryListener declaration earlier

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index aa7a922..913ac45 100644 --- a/include/exec/memory.h +++ b/include/ex

[Qemu-devel] [PATCH 16/30] block: report RCU quiescent states

2013-06-28 Thread Paolo Bonzini
The aio workers may spend a long time executing I/O operations; mark that time as an extended quiescent state. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 3 +++ block/raw-win32.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index c0ccf27

[Qemu-devel] [PATCH 15/30] cpus: report RCU quiescent states

2013-06-28 Thread Paolo Bonzini
CPU threads have extended quiescent states while relinquishing control to the accelerator (except TCG). Signed-off-by: Paolo Bonzini --- cpus.c| 3 +++ kvm-all.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/cpus.c b/cpus.c index c8bc8ad..4b5cb8d 100644 --- a/cpus.c +++ b/cpus.c @@

[Qemu-devel] [PATCH 20/30] exec: change well-known physical sections to macros

2013-06-28 Thread Paolo Bonzini
From: Liu Ping Fan Sections like phys_section_unassigned always have fixed address in phys_sections. Declared as macro, so we can use them when having more than one phys_sections array. Signed-off-by: Liu Ping Fan Signed-off-by: Liu Ping Fan Signed-off-by: Paolo Bonzini --- exec.c | 34

[Qemu-devel] [PATCH 11/30] rcu: add rcutorture

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile | 5 +- tests/rcutorture.c | 439 + 2 files changed, 443 insertions(+), 1 deletion(-) create mode 100644 tests/rcutorture.c diff --git a/tests/Makefile b/tests/Makefile index 0400b39..6a81b

[Qemu-devel] [PATCH 12/30] rcu: allow nested calls to rcu_thread_offline/rcu_thread_online

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 5 + include/qemu/rcu.h | 21 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index ca1c099..a3510b9 100644 --- a/docs/rcu.txt +++ b/docs/rcu.txt @@ -187,6 +187,11 @@ Marki

[Qemu-devel] [PATCH 19/30] memory: avoid ref/unref in memory_region_find

2013-06-28 Thread Paolo Bonzini
Do the entire lookup under RCU. Signed-off-by: Paolo Bonzini --- memory.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 7a4fe37..4fc23a2 100644 --- a/memory.c +++ b/memory.c @@ -1559,7 +1559,8 @@ MemoryRegionSection memory_region_find(MemoryRe

[Qemu-devel] [PATCH 17/30] migration: report RCU quiescent states

2013-06-28 Thread Paolo Bonzini
The migration thread polls s->state periodically, it does not use a mutex or condition variable, so it has to report quiescent states manually. Signed-off-by: Paolo Bonzini --- migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration.c b/migration.c index 83f5691..28010dc 1006

[Qemu-devel] [PATCH 10/30] rcu: add call_rcu

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 108 +-- include/qemu/rcu.h | 22 ++ util/rcu.c | 120 + 3 files changed, 246 insertions(+), 4 deletions(-) diff --git a/docs/rcu

[Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-06-28 Thread Paolo Bonzini
We're already using them in several places, but __sync builtins are just too ugly to type, and do not provide seqcst load/store operations. Signed-off-by: Paolo Bonzini --- docs/atomics.txt | 345 +++ hw/display/qxl.c | 3 +- hw/virti

[Qemu-devel] [PATCH 06/30] qemu-thread: add TLS wrappers

2013-06-28 Thread Paolo Bonzini
Fast TLS is not available on some platforms, but it is always nice to use it. This wrapper implementation falls back to pthread_get/setspecific on POSIX systems that lack __thread, but uses the dynamic linker's TLS support on Linux and Windows. The user shall call alloc_foo() in every thread that

[Qemu-devel] [PATCH 03/30] memory: add reference counting to FlatView

2013-06-28 Thread Paolo Bonzini
With this change, a FlatView can be used even after a concurrent update has replaced it. Because we do not have RCU, we use a mutex to protect the small critical sections that read/write the as->current_map pointer. Accesses to the FlatView can be done outside the mutex. If a MemoryRegion will b

[Qemu-devel] [PATCH 00/30] Memory API changes for 1.6: RCU-protected address space dispatch

2013-06-28 Thread Paolo Bonzini
These are the next part in the unlocked address space dispatch work. At the end of this series, address space dispatch runs under an RCU critical section (RCU is hopefully well documented in patch 8). It becomes then possible to add unlocked variants of address_space_rw. Compared to Liu Ping Fan's

[Qemu-devel] [PATCH 08/30] rcu: add rcu library

2013-06-28 Thread Paolo Bonzini
This includes a (mangled) copy of the urcu-qsbr code from liburcu. The main changes are: 1) removing dependencies on many other header files in liburcu; 2) removing for simplicity the tentative busy waiting in synchronize_rcu, which has limited performance effects; 3) replacing futexes in synchroni

[Qemu-devel] [PATCH 14/30] event loop: report RCU quiescent states

2013-06-28 Thread Paolo Bonzini
Threads that run event loops also have places that can sleep for an extended time. Place an extended quiescent state there. Signed-off-by: Paolo Bonzini --- aio-posix.c | 8 aio-win32.c | 11 ++- main-loop.c | 6 ++ 3 files changed, 24 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH 09/30] qemu-thread: register threads with RCU

2013-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 13 +++-- util/qemu-thread-posix.c | 28 +++- util/qemu-thread-win32.c | 2 ++ 3 files changed, 36 insertions(+), 7 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index 4869ec7..118a28a 100644 ---

[Qemu-devel] [PATCH 01/30] memory: access FlatView from a local variable

2013-06-28 Thread Paolo Bonzini
We will soon require accesses to as->current_map to be placed under a lock (with reference counting so as to keep the critical section small). To simplify this change, always fetch as->current_map into a local variable and access it through that variable. Signed-off-by: Paolo Bonzini --- memory

[Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h

2013-06-28 Thread Paolo Bonzini
The next patch will change qemu/tls.h to support more platforms, but at some performance cost. Declare cpu_single_env directly instead of using the tls.h abstractions. Signed-off-by: Paolo Bonzini --- exec.c | 10 -- include/exec/cpu-all.h | 14 +++--- include/qe

[Qemu-devel] [PATCH 07/30] qemu-thread: add QemuEvent

2013-06-28 Thread Paolo Bonzini
This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) { qemu_event_reset(ev); ... t

[Qemu-devel] [PULL 13/14] qemu-socket: don't leak opts on error

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 126cbb6..095716e 100644 --- a/util/qemu-sock

[Qemu-devel] [PULL 09/14] qemu-char: use ChardevBackendKind in CharDriver

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- include/sysemu/char.h |2 +- qemu-char.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index

[Qemu-devel] [PULL 06/14] qemu-char: print notification to stderr

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index e3b3224..371f630 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -

[Qemu-devel] [PULL 08/14] qemu-char: don't leak opts on error

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 371f630..0cda56c 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3178

[Qemu-devel] [PULL 11/14] qemu-char: add -chardev mux support

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Allow to explicitly create mux chardevs on the command line, like you can using QMP. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qemu-char.c

[Qemu-devel] [PULL 10/14] qemu-char: minor mux chardev fixes

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann mux failure path has a memory leak. creating a mux chardev can't fail though, so just assert() that instead of fixing an error path which never ever runs anyway ... Also fix bid being leaked while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-

[Qemu-devel] [PULL 14/14] doc: we use seabios, not bochs bios

2013-06-28 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-doc.texi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 8022890..185dd47 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -214,7 +214,7 @@ PCI UHCI USB controller and a virtual USB hub. SMP is

[Qemu-devel] [PULL 07/14] qemu-char: fix documentation for telnet+wait socket flags

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qapi-schema.json |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 6590307..5c32528 100644 --- a/qapi-schema.json

[Qemu-devel] [PULL 12/14] qemu-char: report udp backend errors

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index c097ca1..5a8f9c0 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2255,6 +2255,8 @@

[Qemu-devel] [PULL 00/14] Trivial patches for 2013-06-28

2013-06-28 Thread Michael Tokarev
Hello. There's a next week trivial-patches pull request. Most of the changes this time come from Gerd, with his single series of bugfixes for sockets and char code, plus one trivial patch from me. Please pull. Thanks, /mjt The following changes since commit 36125631e79d53ffb9365740f43f386e2171

[Qemu-devel] [PULL 05/14] qemu-char: use more specific error_setg_* variants

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a538217..e3b3224 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -

[Qemu-devel] [PULL 01/14] qemu-socket: zero-initialize SocketAddress

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- util/qemu-sockets.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 96eca2a..86fb09c 100644 --- a/util/qemu-

[Qemu-devel] [PULL 04/14] qemu-char: check optional fields using has_*

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a030e6b..a538217 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -

[Qemu-devel] [PULL 02/14] qemu-socket: drop pointless allocation

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- util/qemu-sockets.c |1 - 1 file changed, 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 86fb09c..35023a8 100644 --- a/util/qemu-sockets.c +++ b/util/

[Qemu-devel] [PULL 03/14] qemu-socket: catch monitor_get_fd failures

2013-06-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 35023a8..126cbb6 100644 --- a/util/qemu-sock

Re: [Qemu-devel] [PATCH v4 07/10] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems

2013-06-28 Thread Laszlo Ersek
On 06/06/13 17:06, Tomoki Sekiyama wrote: > diff --git a/qga/vss-win32-requester.h b/qga/vss-win32-requester.h > new file mode 100644 > index 000..f180f56 > --- /dev/null > +++ b/qga/vss-win32-requester.h > @@ -0,0 +1,31 @@ > +/* > + * QEMU Guest Agent VSS Requester declarations > + * > + * Co

Re: [Qemu-devel] [PULL v2 00/21] pci,kvm,misc enhancements

2013-06-28 Thread Anthony Liguori
Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> pvpanic: fix fwcfg for big endian hosts > > Umm, 1+10+9 is 20, but the pull is for 21 patches; what's going on here? Funny :-) Note that the series is missing 2/21. The branch has 20 commits, I suspect Michael did git-format-

Re: [Qemu-devel] [PATCH 0/2] Provide sextract32() and sextract64()

2013-06-28 Thread Richard Henderson
On 06/28/2013 04:40 AM, Peter Maydell wrote: > Peter Maydell (2): > bitops: Provide sextract32() and sextract64() > tests: Add test-bitops.c with some sextract tests > > include/qemu/bitops.h | 50 + > tests/Makefile|2 ++ > tests/test-bitops.c

Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

2013-06-28 Thread Richard Henderson
On 06/27/2013 02:48 PM, Petar Jovanovic wrote: >> This doesn't look right either, as it doesn't properly check for overflow of >> negative values. > > What overflow of negative values? > Can you please list the values for which the result would not be correct? Hmm, I suppose since we're always ro

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-28 Thread Markus Armbruster
Eric Blake writes: > On 06/26/2013 08:15 AM, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >>> On Wed, 26 Jun 2013 14:00:30 +0200 >>> Markus Armbruster wrote: >>> Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise. >>> >>> I don't think it

Re: [Qemu-devel] [PATCH v2] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

2013-06-28 Thread Richard Henderson
On 06/28/2013 06:22 AM, Peter Maydell wrote: > The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU > related -- they are specific to the TLS ABI for a a particular OS. > Move them into the linux-user/ tree where they belong. > > target-lm32 had entirely unused implementations, sinc

Re: [Qemu-devel] [PATCH v2] cpu: Drop unnecessary dynamic casts in *_env_get_cpu()

2013-06-28 Thread Richard Henderson
On 06/28/2013 06:23 AM, Andreas Färber wrote: > A transition from CPUFooState to FooCPU can be considered safe, > just like FooCPU::env access in the opposite direction. > The only benefit of the FOO_CPU() casts would be protection against > bogus CPUFooState pointers, but then surrounding code wou

Re: [Qemu-devel] [PULL v2 00/21] pci,kvm,misc enhancements

2013-06-28 Thread Markus Armbruster
Eric Blake writes: > On 06/25/2013 03:48 PM, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >>> From: Michael S. Tsirkin >>> >>> The following changes since commit 90a2541b763b31d2b551b07e24aae3de5266d31b: >>> >>> target-i386: fix over 80 chars warnings (2013-06-15 17:50:38 +)

  1   2   3   >