On 06/27/2013 02:48 PM, Petar Jovanovic wrote: >> This doesn't look right either, as it doesn't properly check for overflow of >> negative values. > > What overflow of negative values? > Can you please list the values for which the result would not be correct?
Hmm, I suppose since we're always rounding to +INF, we can't overflow in the negative direction. The patch could use some commentary along those lines... r~
