D12946: Single/Double Click Option at Workspace KCM

rooty added a comment. hey guys, resident grammar nazi reporting :D it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling) a great idea otherwise sorry :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. nah, it's too disproportionate with regard to the sliders and bars in all the Qt apps that use the fonts, (it's just too big, pun intended) 10pt is the best, as well as 9pt for Hack REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. there's simply no need to change this, Noto Sans at 10 pt is perfectly readable and blends in with the UI elements better Noto Sans at 11 pt looks disproportionate, perhaps if a different font were used (like filipf said, Cantarell) @davidedmundson why should

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. In D14869#311891 , @davidedmundson wrote: > > what do you mean by facts though, isn't telemetry just a bunch of personal preferences heaped up? > > Yes. > That is /considerably/ better than having just a few people

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. In D14869#311895 , @davidedmundson wrote: > > will you be using your telemetry data to dictate whether the default's double click to open or single click to open? > > It would certainly be a large factor, yes,

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. In D14869#311957 , @rkflx wrote: > @ngraham Could you comment on why (on your personal machine) you went for increasing the font size instead of changing the DPI value? (If this is a UI issue, telemetry might give skewed r

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. P.S. wasn't this problem settled already in T7864 ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869 To: ngraham, #plasma, #kde_applications, valorie, #vdg Cc: mart, oysteins, rooty, filipf, safaa

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. In D14869#311998 , @rikmills wrote: > In D14869#311997 , @rooty wrote: > > > P.S. wasn't this problem settled already in T7864 ? > > >

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. > Third, maybe it makes sense to increase the titlebar font by a bit in order to emphasize it, but 13pt bold is super excessive. > > Does this sound sensible to everyone who's chimed in here? Yes, sounds good, aside from: (1) The emphasis you're describing mi

D14869: [RFC] Increase default font sizes by 1 pt

rooty added a comment. In D14869#312228 , @ngraham wrote: > No, I would never propose removing the resolution slider/combobox. It's an implementation detail, but still an important one. What I am proposing is that we could somehow unify the vari

D15011: [Kickoff] Make the search field always look like a search field

rooty added a comment. In D15011#314514 , @ngraham wrote: > Actually both Kicker and System Settings give their search fields visible focus by default. Kicker does make the field visibly lose focus after you start using the keyboard to navigate

D15011: [Kickoff] Make the search field always look like a search field

rooty added a comment. In D15011#314812 , @ngraham wrote: > I like the idea of conditionally adding a little magnifying glass icon to the text field to indicate that it's a search field. If other folks are on board too, I can probably put togeth

D15011: [Kickoff] Make the search field always look like a search field

rooty added a comment. In D15011#318474 , @ngraham wrote: > I'm working on patches to reduce the visual weight of the focus ring and add some horizontal separators to Kickoff. Those will be submitted as separate patches. Where are we with this o

D14949: Add option for whether to show the volume change OSD

rooty added a comment. In D14949#335265 , @svenmauch wrote: > In D14949#334937 , @graesslin wrote: > > > Please don't introduce options based on what's unpopular on Reddit. > > > I'm not sugge

D14949: Add option for whether to show the volume change OSD

rooty added a comment. In D14949#333531 , @ngraham wrote: > > I could also support moving all of the square-style OSDs farther down so they're not as close to the center of the screen. why? REVISION DETAIL https://phabricato

D14949: Add option for whether to show the volume change OSD

rooty added a comment. In D14949#336050 , @ngraham wrote: > In D14949#336029 , @davidedmundson wrote: > > > The recurring pattern that we want to avoid is having a framework where theme creators can

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. i'm sorry but there is not a single screenshot in which either the shaded icons or the contrast/shadowing looks good; in fact, the shadows make a bad situation worse - the only way to make any of these look presentable (aside from the dark blue background, that one doe

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#339036 , @filipf wrote:> # this and the problem of white text on light backgrounds raises the question of implementing an option which would parse a kdeglobals file to var/lib/sddm/config with Breeze Dark set as th

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#339149 , @ngraham wrote: > It's a bit frustrating to spend a lot of time in the phab task (T9658 ) getting consensus on a design, implement it, and then hear, "no, no, major ele

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#339165 , @broulik wrote: > Can't we just give the buttons and avatar the same dropshadow as the clock? Imho the sharp edges of the circles behind look out of place compared to the "soft" shadows yeah they

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#339180 , @pstefan wrote: > As other have pointed out the shadows for the buttons and username look out of place. Do they use the same radius/spread as those of the clock? > > I think blur is still needed. If y

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#340321 , @ngraham wrote: > Here are some screenshots from the latest version: > > F6316263: Spaceships.png > > F6316264: Snow.png

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#341646 , @davidedmundson wrote: > Why should the login screen look different to the lock screen? why not? the lock screen (like nate said) is fine the way it is and the login screen had the problem o

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#341773 , @davidedmundson wrote: > > why not? > > Because it makes for a inconsistent random experience perhaps, but a far more intuitive experience unless you're about to add a Slide to unlock me

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#341773 , @davidedmundson wrote: > > why not? > > Because it makes for a inconsistent random experience p.s. :D i never wanted to do away with the blur in the first place, i think it's kinda cool, but

D4034: Show descriptive text when changing containment plugins

rooty added a comment. hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davided

D4034: Show descriptive text when changing containment plugins

rooty added a comment. nice! props REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davidedmundson, #plasma, mart Cc: ngraham, rooty, broulik, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. hey i just set up these revisions and i'm liking the new theme one problem though, it seems as though Suspend, Restart, Shutdown are showing up as 12pt instead of 11pt or 10pt? it just looks a little too big compared to (when i force) 11pt REPOSITORY R120 Plasma Wo

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. hey nate would you consider changing all the #232629 outlines to #4d4d4d? they come out a little strong when set to #232629 imo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmunds

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. thanks! and good luck! sorry about the little ones hope they get well soon REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: romangg, davidedmundson, rizzitello, abetts, ps

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. sorry to be a bore, but how do you guys feel about removing the outline and tinkering with DropShadow instead? i set it to: radius: 12 samples: 32 spread: 0.35 color: Qt.rgba(0, 0, 0, 1) and this is what happens on top of a very messy bright backg

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. nice! i've been tinkering with this some more over the past few days (it's been driving me a little nuts), and i've been using "spread: 0.1" on the clock shadow while keeping "spread: 0.35" on the username and action button shadows i've been doing this because "0.35"

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Leaner separators in Kickoff (lowered opacity, narrower/shorter) REPOSITORY R119 Plasma Desktop BRANCH kickoff-leaner-separators (

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. In D16937#360667 , @ngraham wrote: > But now when the tab bar is on the top or bottom, the separators will have different widths, which doesn't look good. To be honest, I'm not sure what the actual problem is here.

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. > FWIW make sure to test your changes with all four possible orientations. I actually figured out how to do that just before my latest edit, my bad. It seems to work sort of fine with the tabs on the left or the right, except for the lower separator (to the left/ri

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. > Are these problems because of your change or on current master as well? Are they something worth fixing in your opinion? > > Otherwise visually would be a nice change. Current lines are too strong. Actually, the bugs are already present in master, and using a

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. Okay so, it took me a while to figure out (total noob here I'm telling you) - the key was to add frameVisible:false at line 60 of KickoffListView.qml. Then the extra (overlapping) separators are gone. Check it out: F6428936: image.png

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty updated this revision to Diff 45679. rooty added a comment. - Fix double separator issue left over from master (remove scrolling frame) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45618&id=45679 BRANCH kickoff-leaner-separators (

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty updated this revision to Diff 45680. rooty added a comment. - Change focus: false back to focus: true (change not required, a slip) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45679&id=45680 BRANCH kickoff-leaner-separators (bran

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. In D16937#361182 , @ngraham wrote: > I could get behind reducing the opacity. Perhaps to 0.7 or 0.6. Removing the frame for the scroll area to get rid of the extra lines on the top or bottom when it's scrollable could also

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty updated this revision to Diff 45696. rooty added a comment. - Raise the separator opacity by 0.05 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45680&id=45696 BRANCH kickoff-leaner-separators (branched from master) REVISION DETAIL

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. In D16937#361224 , @romangg wrote: > Would someone take a look at the Simple Menu code to see if the unfocused search field code can be copied over directly to Kickoff (separate review though)? Long story short, no

D16988: [Kickoff] Make the visible search field unfocused by default

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Changes: applets/kickoff/package/contents/ui/Header.qml This patch: (1) Keeps the search field visible by default but leaves it u

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45750. rooty added a comment. - Remove unnecessary states, tidy things up REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45747&id=45750 BRANCH kickoff-visible-and-unfocused (branched from master) REVIS

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45751. rooty added a comment. - Tidy up some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45750&id=45751 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https://pha

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45753. rooty added a comment. - Fix broken states and return ability to hover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45751&id=45753 BRANCH kickoff-visible-and-unfocused (branched from master) R

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45757. rooty added a comment. - Trim unnecessary code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45753&id=45757 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https:/

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important focus is. Making sure that the active element both has and looks like it has focus

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Right, I agree. In fact, that's how Kicker does it: the search field is focused by default, but if you mouse over a list item, then focus visually moves to the list. I'm supportive of doing that sort of thing here. Then the Kicker and Kickoff search fields would even

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. People have been complaining about the blur, but is it necessary to do away with it, or is it a better idea to run with it like they do in Windows Fluent Design (Deepin too actually)? F6431816: image.png This theme, for exam

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Actually this sounds like it might help our cause. Especially when the search bar can be tabbed into, that's really nice. The problem is that we would like to focus to be on the selected item, such as the one that gets launched when pressing enter. The search should

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. @gladhorn More food for though, by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input even though you've technically navigated away from it. Should this functionality be k

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Okay so from what I can tell: (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the arrow keys (to add more words etc.) (2) Krunner bec

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362206 , @chempfling wrote: > In D16988#362160 , @rooty wrote: > > > Okay so from what I can tell: > > > > (1) Kicker takes the focus off the search field when yo

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. my real name is Kresimir Cohar, email address: kco...@gmail.com thanks you guys :D i just realized i have a pseudonym on kde identity... i might have to fix that REPOSITORY R119 Plasma Desktop BRANCH kickoff-leaner-separators (branched from master) REVISION

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Why does it make it easy? Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I think my point was that it works regardless of the focus being drawn away from it?) > - By default search field looks unactivated but has focus. Arrow up/dow

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362281 , @romangg wrote: > I like all the changes, but they should go into separate patches: Patches that would patch this patch or patches that would each patch master separately? REPOSITORY R119 Plasm

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > You can do this as you see fit. I would recommend though in this case to make a patch series where patches depend on each other since otherwise it can become difficult to keep all the independent patches consistent with each other. Excellent. > I believe in

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Thanks! Ironically, I do like it focused too 🤣 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45820. rooty added a comment. - [Kickoff] Make search field unfocused but visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45757&id=45820 BRANCH kickoff-visible-and-unfocused (branched from master

D17020: [Kickoff] Depends on D16988, Reenable hover to show system information

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch reenables the mouseover to show system information function introduced by Nate Graham and tailors it to D16988

D17022: [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY #Summary: #Test Plan: #Subscribers: 1. NEW DIFFERENTIAL REVISION 2. Describe the changes in this new revision. # I

D17023: [Kickoff] Depends on D16988, Change search label and username font size

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Included commits in branch kickoff-visible-and-unfocused-fonts-type: 78eb4b0d4e08 [Kickoff] Depends on D16988

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362566 , @ngraham wrote: > Thing is, if we're going to reduce the blur that much, why not just show the original image? That's a fair point. Another fair point: Why not just pick an image that doesn't re

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362635 , @ngraham wrote: > In D16031#362634 , @rooty wrote: > > > Another fair point: Why not just pick an image that doesn't really interfere with the boxes and icon

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. this has been bugging me/us for years, glad you finally decided to patch it :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #plasma Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. NativeRendering truly is the gift that keeps on giving F6432893: nativerendering.png This is what happens if I specify that JobDetailsItem.qml use QtRendering F6432899: qtrendering.png RE

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. (LOL I accidentally removed the comment) NativeRendering really is the gift that keeps on giving. F6432908: nativerendering.png QtRendering renders a lot better. F6432910: qtrendering.png

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362786 , @hein wrote: > This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. The rasterization should be consistent throughout the system and consistent

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362808 , @broulik wrote: > > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. > > It does because it's using a `TextEdit` directly to make

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty added a comment. In D17022#362813 , @davidedmundson wrote: > I appreciate the effort to split up a big commit, but this isn't quite right. > > There's duplicated code changes both here and in https://phabricator.kde.org/D17020

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty updated this revision to Diff 45868. rooty added a comment. - Remove duplicated code common to D17020 , D17022 and D17023 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D17023: [Kickoff] Change search label and username font size

rooty updated this revision to Diff 45869. rooty added a comment. - Remove (duplicated) code shared with D17020 and D17022 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1702

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. In D16879#362527 , @ngraham wrote: > IMHO spread 0.1 doesn't provide enough contrast against the toughest backgrounds: > > F6432627: Screenshot_20181119_124804.png ouch yo

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#366146 , @ngraham wrote: > D17020 , D17022 , and D17023 still include duplicated changes from this pat

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#367971 , @filipf wrote: > In D16988#367970 , @rooty wrote: > > > Suffice it to say, you can't use any of the other patches (except the font size / label change) witho

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#368991 , @ngraham wrote: > You have two options: > > - Stop insulting people and their work > - Go away naaate you're taking all of this way too personally first of all,, @raddison's got a valid poi

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. so i take it you're open to the idea of an unobtrusive type of blur? i get that you want to preserve the wallpaper, but sometimes it really does get in the way (snow, mountains, clouds, etc.) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kd

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. > That's not a feature we have; the wallpapers of the lock screen, login screen, and desktops are all independent. Whether or not this is desirable is an entirely different issue, but operating with the limitation of not having that, there is no point to a "mild blur"

D17615: [FolderView] Fix blurry icon labels

rooty added a comment. yup i rename it and it turns all blurry, irrespective of where the panel is or how much the icons have been selected / moved around REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615 To: filipf, #plasma Cc: rooty, plasma-devel, GB_2,

D17615: [FolderView] Fix blurry icon labels

rooty added a comment. my bad, i just didn't copy the entire contents of the plasma-desktop/containments/desktop/package/contents/ui/code folder off of github (just the FolderItemDelegate.qml), it works fine now that it's all up to date REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

D17598: Improve "No internet connection!" error message

rooty added a comment. loving the icon, it really stresses the importance of checking whether your internet connection's working without being (too) imposing REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL http

D17598: Improve "No internet connection!" error message

rooty added a comment. it might work on the left, but i think this is better because it takes up the entire pane, and is important enough to warrant doing so for example, F6517329: image.png F6517334: image.png

D17916: [Login and lock screens] Do not use light font styles for the sddm clock

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch removes the line of code that required that the lock screen use a light font style. This patch is also closely related to

D17916: [Login and lock screens] Do not use light font styles for the sddm clock

rooty updated this revision to Diff 48534. rooty added a comment. Apply patch to login theme as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17916?vs=48531&id=48534 BRANCH normal-fonts-lckscrclock (branched from master) REVISION DETAIL

D17020: [Kickoff] Reenable hover to show system information

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17020 To: rooty, ngraham, romangg Cc: filipf, plasma-devel, GB_2, ragreen, Pitel, Z

D16988: [Kickoff] Make the visible search field unfocused by default

rooty abandoned this revision. rooty added a comment. Seeing as this causes the latest plasmashell to lock up and I was never too enthusiastic about the change either, I'm going to close this, sorry guys. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988

D17934: [Kickoff] Increase Kickoff information label readability

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch vertically centers the information label (infolabel) that appears once a user hovers/runs over their username with their m

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: filipf, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot

D17935: [Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds the ellipsis (...) to the search field label in Clipboard so as to make it consistent with the labels in Kickoff, Kicke

D17023: [Kickoff] Change search label and username font size

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17023 To: rooty, romangg, ngraham Cc: mart, filipf, plasma-devel, GB_2, ragreen, Pi

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: filipf, abetts, davidedmundson, plasma-devel,

D17023: [Kickoff] Change search label and username font size

rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17023 To: rooty, romangg, ngraham Cc: mart, filipf, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-

D17934: [Kickoff] Increase Kickoff information label readability

rooty updated this revision to Diff 48644. rooty added a comment. Roll back vertical alignment change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17934?vs=48578&id=48644 BRANCH centered-infolabel (branched from master) REVISION DETAIL https:

D17975: [WIP, Notifications] Add padding to notifications

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch aims to add padding to the notification widget and fully remedy the issues that arise once it is applied. TEST PLAN [Comi

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48708. rooty added a comment. Correct spelling REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48707&id=48708 BRANCH notification-padding (branched from master) REVISION DETAIL https://phabricator.k

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Hey so I'd also like for the Open... (image three in each set) button to shift by one units.smallSpacing to the left. The close button does, if I add "rightMargin: units.smallSpacing" into ColumnLayout / mainLayout, but the Open... button doesn't. I just don't kn

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Okay, so I figured out how to add padding to the buttons as well, by adding a right margin to the mainLayout part (hence the deleted comment describing how I couldn't figure it out, my bad): F6525782: before-n-after.png REPOS

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48709. rooty added a comment. Add margins to the right of the buttons on the right border REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48708&id=48709 BRANCH notification-padding (branched from maste

  1   2   >