rooty added a comment.
In D16988#366146 <https://phabricator.kde.org/D16988#366146>, @ngraham wrote: > D17020 <https://phabricator.kde.org/D17020>, D17022 <https://phabricator.kde.org/D17022>, and D17023 <https://phabricator.kde.org/D17023> still include duplicated changes from this patch. > > The idea was to make all of your Kickoff patches independent of each other, or at least to thin out the dependency tree so that all the patches depend on a single ancestor patch that only has uncontroversial refactoring changes. Right now the dependency on this one means that all of your other much-less-controversial changes are gated on getting acceptance for making the search field visually unfocused by default. > > Am I making any sense? No. What you're saying makes a kind of sense until you actually think about it - while it's possible to change D17023 <https://phabricator.kde.org/D17023> to make it more discrete (it's a font size and label change, basically three lines of code), even that makes little sense in the face of a focused search field that would be present without all the other patches. It's not possible to make D17022 <https://phabricator.kde.org/D17022> or D17020 <https://phabricator.kde.org/D17020> (//**re**//-enable hover) independent because they //quite literally// depend on an unfocused search field and are bug fixes for issues that this here diff introduces. So it makes //very little if any sense// to make them independent (the current Kickoff doesn't have these bugs). Suffice it to say, you can't use any of the other patches (except the font size / label change) without this one. P.S. If you want to reject the patch based on controversy, that's fine with me. I don't care much about the focus anyway tbh REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
