Re: Review Request: Tasks applet: group popup with real task items

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review448 --- Ship it! - Aaron On 2009-03-08 15:22:38, Christian Mollekopf wrote: >

Re: Review Request: Tasks applet: group popup with real task items

2009-03-08 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/ --- (Updated 2009-03-08 15:22:38.552515) Review request for Plasma, Aaron Seigo and M

Re: Review Request: Tasks applet: group popup with real task items

2009-03-08 Thread Christian Mollekopf
> On 2009-03-08 09:19:15, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp, line > > 565 > > > > > > using an event filter just to hide the window on lost focus seems a bit > > ov

Re: Review Request: Tasks applet: group popup with real task items

2009-03-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review406 --- Ship it! other a single issue it looks good (and an improvement for sur

Review Request: Tasks applet: group popup with real task items

2009-03-08 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- This pa

Re: tasks applet: group popup

2009-02-24 Thread Christian Mollekopf
On Tuesday 24 February 2009 21:43:45 Aaron J. Seigo wrote: > On Tuesday 24 February 2009, Christian Mollekopf wrote: > > On Tuesday 24 February 2009 20:47:17 Aaron J. Seigo wrote: > > > On Tuesday 24 February 2009, Christian Mollekopf wrote: > > > > Since i'm totally unexperienced with such stuff i

Re: tasks applet: group popup

2009-02-24 Thread Aaron J. Seigo
On Tuesday 24 February 2009, Christian Mollekopf wrote: > On Tuesday 24 February 2009 20:47:17 Aaron J. Seigo wrote: > > On Tuesday 24 February 2009, Christian Mollekopf wrote: > > > Since i'm totally unexperienced with such stuff it would be nice if > > > someone could tell me if this could work o

Re: tasks applet: group popup

2009-02-24 Thread Christian Mollekopf
On Tuesday 24 February 2009 20:47:17 Aaron J. Seigo wrote: > On Tuesday 24 February 2009, Christian Mollekopf wrote: > > Since i'm totally unexperienced with such stuff it would be nice if > > someone could tell me if this could work or rather not. > > you would need to replace the now-offscreen it

Re: tasks applet: group popup

2009-02-24 Thread Aaron J. Seigo
On Tuesday 24 February 2009, Christian Mollekopf wrote: > Since i'm totally unexperienced with such stuff it would be nice if someone > could tell me if this could work or rather not. you would need to replace the now-offscreen item with a spacer item of the same size (and keep them in sync) so t

Re: tasks applet: group popup

2009-02-24 Thread Christian Mollekopf
On Tuesday 24 February 2009 00:05:53 Christian Mollekopf wrote: > Hi, > > I already started with the popup and it seems to work quite nicely, but i > would like to have your comments on how i intend to go on. > > According to marcos suggestions i'm currently displaying a LayoutWidget in > a Plasma:

Re: tasks applet: group popup

2009-02-23 Thread Christian Mollekopf
On Tuesday 24 February 2009 00:24:50 Aaron J. Seigo wrote: > On Monday 23 February 2009, Christian Mollekopf wrote: > > Hi, > > > > I already started with the popup and it seems to work quite nicely, but i > > would like to have your comments on how i intend to go on. > > just for my own clarity, w

Re: tasks applet: group popup

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Christian Mollekopf wrote: > Hi, > > I already started with the popup and it seems to work quite nicely, but i > would like to have your comments on how i intend to go on. just for my own clarity, which popup are you referring to exactly? > For displaying i think it wo

tasks applet: group popup

2009-02-23 Thread Christian Mollekopf
Hi, I already started with the popup and it seems to work quite nicely, but i would like to have your comments on how i intend to go on. According to marcos suggestions i'm currently displaying a LayoutWidget in a Plasma::Dialog which leads to a similar result as the current popupMenu. Since d