Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Hi, This is same #105677 but for plasmapkg2 Diffs - src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 Diff: https://git.reviewboard.kde.org/r/126418/diff

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
- > > (Updated Dez. 18, 2015, 6:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Hi, > > This is same #105677 but for plasmapkg2 > > &

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
6:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Hi, > > This is same #105677 but for plasmapkg2 > > > Diffs > - > > src/plasmapkg/plasmapkg.c

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-20 Thread Albert Astals Cid
.kde.org/r/126418/ > --- > > (Updated Dec. 18, 2015, 6:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Hi, > > This is same #

[Differential] [Closed] D4046: Use kpackagetool5 instead of plasmapkg

2017-01-09 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:82eacb574c92: Use kpackagetool5 instead of plasmapkg (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4046?vs=9921&id=9938 REVI

[Differential] [Accepted] D4046: Use kpackagetool5 instead of plasmapkg

2017-01-09 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4046 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Request, 7 lines] D4046: Use kpackagetool5 instead of plasmapkg

2017-01-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's been deprecated for a bit Also register it in drkonqi REPOSITORY R120 Plasma Workspace BRANCH mas

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread Antonis Tsiapaliokas
discarded. Review request for kwin, Plasma and Martin Gräßlin. Repository: kde-runtime Description --- Hello, This patch is adding support for "plasmapkg -t kwindecoration" Diffs - plasma/tools/plasmapkg/main.cpp 3dc061c Diff: https://git.reviewboard.kde.org/r/1

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread David Edmundson
- > > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diffs > - > > plasma/tools/plasmapkg/main.cpp 3dc061c > > Diff: https://git.reviewboard.kde.org/r/105677/diff/ > > > Testing > --- > > > Thanks, > > Antonis Tsiapaliokas > >

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2015-12-21 Thread Sebastian Kügler
d Dec. 18, 2015, 6:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Hi, > > This is same #105677 but for plasmapkg2 > > > Diffs > - > > src/p

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2015-12-18 Thread Martin Gräßlin
c. 18, 2015, 7:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Hi, > > This is same #105677 but for plasmapkg2 > > > Diffs > - > > src/p

Review Request 126418: Add KWin/Decoration support to plasmapkg

2015-12-18 Thread Demitrius Belai
) - Add KWin/Decoration support to plasmapkg Repository: plasma-framework Description --- Hi, This is same #105677 but for plasmapkg2 Diffs (updated) - src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 Diff: https://git.reviewboard.kde.org/r/126418/diff

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
> > > Description > --- > > ...so it can be co-installed in the same prefix as kde-runtime(4) > > > Diffs > - > > src/plasmapkg/CMakeLists.txt a9e186f > > Diff: https://git.reviewboard.kde.org/r/115605/diff/ > > > Testing &

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Mark Gaiser
> Repository: plasma-framework > > > Description > --- > > ...so it can be co-installed in the same prefix as kde-runtime(4) > > > Diffs > - > > src/plasmapkg/CMakeLists.txt a9e186f > >

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Commit Hook
t; ...so it can be co-installed in the same prefix as kde-runtime(4) > > > Diffs > - > > src/plasmapkg/CMakeLists.txt a9e186f > > Diff: https://git.reviewboard.kde.org/r/115605/diff/ > > > Testing > --- > > Builds > > > Thank

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Hrvoje Senjan
marked as submitted. Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
Feb. 10, 2014, 11:45 a.m.) > > > Review request for KDE Frameworks, Plasma and Sebastian Kügler. > > > Repository: plasma-framework > > > Description > --- > > ...so it can be co-installed in the same prefix as kde-runtime(4) > > > Diffs >

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Hrvoje Senjan
, Plasma and Sebastian Kügler. Changes --- Renamed to plasmapkg2 Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs (updated) - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
scription > --- > > ...so it can be co-installed in the same prefix as kde-runtime(4) > > > Diffs > - > > src/plasmapkg/CMakeLists.txt a9e186f > > Diff: https://git.reviewboard.kde.org/r/115605/diff/ > > > Testing > --- > >

Review Request 115605: Rename plasmapkg

2014-02-09 Thread Hrvoje Senjan
. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan

Re: Crash in plasmapkg

2014-01-13 Thread Marco Martin
On Sat, Jan 11, 2014 at 6:14 PM, Bhushan Shah wrote: > Hello, > > I am getting crash in plasmapkg --list-types, I can not find required > component on BKO so reporting it here. > > #0 Plasma::PlasmaPkgPrivate::renderTypeTable (this=0x8064d68, > plugins=...) at > /

Crash in plasmapkg

2014-01-11 Thread Bhushan Shah
Hello, I am getting crash in plasmapkg --list-types, I can not find required component on BKO so reporting it here. #0 Plasma::PlasmaPkgPrivate::renderTypeTable (this=0x8064d68, plugins=...) at /home/bshah/kdesrc/plasma-framework/src/plasmapkg/plasmapkg.cpp:488 #1 0x08052370 in Plasma

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/ --- (Updated Oct. 14, 2013, 1:40 p.m.) Status -- This change has been dis

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
looks for in > order to uninstall or install a plugin. The other problem is that themes > aren't really plugins, so plasmapkg -t theme -r blah fails. This patch fixes > the second issue. I'll upload another patch for review that fixes the first > issue. > > > Di

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails. This patch fixes the s

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
for in > order to uninstall or install a plugin. The other problem is that themes > aren't really plugins, so plasmapkg -t theme -r blah fails. This patch fixes > the second issue. I'll upload another patch for review that fixes the first > issue. > > > Di

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Marco Martin
is that the tar packages downloaded from kde-look and > other kns services contain a subfolder with the theme name, that then > contains the metadata.desktop file that plasma::PackageStructure looks for in > order to uninstall or install a plugin. The other problem is that themes >

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-20 Thread Sebastian Kügler
ing wrote: > Ok, I just tried repackaging Helium from kde-look.org with the contents > directly in the .tar.xz rather than in a subfolder Helium. With my other > plasmapkg patch that installs and uninstalls just fine. So the question then > becomes are these themes on kde-lo

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-19 Thread Jeremy Paul Whiting
aging Helium from kde-look.org with the contents directly in the .tar.xz rather than in a subfolder Helium. With my other plasmapkg patch that installs and uninstalls just fine. So the question then becomes are these themes on kde-look.org packaged with some tool? or just packaged by hand incorr

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/#review38015 --- Hmm, not sure about it, the packages were defined as archives w

Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-16 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/ --- Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and

Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-16 Thread Jeremy Paul Whiting
that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails. This patch fixes the second issue. I'll upload another patch for review that fixes the first issu

Re: Predictability in plasmapkg behavior

2013-03-14 Thread Aleix Pol
On Wed, Mar 13, 2013 at 8:50 PM, Aaron J. Seigo wrote: > On Wednesday, March 13, 2013 19:01:26 Aleix Pol wrote: > > - Assuming plasmoids is wrong, if we want plasmapkg to be for more things > > than plasmoids. > > Agreed .. patches welcome :) > > > - I'm uns

Re: Predictability in plasmapkg behavior

2013-03-14 Thread Sebastian Kügler
On Wednesday, March 13, 2013 19:01:26 Aleix Pol wrote: > - Assuming plasmoids is wrong, if we want plasmapkg to be for more things > than plasmoids. I think it's fine to keep it as default, but maybe we want to check the servicetype in the metadata.desktop file and compare it with

Re: Predictability in plasmapkg behavior

2013-03-13 Thread Aaron J. Seigo
On Wednesday, March 13, 2013 19:01:26 Aleix Pol wrote: > - Assuming plasmoids is wrong, if we want plasmapkg to be for more things > than plasmoids. Agreed .. patches welcome :) > - I'm unsure in what cases -t should be used. Is it only for bypassing > errors in the package?

Predictability in plasmapkg behavior

2013-03-13 Thread Aleix Pol
thank you :)), then I told him: - Well, it's very easy, just use plasmapkg to install it. First, it wasn't obvious for him how to do that (he's a hacker too, so probably he could have known, but it's definitely not obvious). Anyway, I told him to use "plasmapkg --install

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2013-02-08 Thread Albert Astals Cid
org/r/105677/ > --- > > (Updated July 23, 2012, 2:47 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > --- > > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diff

Re: Review Request: Move the plasmapkg doc into kde-runtime

2012-11-29 Thread Commit Hook
to the right > repos. > The first one is 107448. > > Also I have attached a patch which move the plasmapkg doc from the root dir. > > > Diffs > - > > CMakeLists.txt 5b6ffbf > man-plasmapkg.1.docbook PRE-CREATION > > Diff: http://git.reviewboard.kde

Re: Review Request: Move the plasmapkg doc into kde-runtime

2012-11-29 Thread Commit Hook
to the right > repos. > The first one is 107448. > > Also I have attached a patch which move the plasmapkg doc from the root dir. > > > Diffs > - > > CMakeLists.txt 5b6ffbf > man-plasmapkg.1.docbook PRE-CREATION > > Diff: http://git.reviewboard.kde

Re: Review Request: Move the plasmapkg doc into kde-runtime

2012-11-29 Thread Aaron J. Seigo
d Nov. 24, 2012, 5:13 p.m.) > > > Review request for Plasma. > > > Description > --- > > This is the second patch for the move of the plasma-tools docs into the right > repos. > The first one is 107448. > > Also I have attached a patch w

Review Request: Move the plasmapkg doc into kde-runtime

2012-11-24 Thread Giorgos Tsiapaliokas
for the move of the plasma-tools docs into the right repos. The first one is 107448. Also I have attached a patch which move the plasmapkg doc from the root dir. Diffs - CMakeLists.txt 5b6ffbf man-plasmapkg.1.docbook PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107449/diff

Re: Review Request: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2012-07-26 Thread Antonis Tsiapaliokas
t; Description > --- > > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diffs > - > > plasma/tools/plasmapkg/main.cpp 3dc061c > > Diff: http://git.reviewboard.kde.org/r/105677/diff/ > > > Testin

Re: Review Request: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2012-07-26 Thread Marco Martin
oard.kde.org/r/105677/ > --- > > (Updated July 23, 2012, 2:47 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > --- > > Hello, > > This patch is

Re: Review Request: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2012-07-26 Thread Marco Martin
d July 23, 2012, 2:47 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > --- > > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diffs > - > > plasma/tools/p

Re: Review Request: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2012-07-23 Thread Martin Gräßlin
; > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diffs > - > > plasma/tools/plasmapkg/main.cpp 3dc061c > > Diff: http://git.reviewboard.kde.org/r/105677/diff/ > > > Testing > --- > &g

Review Request: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2012-07-23 Thread Antonis Tsiapaliokas
--- Hello, This patch is adding support for "plasmapkg -t kwindecoration" Diffs - plasma/tools/plasmapkg/main.cpp 3dc061c Diff: http://git.reviewboard.kde.org/r/105677/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Pl

Re: Review Request: Plasmapkg: Plasmapkg -t can now detect the correct serviceType

2012-06-11 Thread Aaron J. Seigo
ted June 11, 2012, 10:23 a.m.) > > > Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. > > > Description > --- > > Hello, > > With this patch if the user types plasmapkg -t "Plasma/LayoutTemplate" -u > path_to_package, then th

Re: Review Request: Plasmapkg: Plasmapkg -t can now detect the correct serviceType

2012-06-11 Thread Antonis Tsiapaliokas
, Aaron J. Seigo, and Martin Gräßlin. Changes --- In this patch i am fixing the issues that they have been pointed out by Aaron. Description --- Hello, With this patch if the user types plasmapkg -t "Plasma/LayoutTemplate" -u path_to_package, then the plasmapkg is converting t

Re: Review Request: Plasmapkg: Plasmapkg -t can now detect the correct serviceType

2012-06-11 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105215/#review14607 --- plasma/tools/plasmapkg/main.cpp <h

Re: plasmapkg and Layout Template

2012-06-11 Thread Antonis Tsiapaliokas
I have done it :) Here is the linkto the reviewboard. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Plasmapkg: Plasmapkg -t can now detect the correct serviceType

2012-06-11 Thread Antonis Tsiapaliokas
. Description --- Hello, With this patch if the user types plasmapkg -t "Plasma/LayoutTemplate" -u path_to_package, then the plasmapkg is converting the "Plasma/LayoutTemplate" in "Layout/Template", in order for plasmapkg to be able to install the package. Also the s

Re: plasmapkg and Layout Template

2012-06-11 Thread Aaron J. Seigo
On Sunday, June 10, 2012 18:56:44 Antonis Tsiapaliokas wrote: > "layout-tempalte". So here is my question, should there be correspondance > between the package name and the type of the package? i think it would make sense to make it also accept the ServiceType as the type for the plugins. that wo

plasmapkg and Layout Template

2012-06-10 Thread Antonis Tsiapaliokas
Hello, The menu of the list-types from the plasmapkg is the following. But the argument -t doesn't work, because if you pass "plasmapkg -t "Layout Template" -u path_to_layout" it will say that the "Layout Template" is an invalid package. This is happening be

Re: Review Request: Support KWin packages in plasmapkg

2012-02-18 Thread Commit Hook
org/r/104000/ > --- > > (Updated Feb. 17, 2012, 11:29 a.m.) > > > Review request for Plasma. > > > Description > --- > > Makes plasmapkg aware of the KWin packages currently present in master or in

Re: Review Request: Support KWin packages in plasmapkg

2012-02-17 Thread Marco Martin
org/r/104000/ > --- > > (Updated Feb. 17, 2012, 11:29 a.m.) > > > Review request for Plasma. > > > Description > --- > > Makes plasmapkg aware of the KWin packages currently present in master or in > the pipeline to be shortly supported. That is: > * window s

Review Request: Support KWin packages in plasmapkg

2012-02-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104000/ --- Review request for Plasma. Description --- Makes plasmapkg aware of

Re: plasmapkg removing

2011-12-21 Thread Nowardev-Team
> if the plugin name changed, then yes, you need to uninstall the old plugin. > alternatively, it may just be that kbuidsycoca4 needs to be run. in any > case, > take a look at what is in ~/.kde/share/kde4/services. the entries for the > various items shoudl be there. > > thank you :D i felt lost r

Re: plasmapkg removing

2011-12-21 Thread Aaron J. Seigo
On Tuesday, December 20, 2011 11:10:13 Nowardev-Team wrote: > i have created a Remove panels but it is shown like 1_Remove panel that was > the name i given to it before > and even gnome2 is lowercase > > :S i have to remove something ? if the plugin name changed, then yes, you need to uninstall

plasmapkg removing

2011-12-20 Thread Nowardev-Team
Hi , i have some strange behavior here installing my panels svn export https://plasma-panels-script.googlecode.com/svn/trunk/usr/share/kde4/apps/plasma/layout-templates-test now with zipping folders and running plasmapkg -t layout-template -i "$file" this should do everything

Re: Review Request: Fix crash in plasmapkg

2010-12-22 Thread Aaron Seigo
> > Review request for Plasma. > > > Summary > --- > > when using plasmapkg -t theme -u > /home/neoclust/.kde4/share/apps/desktoptheme/G-Remix/metadata.desktop ( > which is a wrong use of the tool i agree ) plasmapkg crash. > > this is because arc

Re: Review Request: Fix crash in plasmapkg

2010-12-22 Thread Nicolas Lécureuil
--- remove space in the if() according to kdelibs coding policy Summary --- when using plasmapkg -t theme -u /home/neoclust/.kde4/share/apps/desktoptheme/G-Remix/metadata.desktop ( which is a wrong use of the tool i agree ) plasmapkg crash. this is because archive is set to 0 and

Review Request: Fix crash in plasmapkg

2010-12-22 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6184/ --- Review request for Plasma. Summary --- when using plasmapkg -t theme

Re: Review Request: Make plasmapkg work for languages in which package types have capital letters

2010-06-16 Thread Aaron Seigo
his addresses bug 230645. > https://bugs.kde.org/show_bug.cgi?id=230645 > > > Diffs > - > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1138554 > > Diff: http://reviewboard.kde.org/r/4339/diff > > > Testing > --- > > Compi

Review Request: Make plasmapkg work for languages in which package types have capital letters

2010-06-16 Thread Matteo Agostinelli
k/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1138554 Diff: http://reviewboard.kde.org/r/4339/diff Testing --- Compiles and works Thanks, Matteo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmapkg & wallpaper

2009-11-03 Thread Aaron Seigo
> Review request for Plasma. > > > Summary > --- > > * install wallpaper plasma packages > * auto detect (plasmoids,) dataengines, runners and wallpapers (install them > without --type) > * Remove previous package also with --install > > > Diffs > - >

Re: Review Request: plasmapkg & wallpaper

2009-11-03 Thread Petri Damstén
> On 2009-11-03 17:07:50, Aaron Seigo wrote: > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp, lines 137-138 > > <http://reviewboard.kde.org/r/2006/diff/2/?file=13546#file13546line137> > > > > does this work for zip'd up packages as

Re: Review Request: plasmapkg & wallpaper

2009-11-03 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2903 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp <h

Re: Review Request: plasmapkg & wallpaper

2009-11-02 Thread Petri Damstén
On Friday 30 October 2009 10:07:28 Petri Damstén wrote: > (Updated 2009-10-30 08:07:28.008673) > > > Review request for Plasma. > > > Changes > --- > > * --type wallpaper works for both wallpaper plugin and wallpaper image > packages. * install / upgrade reverted to original Is there som

Re: Review Request: plasmapkg & wallpaper

2009-10-30 Thread Petri Damstén
also with --install Diffs (updated) - /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 Diff: http://reviewboard.kde.org/r/2006/diff Testing --- Thanks, Petri ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
> > > > > some but not enough, really. > > > > > > > > > (couldn't find it on websvn) but it has failed for me at some > > > > > occasions where it removed the content and not the directory > > > > > therefore letting plasmapk

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
is not installed." > > > > I don't know if Plasma::PackageStructure->uninstallPackage() has any > > > > error checking > > > > > > some but not enough, really. > > > > > > > (couldn't find it on websvn) but it has f

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
gt; > > > (couldn't find it on websvn) but it has failed for me at some > > > occasions where it removed the content and not the directory therefore > > > letting plasmapkg fail on both -i and -r. > > > > "the content"? you mean the service file

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
ee below. > > I don't know if Plasma::PackageStructure->uninstallPackage() has any > > error checking > > some but not enough, really. > > > (couldn't find it on websvn) but it has failed for me at some > > occasions where it removed the content and not th

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
. > (couldn't find it on websvn) but it has failed for me at some > occasions where it removed the content and not the directory therefore > letting plasmapkg fail on both -i and -r. "the content"? you mean the service file? or? personally, i'd also like to se

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
On 29/10-2009 17:09 "Aaron Seigo" wrote: > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp > <http://reviewboard.kde.org/r/2006/#comment2217> > > with this there really is no point in having "upgrade". the idea is > that in

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2852 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp <h

Review Request: plasmapkg & wallpaper

2009-10-29 Thread Petri Damstén
* auto detect (plasmoids,) dataengines, runners and wallpapers (install them without --type) * Remove previous package also with --install Diffs - /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 Diff: http://reviewboard.kde.org/r/2006/diff Testing --- Thanks

Re: plasmapkg -r failed

2009-10-23 Thread Thomas Olsen
On 23/10-2009 21:57 Chani wrote: > On October 23, 2009 04:07:19 Thomas Olsen wrote: > > I was fiddling with my Currency Converter Plasmoid and suddenly I > > couldn't install it with "plasmapkg -i currency-converter-0.3.plasmoid". > > I already had run "p

Re: plasmapkg -r failed

2009-10-23 Thread Chani
On October 23, 2009 04:07:19 Thomas Olsen wrote: > I was fiddling with my Currency Converter Plasmoid and suddenly I couldn't > install it with "plasmapkg -i currency-converter-0.3.plasmoid". I already > had run "plasmapkg -r currency-converter" but tried to

plasmapkg -r failed

2009-10-23 Thread Thomas Olsen
I was fiddling with my Currency Converter Plasmoid and suddenly I couldn't install it with "plasmapkg -i currency-converter-0.3.plasmoid". I already had run "plasmapkg -r currency-converter" but tried to do it again to no avail as the error message said that it wasn&#

Re: Are scripted DataEngines supposed to be installed through plasmapkg?

2008-12-30 Thread Luca Beltrame
On martedì 30 dicembre 2008 01:00:55 Aaron J. Seigo wrote: > did you pass -t dataengine to plasmapkg? otherwise it will assume a > plasmoid. My bad, I forgot about that. In fact when I do this everything works. Sorry for the noise. signature.asc Description: This is a digitally signed m

Re: Are scripted DataEngines supposed to be installed through plasmapkg?

2008-12-29 Thread Aaron J. Seigo
gt; > And the dataengine was installed under that path: did you pass -t dataengine to plasmapkg? otherwise it will assume a plasmoid. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software sig

Re: Are scripted DataEngines supposed to be installed through plasmapkg?

2008-12-29 Thread Luca Beltrame
[Pasting into a new message while my subscription request is handled, sorry for the trouble] >> but if I do so, both with my embryonic project and the example >> in SVN, I get errors (see the post I made on kde-bindings[1]). > what is in ~/share/apps/plasma/dataengines/? As a matter of fact, the

Re: Are scripted DataEngines supposed to be installed through plasmapkg?

2008-12-29 Thread Aaron J. Seigo
On Monday 29 December 2008, Luca Beltrame wrote: > Plasma. The directory structure suggested it could be installed through > plasmapkg, plasmapkg is supposed to be able to do so, yes. however, as these are fairly untested waters you may need to help with some debugging. > but if I do

Are scripted DataEngines supposed to be installed through plasmapkg?

2008-12-29 Thread Luca Beltrame
t could be installed through plasmapkg, but if I do so, both with my embryonic project and the example in SVN, I get errors (see the post I made on kde-bindings[1]). However, it occurred to me that perhaps it's not the way it's meant to be installed (since even in the CMakeLists.txt the

Re: Review Request: Add upgrade to plasmapkg

2008-11-02 Thread Aaron Seigo
> Review request for Plasma. > > > Summary > --- > > - Add upgrade (uninstall if exists and install) to plasmapkg > - Uninstall using package file name > - Call kbuilsycoca recreate using dbus after install / uninstall > - As a bonus listing works too > &

Review Request: Add upgrade to plasmapkg

2008-11-02 Thread Petri Damstén
exists and install) to plasmapkg - Uninstall using package file name - Call kbuilsycoca recreate using dbus after install / uninstall - As a bonus listing works too Diffs - /trunk/KDE/kdebase/workspace/plasma/tools/plasmapkg/main.cpp Diff: http://reviewboard.vidsolbach.de/r/249/diff

Re: plasmapkg

2008-10-31 Thread Petri Damstén
On Thursday 30 October 2008 15:11:15 Aaron J. Seigo wrote: > On Thursday 30 October 2008, Petri Damstén wrote: > > It gets installed packages before and after install to get installed > > package name(s). It then saves them to config so on uninstall we can get > > the name of the package for the pa

Re: GHNS & plasmapkg

2008-10-30 Thread Petri Damstén
On Wednesday 29 October 2008 21:57:44 Aaron J. Seigo wrote: > On Wednesday 29 October 2008, Petri Damstén wrote: > > On Wednesday 29 October 2008 05:08:32 Aaron J. Seigo wrote: > > > On Tuesday 28 October 2008, Petri Damstén wrote: > > > > Run kbuildsyscoca4

Re: plasmapkg

2008-10-30 Thread Petri Damstén
int = QString("[X-Plasma-PackageFile] == '%1'").arg(packageFile); } KService::List services = KServiceTypeTrader::self()->query("Plasma/" + type, constraint); foreach(const KService::Ptr &service, services) { result << service->pro

Re: plasmapkg

2008-10-30 Thread Aaron J. Seigo
On Thursday 30 October 2008, Petri Damstén wrote: > It gets installed packages before and after install to get installed > package name(s). It then saves them to config so on uninstall we can get > the name of the package for the package file. package files are guaranteed to be unique in name (so

plasmapkg

2008-10-30 Thread Petri Damstén
Hi, I'm trying to upgrade and uninstall from GHNS (uninstall command support still needed on that side) with plasmapkg. This adds (whole main.cpp attached) -- upgrade, --uninstall packagefile and working --list as a bonus. It's NOT meant to be committed as it is since it's '

Re: GHNS & plasmapkg

2008-10-29 Thread Petri Damstén
On Wednesday 29 October 2008 21:57:44 Aaron J. Seigo wrote: > > Does not work for me like this or from qdbusviewer. I think it's because > > I have plasma svn running on top of the kubuntu 4.1.2 and dbus calls the > > 4.1.2 kbuildsycoca, so I can't test this. (I think KProcess works since > > then

Re: GHNS & plasmapkg

2008-10-29 Thread Aaron J. Seigo
On Wednesday 29 October 2008, Petri Damstén wrote: > On Wednesday 29 October 2008 05:08:32 Aaron J. Seigo wrote: > > On Tuesday 28 October 2008, Petri Damstén wrote: > > > Run kbuildsyscoca4 from plasmapkg patch attached. > > > > this could probably be done via dbus a

Re: GHNS & plasmapkg

2008-10-29 Thread Petri Damstén
On Wednesday 29 October 2008 05:08:32 Aaron J. Seigo wrote: > On Tuesday 28 October 2008, Petri Damstén wrote: > > Run kbuildsyscoca4 from plasmapkg patch attached. > > this could probably be done via dbus and kded (faster, more reliable?) > > qdbus org.kde.kded /kbuilds

Re: GHNS & plasmapkg

2008-10-28 Thread Aaron J. Seigo
On Tuesday 28 October 2008, Petri Damstén wrote: > Run kbuildsyscoca4 from plasmapkg patch attached. this could probably be done via dbus and kded (faster, more reliable?) qdbus org.kde.kded /kbuildsycoca recreate so something like in the code: QDBusInterface dbus("org.

GHNS & plasmapkg

2008-10-28 Thread Petri Damstén
Hi, I'm testing GHNS for comics and have some problems. knsrc has: InstallationCommand=plasmapkg -t comic -i %f GHNS loaded plasma packages should be installed with plasmapkg (like in kdebase/workspace/libs/plasma/scripting/plasmoids.knsrc)? If yes then: - Uninstall only removes the downl