----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4339/#review6146 -----------------------------------------------------------
Ship it! looks fine, please commit. :) (if this were in a hot path, i'd probably suggest doing something more like if (type.compare(i18n(...), Qt::CaseInsensitive) == 0), but in this case it's really not an issue.. thanks for catching this one :) - Aaron On 2010-06-16 10:15:29, Matteo Agostinelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4339/ > ----------------------------------------------------------- > > (Updated 2010-06-16 10:15:29) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > Trivial fix for bug https://bugs.kde.org/show_bug.cgi?id=230645. Since type > is defined as: > QString type = args->getOption("type").toLower() > the subsequent checks should be made for lower case strings. > > > This addresses bug 230645. > https://bugs.kde.org/show_bug.cgi?id=230645 > > > Diffs > ----- > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1138554 > > Diff: http://reviewboard.kde.org/r/4339/diff > > > Testing > ------- > > Compiles and works > > > Thanks, > > Matteo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
