----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/#review38015 -----------------------------------------------------------
Hmm, not sure about it, the packages were defined as archives with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages? - Marco Martin On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112129/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 3:06 a.m.) > > > Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and > Sebastian Kügler. > > > Description > ------- > > This is the other half of the fix for the listed bug. I made > Plasma::PackageStructure::metadata look in the only subdirectory of an > extracted archive if there's only one subdirectory for the metadata.desktop > file. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479 > > > Diffs > ----- > > plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b > > Diff: http://git.reviewboard.kde.org/r/112129/diff/ > > > Testing > ------- > > The bug is fixed here with this and my other patch. Any better ideas for > getting the only subdirectory are welcome, it feels a bit kludgy as is. > > > Thanks, > > Jeremy Paul Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
