Re: AutostartScriptDesktopFile symbol lookup error

David R suggested it might be due to old libkworkspace being installed and after I removed and reinstalled those the problem seems to have gone away so life is good. Jonathan On Thu, 9 Feb 2023 at 21:12, Jonathan Riddell wrote: > I'm getting an error when compiling plasma-workspace ma

AutostartScriptDesktopFile symbol lookup error

I'm getting an error when compiling plasma-workspace master for KDE neon. It complains on startup of: startplasma-x11: symbol lookup error: startplasma-x11: undefined symbol: _ZN26AutostartScriptDesktopFileC1ERK7QStringS2_S2_ If I revert the recent commits to kcms/autostart then this pr

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

https://bugs.kde.org/show_bug.cgi?id=349795 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINF

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

https://bugs.kde.org/show_bug.cgi?id=349795 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular b

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

https://bugs.kde.org/show_bug.cgi?id=349795 Justin Zobel changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham abandoned this revision. ngraham added a comment. Looked into it and concluded that PolKit/Kauth are... special. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw, plasm

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham added a comment. Discover has the same issue. I guess I should look into fixing KAuth or Polkit or whatever is responsible for this. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc:

D29333: Don't show an empty error dialog when canceling the sync password prompt

filipf added a comment. Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/ We could work around all four though. I'm of the opinion that

D29333: Don't show an empty error dialog when canceling the sync password prompt

broulik added a comment. I would like KAuth or Polkit to be fixed to properly report user canceling REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw, plasma-devel, Orage, LeGas

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham added a comment. In D29333#661119 <https://phabricator.kde.org/D29333#661119>, @mthw wrote: > Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the a

D29333: Don't show an empty error dialog when canceling the sync password prompt

mthw added a comment. Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save chang

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham updated this revision to Diff 81674. ngraham added a comment. Fix comment (it's always something...) REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29333?vs=81673&id=81674 BRANCH dont-badget-user-with-empty-err

D29333: Don't show an empty error dialog when canceling the sync password prompt

the SDDM KCM and cancel the password dialog -> no empty error dialog shown now SYncing still works REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH dont-badget-user-with-empty-error-dialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D29333 AFFECTED FI

D28798: Make warning and error messages grammatically correct

This revision was automatically updated to reflect the committed changes. Closed by commit R845:d17f0e717fcf: Make warning and error messages grammatically correct (authored by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80031&am

D28798: Make warning and error messages grammatically correct

ngraham updated this revision to Diff 80031. ngraham added a comment. "because" is better REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80030&id=80031 BRANCH fix-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org

D28798: Make warning and error messages grammatically correct

ngraham updated this revision to Diff 80030. ngraham added a comment. ; -> as REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80028&id=80030 BRANCH fix-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org/D28798 AFF

D28798: Make warning and error messages grammatically correct

ivan added a comment. Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ? "Unable to close the vault; an application is using it" -> "Unable to close the vault because an application is using it" While writing for Mann

D28798: Make warning and error messages grammatically correct

ngraham created this revision. ngraham added reviewers: ivan, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY These messages are currently comma splices, which are incorrect. REPOSITORY R845 Plasma Vault

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

https://bugs.kde.org/show_bug.cgi?id=345440 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#636071 , @develoot wrote: > In D28200#633124 , @ngraham wrote: > > > Anyway, @develoot, could you provide your email address so we can land this patch with proper

D28200: Enable wrapping of error messages which use KMessageWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use KMessageWidget (authored by develoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D28200: Enable wrapping of error messages which use KMessageWidget

develoot added a comment. In D28200#633124 , @ngraham wrote: > Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? My email address is devel...@gmail.com. thanks. REPOSITO

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28200 To: develoot, #vdg, #plasma, #frameworks, davidedmundson Cc: d

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#632622 , @davidedmundson wrote: > > I wonder if it makes sense to set this on the widget itself, as a sensible default. > > No. > > Not because it's a better or worse default, but because making a beha

D28200: Enable wrapping of error messages which use KMessageWidget

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I wonder if it makes sense to set this on the widget itself, as a sensible default. No. Not because it's a better or worse default, but because making a behaviour

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. Thanks for the patch! I wonder if it makes sense to set this on the widget itself, as a sensible default. You're probably going to want to word-wrap more often than you aren't. REPOSITORY R119 Plasma Desktop REVISION DE

D28200: Enable wrapping of error messages which use KMessageWidget

develoot created this revision. develoot added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. develoot requested review of this revision. REVISION SUMMARY Error messages should be shown to users no matter how much long it is. REPOSITORY R119 Plasma

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

https://bugs.kde.org/show_bug.cgi?id=345440 --- Comment #4 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular b

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

would prevent you from deleting that folder on a POSIX level as well, so I would think that the access-denied error condition simply wasn't mapped to a pretty string in sftp. It is now however, so this should be solved in (at least) 19.12+ -- You are receiving this mail because: You ar

D27517: Better handle authentication error

apol added a comment. Review without knowing very well the codebase. INLINE COMMENTS > accountmodel.cpp:181 > { > -if(!index.isValid()) { > -return false; > +qDebug() << "AccountModel::setDataWithResult"; > +if (!index.isValid()) { Remove? > accountmodel.h:64 > +

D27517: Better handle authentication error

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417882 Not tested yet ! REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D27517

D26807: override picutils' error logger; it has an exit() call

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e677d2cc1b57: override picutils' error logger; it has an exit() call (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26807?vs=740

D26807: override picutils' error logger; it has an exit() call

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY instead simply run the output through qwarning as a cheap solution. FIXED-IN: 5.18.0 BUG: 382979 TEST PLAN builds, dont ha

D25780: [Notifications] Set total amount to processed amount if no total and no error

broulik abandoned this revision. broulik added a comment. Given the trash issue and the fact that fixing KDE Connect was easy, let's abandon this: https://invent.kde.org/kde/kdeconnect-kde/merge_requests/188/diffs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D25780: [Notifications] Set total amount to processed amount if no total and no error

broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Some jobs only set a processed amount and no total. This patch ensures when the job

D25320: Show startup error in popup as well

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7b033c52e1bc: Show startup error in popup as well (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25320?vs=69789&id=6

D25320: Show startup error in popup as well

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I wonder whether the `getStatus` handler could be cleaned up by removing the `UNKNOWN` value of `portStatus` and removing the `default:` case. REPOSITORY R856 Plasma Browser Integration RE

D25320: Show startup error in popup as well

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the host crashes, the error message is shown to the user. When startup fails, only a

[neon] [Bug 394459] "Invalid escape sequences in line" error in system log

https://bugs.kde.org/show_bug.cgi?id=394459 Harald Sitter changed: What|Removed |Added Assignee|plasma-devel@kde.org|neon-b...@kde.org Version|5.12.5

D24258: Forward error message from backend to ui

ngraham added a comment. Heh, if that's a more accurate error message, I as a user would still have no clue what do to about it... REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24258 To: nicolasfella, #plasma, #kwin Cc: ngraham, broulik, plasma-devel, LeGa

D24258: Forward error message from backend to ui

broulik added a comment. Maybe at least show "Failed to contact screen management service: $msg" REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24258 To: nicolasfella, #plasma, #kwin Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB

D24258: Forward error message from backend to ui

error in the backend. The backend gives us an error message we can display instead. TEST PLAN I get a different error message now REPOSITORY R104 KScreen BRANCH errormsg REVISION DETAIL https://phabricator.kde.org/D24258 AFFECTED FILES kcm/kcm.cpp kcm/kcm.h kcm/package/contents

D23846: Fix build error of wrong function reference

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf154a59148b: Fix compile (authored by lbeltrame). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23846?vs=65791&id=65815 REVISION DETAIL https://phabric

D23846: Fix build error of wrong function reference

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. LGTM this fixes plasma-workspace build REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23846 To: guoyunhe, #plasma, meven Cc: meven, plasma

D23846: Fix build error of wrong function reference

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Fix build error caused by D23840 <https://phabricator.kde.org/D23840> REPOSITORY R120 Plasma Workspace BRANCH

D23250: Try to fix i18n() timing error in version strings

ngraham updated this revision to Diff 64064. ngraham added a comment. Yeah, that seems to work too REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23250?vs=64005&id=64064 BRANCH try-to-fix-i18n-timing-error (branched from ma

D23250: Try to fix i18n() timing error in version strings

apol added a comment. Doesn't the visible addition solve it already? We can keep the i18n() call, it will fail in this case but since it's not visible it isn't a big problem anyway. @pino it's just not available in brief occasions when loading updates. REPOSITORY R134 Discover Softwar

D23250: Try to fix i18n() timing error in version strings

pino added a comment. This looks like a workaround to me: if `installedVersion` is not available (is it known when, actually?), why keep using it anyway, with or without i18n? Also, -1 to string puzzles and to UI strings not translatable. REPOSITORY R134 Discover Software Store REVISION

D23250: Try to fix i18n() timing error in version strings

ead. TEST PLAN Hard to reproduce, but in my testing, it works, and the available version string is empty until set, rather than showing a string formatting error. REPOSITORY R134 Discover Software Store BRANCH try-to-fix-i18n-timing-error (branched from master) REVISION DETAIL https://p

D17598: Improve "No internet connection!" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:131071136f56: Improve "No internet connection!" error message (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1759

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63734. ngraham added a comment. Fix diff REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=63723&id=63734 BRANCH arcpatch-D17598 REVISION DETAIL https://phabricator.kde.org/D17598 AFFECTED F

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63723. ngraham added a comment. Rebase and update message REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48441&id=63723 BRANCH arcpatch-D17598 REVISION DETAIL https://phabricator.kde.org/D

D17598: Improve "No internet connection!" error message

GB_2 added inline comments. INLINE COMMENTS > BrowsingPage.qml:73 > +horizontalAlignment: Text.AlignHCenter > +text: xi18nc("@info", "Unable to load > applicationsplease verify Internet connectivity") > +} I'd put a dot after "applications" and "conne

D22122: use pwquality_strerror to get error strings

This revision was automatically updated to reflect the committed changes. Closed by commit R128:29768b08aa06: use pwquality_strerror to get error strings (authored by sitter). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22122?vs=60770&id=6

D22122: use pwquality_strerror to get error strings

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. My bad, there were some typos in the value of the variable. I confirm that it works. +1 from the translation point of view. REPOSITORY R128 User Manager BRANCH master REVISION

D22122: use pwquality_strerror to get error strings

sitter added a comment. Is that with the latest diff (the one changed to fromUtf8)? LANGUAGE=uk seems to work for me F7126679: Screenshot_20190731_162607.png REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: s

D22122: use pwquality_strerror to get error strings

ltoscano added a comment. Sorry, I totally missed the notifications (but I received them). I think that there is an encoding issue with any characters over the canonical 127 base ones. Observed with Italian and Ukrainian, see F7126642: user-manager-pwquality-it.png

D19676: Fix out of bounds access error in SystemLoadViewer.qml

aacid added a comment. This is unlandable in KDE at this point because (say our sysadmins) "the nameservers for the domain estada.ch are highly unreliable and fail fairly often." and our git is very picky and doesn't like that. I don't particularly care about this piece of code, but if y

D9388: Fix queued connection error

aacid closed this revision. aacid added a comment. There's no minimizeall applet anymore REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9388 To: iromanov, graesslin, mart Cc: aacid, davidedmundson, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampalouk

D21517: Fix "Type error" when creating a TextField with focus: true

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:e419e9b42287: Fix "Type error" when creating a TextField with focus: true (authored by dfaure). He

D22122: use pwquality_strerror to get error strings

sitter added a comment. In D22122#487601 , @davidedmundson wrote: > Concept makes sense. > +1 > > @ltoscano can you confirm you're ok from an i18n side. ping @ltoscano REPOSITORY R128 User Manager REVISION DETAIL https://phab

D22207: Silence qml error message

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d80d3aaebadf: Silence qml error message (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22207?vs=60986&id=60989 REVISION DE

D22207: Silence qml error message

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY model.AppPid is documented to not always exist, so use the same check that is used in othere

D22122: use pwquality_strerror to get error strings

sitter updated this revision to Diff 60770. sitter added a comment. use fromUtf8 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22122?vs=60726&id=60770 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22122 AFFECTED FILES src/passwor

D22122: use pwquality_strerror to get error strings

davidedmundson added subscribers: ltoscano, davidedmundson. davidedmundson added a comment. Concept makes sense. +1 @ltoscano can you confirm you're ok from an i18n side. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: sitter, #plasma Cc: davide

D22122: use pwquality_strerror to get error strings

sitter added inline comments. INLINE COMMENTS > anthonyfieroni wrote in passworddialog.cpp:157 > Shouldn't be fromUtf8 ? You can't handle all languages by latin. Oh, indeed! REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: sitter, #plasma Cc: anthonyfier

D22122: use pwquality_strerror to get error strings

anthonyfieroni added inline comments. INLINE COMMENTS > passworddialog.cpp:157 > +const QString errorString = > +QString::fromLatin1(pwquality_strerror(buf, > PWQ_MAX_ERROR_MESSAGE_LEN, > + error, auxerror))

D22122: use pwquality_strerror to get error strings

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY libpwquality has localized error string mappings, no need to reinvent the wheel here. the previous

D19752: [Splash KCM] Use InlineMessage for testing error

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bbd7fcb3a300: [Splash KCM] Use InlineMessage for testing error (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19752?vs=53864&id=5

D19752: [Splash KCM] Use InlineMessage for testing error

ngraham added a comment. I think this is useful enough now, and we can tweak the error message later. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg, filipf Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2

D19752: [Splash KCM] Use InlineMessage for testing error

broulik added a comment. > Could the message include some hints of what failed? I don't know what failed, I just know the ksplash app crashed or got killed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg, filipf Cc: ngrah

D20819: Make really sure we show an error message in case saving failed

This revision was automatically updated to reflect the committed changes. Closed by commit R856:6ae424de5d13: Make really sure we show an error message in case saving failed (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https

D20819: Make really sure we show an error message in case saving failed

broulik updated this revision to Diff 57019. broulik added a comment. - Show `error`, if any REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20819?vs=56975&id=57019 REVISION DETAIL https://phabricator.kde.org/D20819 AFFECTED F

D20819: Make really sure we show an error message in case saving failed

e form of error > +saveMessage.innerText = "Saving settings failed > (" + e + ")"; > + } This should show `error` as well REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/

D20819: Make really sure we show an error message in case saving failed

API would just throw. Catch the most important bits of error reporting on save, so you're not left wondering why your settings don't change. TEST PLAN Was working on some settings bits, had to reload the extension often to test things and was always wondering why it didn't do

D20674: Word wrap "No backends found" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:4d644303be08: Word wrap "No backends found" error message (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2067

D20157: Remove critical error

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a796d7862581: Remove critical error notification (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20157?vs=55172&id=55174 REVISION DE

D20157: Remove critical error

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY None of the backends emit it the signal anymore. It is unlikely for the `connect()` to `Batt

D19971: Fix compilation error when SA_TRACE is 1

This revision was automatically updated to reflect the committed changes. Closed by commit R111:55aa93600b61: Fix compilation error when SA_TRACE is 1 (authored by zzag). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19971?vs=54550&id=5

D19752: [Splash KCM] Use InlineMessage for testing error

ngraham added a comment. Yeah I agree, this isn't a very actionable error message. What is the user supposed to make of it or do next? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg, filipf Cc: ngraham, abetts, f

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. Thank you: "Luca carlon ". REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

ngraham added a comment. I'll commit it for you (sorry for the delay, I was traveling). Can you provide your full name and email address so I can land it with proper attribution? REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jrale

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. Should I do something else or will someone else take care of committing? REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19752: [Splash KCM] Use InlineMessage for testing error

abetts added a comment. Could the message include some hints of what failed? Maybe the theme name? Something like: "Failed to test Adwaita splash screen, please check theme" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg

D19752: [Splash KCM] Use InlineMessage for testing error

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane. REPOSITORY R119 Pla

D19971: Fix compilation error when SA_TRACE is 1

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The error itself: /home/vlad/Workspace/KDE/src/kde/workspace/libksysguard/ksgrd/SensorAgent.cpp: In member function ‘void KSGRD

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. Hello. No, sorry, I don't think I have it. REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

ngraham accepted this revision. ngraham added a comment. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. I added the explicit charset to all scss files. REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 updated this revision to Diff 54514. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19931?vs=54457&id=54514 REVISION DETAIL https://phabricator.kde.org/D19931 AFFECTED FILES src/_colors.scss src/_functions.scss src/gtk318/gtk.scss src/gtk318/widgets/_app_notifications.sc

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. Happened on KDE Neon in docker. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

gepardo added a comment. Nice :) I have some suggestions to prevent such errors in the future: - `sass` (but not `sassc`) has `-E` option to set the encoding for building - it may be a good idea to add such lines to all the SCSS files BTW, where does the build error happen

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19931 AFFECTED FILES src/gtk318/widgets/_notebook.scss src/gtk320/widget

D19752: [Splash KCM] Use InlineMessage for testing error

`InlineLabel` and also makes process handling asynchronous to not block the settings dialog process and instead disables the controls within. TEST PLAN Made a ksplash theme that just froze the splash process, killed it, got this error. F6690792: Screenshot_20190314_103534.png <ht

D19676: Fix out of bounds access error in SystemLoadViewer.qml

stefantux created this revision. stefantux added a project: Plasma. Herald added a subscriber: plasma-devel. stefantux requested review of this revision. REVISION SUMMARY Fixes bugs on startup of plasmashell if the widget is loaded by the user BUG: 405346 REPOSITORY R114 Plasma Addons R

D19561: Don't crash if the fwupd error is null

This revision was automatically updated to reflect the committed changes. Closed by commit R134:1d8ab1561d0b: Don't crash if the fwupd error is null (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19561?vs=53263&

D19577: [sddm-theme/lock screen] Fix "unable to assign [undefined]" error

This revision was automatically updated to reflect the committed changes. Closed by commit R120:06793f21d1ce: [sddm-theme/lock screen] Fix "unable to assign [undefined]" error (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

D19577: [sddm-theme/lock screen] Fix "unable to assign [undefined] error

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch fixes the "Unable to assign [undefined] to QColor" and "Unable to assign [undefined] to int" errors that occur in UserDelega

D19561: Don't crash if the fwupd error is null

leinir added a comment. In D19561#425879 , @apol wrote: > Cool, thanks! remember to land in 5.15. Will do! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19561 To: leinir, #discover_software_

D19561: Don't crash if the fwupd error is null

apol accepted this revision. apol added a comment. Cool, thanks! remember to land in 5.15. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19561 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh,

  1   2   3   4   5   >