sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY libpwquality has localized error string mappings, no need to reinvent the wheel here. the previous mapping was fairly incomplete resulting in cases where one would get the generic "use another password" option was shown, which is fairly meh as it can mean literally anything. should libpwquality for whatever reason fail to provide a string we will still fall back to the unfortunate generic default. better than nothing I suppose. also carry around auxerror. it contains data such as how many digits would have been reuired. auxerror doesn't need freeing it simply contains pointers to internals for the benefit of pwquality_strerror CHANGELOG: Password quality problems are better explained in the UI TEST PLAN password 'a' now gets error'd as a palindrom rather than the generic error. other errors such as too-short, no-match continue to be reported properly as well REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D22122 AFFECTED FILES src/passworddialog.cpp src/passworddialog.h To: sitter, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
