ngraham added a comment.
In D29333#661119 <https://phabricator.kde.org/D29333#661119>, @mthw wrote: > Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it. This change only suppresses the dialog when the error message returned from the job is empty. If you cancel the password dialog, I'm not sure any extra notification is needed. Canceling an operation is pretty self-explanatory in the user's mind. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
