Re: Review Request: Density unit conversion

2009-07-16 Thread Kashyap Puranik
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/779/#review1625 --- Ship it! - Kashyap On 2009-05-31 06:59:50, Kashyap Puranik wrote: >

Re: Review Request: Density unit conversion

2009-07-16 Thread Carsten Niehaus
> On 2009-06-02 08:44:36, Aaron Seigo wrote: > > as this introduces new strings (and arguably a new feature :) it will have > > to wait for the 4.4 dev cycle to open up. > > > > in the meantime, the i18n here looks very wrong. shouldn't it be: > > > > i18np("density unit", "ounce per cubic foo

Re: Plasma Unit conversion library

2009-07-15 Thread Petri Damstén
On Wednesday 15 July 2009 16:53:03 Carsten Niehaus wrote: > As a sideissue, kashthealien created this request six weeks ago: > > http://reviewboard.kde.org/r/779/ > > Aaron mentioned i18n()-problems, but those are not patch specific but > lib-specific. I did i18n rewrite for the lib and adde

Re: Plasma Unit conversion library

2009-07-15 Thread Carsten Niehaus
Moin >> I'm not sure how to proceed when multiple projects in KDE start to >> use the same lib so I let others to answer to that. > they get moved somewhere common, though i don't know where this one > would go. it has kdelibs deps (so kde-support is out), i don't know if > it really fits into k

Re: Plasma Unit conversion library

2009-07-09 Thread Petri Damstén
On Tuesday 07 July 2009 20:35:18 Aaron J. Seigo wrote: > btw ... some things that would be great to get done as well: > > * currency conversions using the short names, e.g. cad, usd, nko, etc .. > typing "canadian dollar" is a little annoying ;) Yes they are upper case now (10 CAD > € works) but l

Re: Plasma Unit conversion library

2009-07-07 Thread Aaron J. Seigo
On Tuesday 07 July 2009, Petri Damstén wrote: > I'm not sure how to proceed when multiple projects in KDE start to use the > same lib so I let others to answer to that. they get moved somewhere common, though i don't know where this one would go. it has kdelibs deps (so kde-support is out), i don

Re: Plasma Unit conversion library

2009-07-07 Thread Petri Damstén
On Tuesday 07 July 2009 17:40:53 kashyap puranik wrote: > Hi, > > I have used the unit conversion library in the kde-plasma addons/libs > directory. > > I have modified the library to add an density unit conversion. > > Right now I am using it for Kalzium for unit co

Plasma Unit conversion library

2009-07-07 Thread kashyap puranik
Hi, I have used the unit conversion library in the kde-plasma addons/libs directory. I have modified the library to add an density unit conversion. Right now I am using it for Kalzium for unit conversion, I have it in a separate directory under kdeedu/kalzium . Is there any way, this library

Re: Review Request: Density unit conversion

2009-06-02 Thread Petri Damstén
On Tuesday 02 June 2009 20:34:01 Aaron J. Seigo wrote: > On Tuesday 02 June 2009, Petri Damstén wrote: > > I have plans to make translation better in 4.4. I guess singular, plural > > strings should be a one KLocalizedString but I'm not sure if it can be > > used that way? > > afaik, yes. and it's

Re: Review Request: Density unit conversion

2009-06-02 Thread Aaron J. Seigo
On Tuesday 02 June 2009, Petri Damstén wrote: > I have plans to make translation better in 4.4. I guess singular, plural > strings should be a one KLocalizedString but I'm not sure if it can be used > that way? afaik, yes. and it's in fact necessary to do translations correctly at all since some

Re: Review Request: Density unit conversion

2009-06-02 Thread Petri Damstén
On Tuesday 02 June 2009 18:44:31 Aaron Seigo wrote: > in the meantime, the i18n here looks very wrong. shouldn't it be: > > i18np("density unit", "ounce per cubic foot", "ounces per cubit foot", ..)? No, currently unit takes arguments as (singular, plural, symbol, ... > i seem to recall the trans

Re: Review Request: Density unit conversion

2009-06-02 Thread kashyap puranik
Ah thats a typo, I ll fix it. I don't really know about the translation part. I just copied from some other file. I needed the density part in Kalzium. Thanks for the advice :). I will try creating the branch and fixing the translation. Thank you :) ___

Re: Review Request: Density unit conversion

2009-06-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/779/#review1262 --- as this introduces new strings (and arguably a new feature :) it will h

Re: Review Request: Density unit conversion

2009-06-01 Thread Orcan Ogetbil
On Sun, May 31, 2009 at 9:58 AM, Kashyap Puranik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/779/ > --- > > Review request

Re: Review Request: Density unit conversion

2009-06-01 Thread Kashyap Puranik
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/779/ --- (Updated 2009-05-31 06:59:50.382549) Review request for Plasma. Summary ---

Review Request: Density unit conversion

2009-06-01 Thread Kashyap Puranik
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/779/ --- Review request for Plasma. Summary --- Adding 2 new files to facilitate the

Re: Unit conversion

2008-09-01 Thread Petri Damstén
On Monday 01 September 2008 16:07:08 Gerhard Gappmeier wrote: > The idea behind the tables is, > that it is not necessary to make own classes for each unit that > uses a different conversion and to write the conversion code again > and again for everything. Simpler conversions already use QHash an

Re: Unit conversion

2008-09-01 Thread Gerhard Gappmeier
Hi Petri there is also a unit conversion plasmoid in playground/base/plasma/applets/unitconverter This uses very generic code and just works on tables. But the tables are very small at the moment and don't contain many units. It's just an example. Maybe we can put this code together

Unit conversion

2008-09-01 Thread Petri Damstén
Hi, I was updating converter runner and decided to make conversion code more generic and converted it to a library. It can be used like this: Value v = Converter::self()->convert(Value(25.0, "kg"), "lb"); Or: Value v = Converter::self()->category("mass")->convert(Value(25.0, "kg"), "lb"); Publi