> On 2009-06-02 08:44:36, Aaron Seigo wrote:
> > as this introduces new strings (and arguably a new feature :) it will have
> > to wait for the 4.4 dev cycle to open up.
> >
> > in the meantime, the i18n here looks very wrong. shouldn't it be:
> >
> > i18np("density unit", "ounce per cubic foot", "ounces per cubit foot", ..)?
> >
> > i seem to recall the translators being very unhappy with the conversion
> > lib, and this is likely why ;) since there's a good amount of time to work
> > on this between now and 4.4, how about creating a branch in svn to do this
> > work, commit your patch (with the fixed yard -> foot thing) to that branch
> > and then work on fixing the i18n? when 4.4 opens you can then merge the
> > entire set of changes over into trunk/.
Has been addressed and commited with commit 994221
(http://websvn.kde.org/?view=rev&revision=994221).
- Carsten
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/779/#review1262
-----------------------------------------------------------
On 2009-05-31 06:59:50, Kashyap Puranik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/779/
> -----------------------------------------------------------
>
> (Updated 2009-05-31 06:59:50)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Adding 2 new files to facilitate the conversion of density units.
>
>
> Diffs
> -----
>
> kdeplasma-addons/libs/conversion/CMakeLists.txt 975387
> kdeplasma-addons/libs/conversion/converter.cpp 975387
> kdeplasma-addons/libs/conversion/density.h PRE-CREATION
> kdeplasma-addons/libs/conversion/density.cpp PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/779/diff
>
>
> Testing
> -------
>
> Tested and used.
>
>
> Thanks,
>
> Kashyap
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
