Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 30, 2016, 4:26 p.m.) Status -- This change has been m

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 25, 2016, 5:31 p.m., Andreas Kainz wrote: > > I'm not a big fan when you have one hidden feature to show an expand arrow. > > > > what's the difference between applications and devices? the grouping? in > > general I'm a big fan of a simple volumen widget where you can change the >

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93994 --- I'm not a big fan when you have one hidden feature to show an

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93991 --- Moving individual streams between devices is indeed probably

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On März 25, 2016, 4:15 nachm., Kai Uwe Broulik wrote: > > applet/contents/ui/ListItemBase.qml, lines 232-233 > > > > > > Is that thing still used given we don't have the ComboBox there > > anymore? Might allow

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 25, 2016, 4:15 p.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ListItemBase.qml, lines 232-233 > > > > > > Is that thing still used given we don't have the ComboBox there > > anymore? Might allow

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93988 --- Fix it, then Ship it! If usability has no further comments

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 25, 2016, 2:38 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 4:53 p.m., Thomas Pfeiffer wrote: > > Great that you're bringing streams back to the applet, much appreciated! > > > > I agree with Kai that we should hide the technical stream names, they are > > of no use to anybody not deeply interested in PulseAudio. If an application

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 4:53 p.m., Thomas Pfeiffer wrote: > > Great that you're bringing streams back to the applet, much appreciated! > > > > I agree with Kai that we should hide the technical stream names, they are > > of no use to anybody not deeply interested in PulseAudio. If an application

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93937 --- Great that you're bringing streams back to the applet, much a

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93933 --- Looks great, i want it for 5.6 :P 5.7 is far away... - Antho

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 2:50 p.m., Kai Uwe Broulik wrote: > > There was already a bunch of commented functionality that allowed that. You > > clicked an output and it would expand to reveal the applications. > > > > I like your tabbed approach much better as the UI is already cramped enough > > a

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 2:53 p.m., Kai Uwe Broulik wrote: > > src/pulseaudio.h, line 100 > > > > > > You don't actually use the sources, rather have a "count" property? I copied it from SinkModel::sinks(), just for

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93929 --- There was already a bunch of commented functionality that all

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93930 --- src/pulseaudio.h (line 100)

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 24, 2016, 2:22 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 24, 2016, 2:28 p.m.) Review request for Plasma and KDE Usa

Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- Review request for Plasma. Repository: plasma-pa Description --- A